You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildstream.apache.org by tv...@apache.org on 2021/02/04 08:22:44 UTC
[buildstream] 08/25: jobs/job: use named parameters for long list
This is an automated email from the ASF dual-hosted git repository.
tvb pushed a commit to branch aevri/win32_minimal
in repository https://gitbox.apache.org/repos/asf/buildstream.git
commit 1e08977bacd4d722130dd3f6a608090a25c46b57
Author: Angelos Evripiotis <je...@bloomberg.net>
AuthorDate: Tue Oct 8 13:45:43 2019 +0100
jobs/job: use named parameters for long list
This invocation seems potentially error-prone as it is quite long, use
named parameters to make it a bit safer.
---
src/buildstream/_scheduler/jobs/job.py | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/src/buildstream/_scheduler/jobs/job.py b/src/buildstream/_scheduler/jobs/job.py
index 940b7d2..7d901a3 100644
--- a/src/buildstream/_scheduler/jobs/job.py
+++ b/src/buildstream/_scheduler/jobs/job.py
@@ -201,14 +201,14 @@ class Job():
self._parent_start_listening()
child_job = self.create_child_job( # pylint: disable=assignment-from-no-return
- self.action_name,
- self._scheduler.context.messenger,
- self._scheduler.context.logdir,
- self._logfile,
- self._max_retries,
- self._tries,
- self._message_element_name,
- self._message_element_key
+ action_name=self.action_name,
+ messenger=self._scheduler.context.messenger,
+ logdir=self._scheduler.context.logdir,
+ logfile=self._logfile,
+ max_retries=self._max_retries,
+ tries=self._tries,
+ message_element_name=self._message_element_name,
+ message_element_key=self._message_element_key,
)
if self._scheduler.context.platform.does_multiprocessing_start_require_pickling():