[GitHub] [druid] zachjsh commented on a change in pull request #12264: Re-enable segment metadata cache when using external schema

[GitBox <gi...@apache.org>]

zachjsh commented on a change in pull request #12264:
URL: https://github.com/apache/druid/pull/12264#discussion_r809411728



##########
File path: sql/src/main/java/org/apache/druid/sql/calcite/schema/DruidSchema.java
##########
@@ -375,11 +373,7 @@ private void startCacheExec()
   @LifecycleStart
   public void start() throws InterruptedException
   {
-    if (druidSchemaManager == null || druidSchemaManager instanceof NoopDruidSchemaManager) {
-      startCacheExec();
-    } else {
-      initialized.countDown();
-    }
+    startCacheExec();

Review comment:
       What was the reasoning behind disabling the cache when schemaManager is enabled in first place?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org