[GitHub] [skywalking-showcase] wu-sheng commented on a diff in pull request #125: elasticsearch monitoring showcase

["wu-sheng (via GitHub)" <gi...@apache.org>]

wu-sheng commented on code in PR #125:
URL: https://github.com/apache/skywalking-showcase/pull/125#discussion_r1174238140


##########
deploy/platform/kubernetes/Makefile:
##########
@@ -136,6 +136,13 @@ feature-kubernetes-monitor:
 	$(eval HELM_OPTIONS := $(HELM_OPTIONS) --set kube-state-metrics.enabled=true)
 	$(eval HELM_OPTIONS := $(HELM_OPTIONS) --set opentelemetry.enabled=true)
 
+.PHONY: feature-elasticsearch-monitor
+feature-elasticsearch-monitor:
+	$(eval HELM_OPTIONS := $(HELM_OPTIONS) --set features.elasticsearchMonitor.enabled=true)
+	$(eval HELM_OPTIONS := $(HELM_OPTIONS) --set prometheus-elasticsearch-exporter.enabled=true)
+	$(eval HELM_OPTIONS := $(HELM_OPTIONS) --set prometheus-elasticsearch-exporter.es.uri=http://elasticsearch-master:9200)

Review Comment:
   What is recommended if the Elasticsearch is not used? 
   A warning or some mock Elasticsearch?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org