[GitHub] [incubator-druid] vogievetsky commented on issue #8554: Web console: polish the data loader

[GitBox <gi...@apache.org>]

vogievetsky commented on issue #8554: Web console: polish the data loader
URL: https://github.com/apache/incubator-druid/pull/8554#issuecomment-532817419
 
 
   @fjy this PR intentionally removes the default value from `useEarliestOffset`. It makes it required instead. Look at the screenshot I posted, after this PR you can no longer just click "Next" past the Tuning step. This is because it is very important for the user to consider `useEarliestOffset` and set it accordingly instead of just going with the default.
   
   Since the default is `false` right now if you run through the Kafka quickstart and do not read the instructions and just click `Next`, `Next`, `Next` (something that is very tempting to do) you will end up in a bad state where no data is coming in because no new data is flowing into Kafka.
   
   I have done the same for the `segmentGranularity` for batch ingestion.
   
   TL;DR: think of this PR as data loader speed humps intentionally there to flow the user down a bit in strategic places.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org