You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Yurii Shylov <yu...@gmail.com> on 2015/01/20 20:58:11 UTC

Review Request 30085: RU: says I do not have WPR enabled but it is set

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30085/
-----------------------------------------------------------

Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole.


Bugs: AMBARI-9221
    https://issues.apache.org/jira/browse/AMBARI-9221


Repository: ambari


Description
-------

1) YARN WRP property is not recognized by pre-upgrade checks;
2) Pre-upgrade check shows "unexpected server error" when can't find repo version, should be more specific;
3) Pre-upgrade check for services maintenance should ignore client only services.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/checks/HostsRepositoryVersionCheck.java 267c625 
  ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesMaintenanceModeCheck.java c448ec3 
  ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesYarnWorkPreservingCheck.java 7ab6e01 

Diff: https://reviews.apache.org/r/30085/diff/


Testing
-------

Manually tested on cluster with every service but Knox.

Doesn't include new tests, they are tracked in technical debt ticket


Thanks,

Yurii Shylov


Re: Review Request 30085: RU: says I do not have WPR enabled but it is set

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30085/#review68775
-----------------------------------------------------------

Ship it!


Ship It!

- Alejandro Fernandez


On Jan. 20, 2015, 7:58 p.m., Yurii Shylov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30085/
> -----------------------------------------------------------
> 
> (Updated Jan. 20, 2015, 7:58 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole.
> 
> 
> Bugs: AMBARI-9221
>     https://issues.apache.org/jira/browse/AMBARI-9221
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> 1) YARN WRP property is not recognized by pre-upgrade checks;
> 2) Pre-upgrade check shows "unexpected server error" when can't find repo version, should be more specific;
> 3) Pre-upgrade check for services maintenance should ignore client only services.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/checks/HostsRepositoryVersionCheck.java 267c625 
>   ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesMaintenanceModeCheck.java c448ec3 
>   ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesYarnWorkPreservingCheck.java 7ab6e01 
> 
> Diff: https://reviews.apache.org/r/30085/diff/
> 
> 
> Testing
> -------
> 
> Manually tested on cluster with every service but Knox.
> 
> Doesn't include new tests, they are tracked in technical debt ticket
> 
> 
> Thanks,
> 
> Yurii Shylov
> 
>


Re: Review Request 30085: RU: says I do not have WPR enabled but it is set

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30085/#review68771
-----------------------------------------------------------

Ship it!


Ship It!

- Dmitro Lisnichenko


On Jan. 20, 2015, 7:58 p.m., Yurii Shylov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30085/
> -----------------------------------------------------------
> 
> (Updated Jan. 20, 2015, 7:58 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole.
> 
> 
> Bugs: AMBARI-9221
>     https://issues.apache.org/jira/browse/AMBARI-9221
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> 1) YARN WRP property is not recognized by pre-upgrade checks;
> 2) Pre-upgrade check shows "unexpected server error" when can't find repo version, should be more specific;
> 3) Pre-upgrade check for services maintenance should ignore client only services.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/checks/HostsRepositoryVersionCheck.java 267c625 
>   ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesMaintenanceModeCheck.java c448ec3 
>   ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesYarnWorkPreservingCheck.java 7ab6e01 
> 
> Diff: https://reviews.apache.org/r/30085/diff/
> 
> 
> Testing
> -------
> 
> Manually tested on cluster with every service but Knox.
> 
> Doesn't include new tests, they are tracked in technical debt ticket
> 
> 
> Thanks,
> 
> Yurii Shylov
> 
>