You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Kalyani Kashikar <ka...@freestoneinfotech.com> on 2016/06/29 09:58:16 UTC

Review Request 49361: ATLAS-847 : UI: Audit versioning does not paginate details from Atlas server

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49361/
-----------------------------------------------------------

Review request for atlas, Madhan Neethiraj, Shwetha GS, Selvamohan Neethiraj, Suma Shivaprasad, and Hemanth Yamijala.


Bugs: ATLAS-847
    https://issues.apache.org/jira/browse/ATLAS-847


Repository: atlas


Description
-------

Handled Shwetha's comment.

Next previous button is shown instead of page number.
Audit table page size set as 25.


Diffs
-----

  dashboardv2/public/css/scss/override.scss 6fc1e1f 
  dashboardv2/public/js/templates/audit/AuditTableLayoutView_tmpl.html fca11a5 
  dashboardv2/public/js/views/audit/AuditTableLayoutView.js fd7fabe 

Diff: https://reviews.apache.org/r/49361/diff/


Testing
-------

**Verified following scenarios:** 

* Rendering audit table, it fetches 25 records.
* As user clicks on next button it fetches next 25 records (last record in current page is sent as startKey to fetch next page)
* As user clicks on Previous button (first record in current page is sent as startKey to fetch previous page)


Thanks,

Kalyani Kashikar


Re: Review Request 49361: ATLAS-847 : UI: Audit versioning does not paginate details from Atlas server

Posted by Kalyani Kashikar <ka...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49361/
-----------------------------------------------------------

(Updated July 12, 2016, 1 p.m.)


Review request for atlas, Madhan Neethiraj, Shwetha GS, Selvamohan Neethiraj, Suma Shivaprasad, and Hemanth Yamijala.


Bugs: ATLAS-847
    https://issues.apache.org/jira/browse/ATLAS-847


Repository: atlas


Description
-------

Handled Shwetha's comment.

Next previous button is shown instead of page number.
Audit table page size set as 25.


Diffs (updated)
-----

  dashboardv2/public/css/scss/override.scss 743728a 
  dashboardv2/public/css/scss/tag.scss a9cba82 
  dashboardv2/public/js/templates/audit/AuditTableLayoutView_tmpl.html fca11a5 
  dashboardv2/public/js/templates/schema/SchemaTableLayoutView_tmpl.html 5caa3ea 
  dashboardv2/public/js/templates/tag/addTagModalView_tmpl.html 7ada413 
  dashboardv2/public/js/utils/CommonViewFunction.js 782cb54 
  dashboardv2/public/js/views/audit/AuditTableLayoutView.js fd7fabe 
  dashboardv2/public/js/views/tag/addTagModalView.js f1cb026 

Diff: https://reviews.apache.org/r/49361/diff/


Testing
-------

**Verified following scenarios:** 

* Rendering audit table, it fetches 25 records.
* As user clicks on next button it fetches next 25 records (last record in current page is sent as startKey to fetch next page)
* As user clicks on Previous button (first record in current page is sent as startKey to fetch previous page)


Thanks,

Kalyani Kashikar