[GitHub] [spark] sandeep-katta commented on a diff in pull request #36695: [SPARK-38474][CORE] Use error class in org.apache.spark.security

[GitBox <gi...@apache.org>]

sandeep-katta commented on code in PR #36695:
URL: https://github.com/apache/spark/pull/36695#discussion_r897494579


##########
core/src/main/scala/org/apache/spark/security/SocketAuthHelper.scala:
##########
@@ -60,7 +61,7 @@ private[spark] class SocketAuthHelper(val conf: SparkConf) {
           shouldClose = false
         } else {
           writeUtf8("err", s)
-          throw new IllegalArgumentException("Authentication failed.")
+          throw SparkCoreErrors.authenticationFailedError("client")

Review Comment:
   It is still `IllegalArgumentException`, don't I need to update scaladoc with `SparkIllegalArgumentException` ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org