You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Dong Lin <li...@gmail.com> on 2014/08/05 22:52:01 UTC
Review Request 24340: Patch for KAFKA-1565
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24340/
-----------------------------------------------------------
Review request for kafka.
Bugs: KAFKA-1565
https://issues.apache.org/jira/browse/KAFKA-1565
Repository: kafka
Description
-------
KAFKA-1524; transactional producer
KAFKA-1526
KAFKA-1527
KAFKA-1541; tx request definitions in client package
KAFKA-1569; end to end correctness test for transactions
KAFKA-1522 Tansactional messaging request/response definitions
KAFKA-1523 Transaction manager module
KAFKA-1525 DumpLogSegments
KAFKA-1565 Transaction manager failover handling
Diffs
-----
bin/kafka-tx-consumer-test.sh PRE-CREATION
bin/kafka-tx-producer-test.sh PRE-CREATION
clients/src/main/java/org/apache/kafka/clients/NetworkClient.java 522881c972ca42ff4dfb6237a2db15b625334d7e
clients/src/main/java/org/apache/kafka/clients/producer/AbortTransactionException.java PRE-CREATION
clients/src/main/java/org/apache/kafka/clients/producer/InvalidTransactionStatusException.java PRE-CREATION
clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java 00775abbcac850b0f2bb9a70b6fbc7cdf319bcf6
clients/src/main/java/org/apache/kafka/clients/producer/MockProducer.java c0f1d57e0feb894d9f246058cd0396461afe3225
clients/src/main/java/org/apache/kafka/clients/producer/Producer.java 36e8398416036cab84faad1f07159e5adefd8086
clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java f9de4af426449cceca12a8de9a9f54a6241d28d8
clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java 1ed3c28b436d28381d9402896e32d16f2586c65e
clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordBatch.java dd0af8aee98abed5d4a0dc50989e37888bb353fe
clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java 6fb5b82dedb48d946d1ac1ec7a535bddfdc693fa
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionContext.java PRE-CREATION
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionControl.java PRE-CREATION
clients/src/main/java/org/apache/kafka/common/errors/TransactionCoordinatorNotAvailableException.java PRE-CREATION
clients/src/main/java/org/apache/kafka/common/errors/TransactionFailedException.java PRE-CREATION
clients/src/main/java/org/apache/kafka/common/protocol/ApiKeys.java 6fe7573973832615976defa37fe0dfbb8f911939
clients/src/main/java/org/apache/kafka/common/protocol/Errors.java 3374bd98be8e565608c4e764ed10afdae383fb6f
clients/src/main/java/org/apache/kafka/common/protocol/Protocol.java 044b03061802ee5e8ea4f1995fb0988e1a70e9a7
clients/src/main/java/org/apache/kafka/common/record/Compressor.java 0323f5f7032dceb49d820c17a41b78c56591ffc4
clients/src/main/java/org/apache/kafka/common/record/MemoryRecords.java 759f577eaf0e7d28a84926d4aa30f4ef0cb27bc2
clients/src/main/java/org/apache/kafka/common/record/Record.java 10df9fd8d3f4ec8c277650fa7eab269f3ea30d85
clients/src/main/java/org/apache/kafka/common/requests/OffsetCommitRequest.java PRE-CREATION
clients/src/main/java/org/apache/kafka/common/requests/TransactionCoordinatorMetadataRequest.java PRE-CREATION
clients/src/main/java/org/apache/kafka/common/requests/TransactionCoordinatorMetadataResponse.java PRE-CREATION
clients/src/main/java/org/apache/kafka/common/requests/TransactionRequest.java PRE-CREATION
clients/src/main/java/org/apache/kafka/common/requests/TransactionResponse.java PRE-CREATION
clients/src/test/java/org/apache/kafka/clients/producer/RecordAccumulatorTest.java 93b58d02eac0f8ca28440e3e0ebea28ed3a7673c
clients/src/test/java/org/apache/kafka/clients/producer/SenderTest.java 5489acac6806b3ae5e6d568d401d5a20c86cac05
clients/src/test/java/org/apache/kafka/clients/producer/TransactionContextTest.java PRE-CREATION
clients/src/test/java/org/apache/kafka/common/record/MemoryRecordsTest.java 94a11121e207d5cf94dbc94443a8aa7edf387782
core/src/main/scala/kafka/admin/TopicCommand.scala 8d5c2e7088fc6e8bf69e775ea7f5893b94580fdf
core/src/main/scala/kafka/api/RequestKeys.scala fbfc9d3aeaffed4ca85902125fcc1050086835db
core/src/main/scala/kafka/api/TransactionRequest.scala PRE-CREATION
core/src/main/scala/kafka/api/TransactionResponse.scala PRE-CREATION
core/src/main/scala/kafka/api/TxCoordinatorMetadataRequest.scala PRE-CREATION
core/src/main/scala/kafka/api/TxCoordinatorMetadataResponse.scala PRE-CREATION
core/src/main/scala/kafka/cluster/Partition.scala f2ca8562f833f09d96ec4bd37efcacf69cd84b2e
core/src/main/scala/kafka/common/ErrorMapping.scala 5559d26ba2b96059f719754a351fa4598ca8a70b
core/src/main/scala/kafka/common/Topic.scala ad759786d1c22f67c47808c0b8f227eb2b1a9aa8
core/src/main/scala/kafka/consumer/ConsumerConfig.scala 1cf2f62ba02e4aa66bfa7575865e5d57baf82212
core/src/main/scala/kafka/consumer/SimpleConsumer.scala 0e64632210385ef63c2ad3445b55ac4f37a63df2
core/src/main/scala/kafka/controller/ControllerChannelManager.scala 8763968fbff697e4c5c98ab1274627c192a4d26a
core/src/main/scala/kafka/message/Message.scala d2a7293c7be4022af30884330924791340acc5c1
core/src/main/scala/kafka/producer/BaseProducer.scala b0207930dd0543f2c51f0b35002e13bf104340ff
core/src/main/scala/kafka/server/KafkaApis.scala 0b668f230c8556fdf08654ce522a11847d0bf39b
core/src/main/scala/kafka/server/KafkaConfig.scala ef75b67b67676ae5b8931902cbc8c0c2cc72c0d3
core/src/main/scala/kafka/server/KafkaServer.scala c22e51e0412843ec993721ad3230824c0aadd2ba
core/src/main/scala/kafka/server/ReplicaManager.scala 6a56a772c134dbf1e70c1bfe067223009bfdbac8
core/src/main/scala/kafka/server/RequestPurgatory.scala 3d0ff1e2dbd6a5c3587cffa283db70415af83a7b
core/src/main/scala/kafka/server/TransactionManager.scala PRE-CREATION
core/src/main/scala/kafka/tools/DumpLogSegments.scala 6daf87b25a48a51aafb7dbe8d0c0371e0ea7501f
core/src/main/scala/kafka/tools/ProducerPerformance.scala fc3e7241dda0672deb8c5ce5d7c983c320ec45ee
core/src/main/scala/kafka/tools/SimpleConsumerPerformance.scala 7602b8d705970a5dab49ed36d117346a960701ac
core/src/main/scala/kafka/tools/TransactionalConsumerTest.scala PRE-CREATION
core/src/main/scala/kafka/tools/TransactionalProducerTest.scala PRE-CREATION
core/src/main/scala/kafka/utils/ZkUtils.scala dcdc1ce2b02c996294e19cf480736106aaf29511
core/src/test/scala/unit/kafka/api/RequestResponseSerializationTest.scala a2117b34c2ee3554602fe068eed0c90b075958c1
kafka-patch-review.py dc45549f886440f1721c60aab9aa0a4af9b4cbef
Diff: https://reviews.apache.org/r/24340/diff/
Testing
-------
Thanks,
Dong Lin
Re: Review Request 24340: Patch for KAFKA-1565
Posted by Dong Lin <li...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24340/
-----------------------------------------------------------
(Updated Aug. 5, 2014, 9:56 p.m.)
Review request for kafka.
Bugs: KAFKA-1565
https://issues.apache.org/jira/browse/KAFKA-1565
Repository: kafka
Description (updated)
-------
For KAFKA-1565 Transaction manager failover handling, please view diff between 2nd and 3rd revision.
Diffs
-----
core/src/main/scala/kafka/admin/TopicCommand.scala 8d5c2e7088fc6e8bf69e775ea7f5893b94580fdf
core/src/main/scala/kafka/api/RequestKeys.scala fbfc9d3aeaffed4ca85902125fcc1050086835db
core/src/main/scala/kafka/api/TransactionRequest.scala PRE-CREATION
core/src/main/scala/kafka/api/TransactionResponse.scala PRE-CREATION
core/src/main/scala/kafka/api/TxCoordinatorMetadataRequest.scala PRE-CREATION
core/src/main/scala/kafka/api/TxCoordinatorMetadataResponse.scala PRE-CREATION
core/src/main/scala/kafka/cluster/Partition.scala f2ca8562f833f09d96ec4bd37efcacf69cd84b2e
core/src/main/scala/kafka/common/ErrorMapping.scala 5559d26ba2b96059f719754a351fa4598ca8a70b
core/src/main/scala/kafka/common/Topic.scala ad759786d1c22f67c47808c0b8f227eb2b1a9aa8
core/src/main/scala/kafka/controller/ControllerChannelManager.scala 8763968fbff697e4c5c98ab1274627c192a4d26a
core/src/main/scala/kafka/message/Message.scala d2a7293c7be4022af30884330924791340acc5c1
core/src/main/scala/kafka/server/KafkaApis.scala 0b668f230c8556fdf08654ce522a11847d0bf39b
core/src/main/scala/kafka/server/KafkaConfig.scala ef75b67b67676ae5b8931902cbc8c0c2cc72c0d3
core/src/main/scala/kafka/server/KafkaServer.scala c22e51e0412843ec993721ad3230824c0aadd2ba
core/src/main/scala/kafka/server/ReplicaManager.scala 6a56a772c134dbf1e70c1bfe067223009bfdbac8
core/src/main/scala/kafka/server/RequestPurgatory.scala 3d0ff1e2dbd6a5c3587cffa283db70415af83a7b
core/src/main/scala/kafka/server/TransactionManager.scala PRE-CREATION
core/src/main/scala/kafka/utils/ZkUtils.scala dcdc1ce2b02c996294e19cf480736106aaf29511
core/src/test/scala/unit/kafka/api/RequestResponseSerializationTest.scala a2117b34c2ee3554602fe068eed0c90b075958c1
Diff: https://reviews.apache.org/r/24340/diff/
Testing
-------
Thanks,
Dong Lin
Re: Review Request 24340: Patch for KAFKA-1565
Posted by Dong Lin <li...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24340/
-----------------------------------------------------------
(Updated Aug. 5, 2014, 9:51 p.m.)
Review request for kafka.
Bugs: KAFKA-1565
https://issues.apache.org/jira/browse/KAFKA-1565
Repository: kafka
Description (updated)
-------
KAFKA-1522 Tansactional messaging request/response definitions
KAFKA-1565 Transaction manager failover handling
Diffs (updated)
-----
core/src/main/scala/kafka/admin/TopicCommand.scala 8d5c2e7088fc6e8bf69e775ea7f5893b94580fdf
core/src/main/scala/kafka/api/RequestKeys.scala fbfc9d3aeaffed4ca85902125fcc1050086835db
core/src/main/scala/kafka/api/TransactionRequest.scala PRE-CREATION
core/src/main/scala/kafka/api/TransactionResponse.scala PRE-CREATION
core/src/main/scala/kafka/api/TxCoordinatorMetadataRequest.scala PRE-CREATION
core/src/main/scala/kafka/api/TxCoordinatorMetadataResponse.scala PRE-CREATION
core/src/main/scala/kafka/cluster/Partition.scala f2ca8562f833f09d96ec4bd37efcacf69cd84b2e
core/src/main/scala/kafka/common/ErrorMapping.scala 5559d26ba2b96059f719754a351fa4598ca8a70b
core/src/main/scala/kafka/common/Topic.scala ad759786d1c22f67c47808c0b8f227eb2b1a9aa8
core/src/main/scala/kafka/controller/ControllerChannelManager.scala 8763968fbff697e4c5c98ab1274627c192a4d26a
core/src/main/scala/kafka/message/Message.scala d2a7293c7be4022af30884330924791340acc5c1
core/src/main/scala/kafka/server/KafkaApis.scala 0b668f230c8556fdf08654ce522a11847d0bf39b
core/src/main/scala/kafka/server/KafkaConfig.scala ef75b67b67676ae5b8931902cbc8c0c2cc72c0d3
core/src/main/scala/kafka/server/KafkaServer.scala c22e51e0412843ec993721ad3230824c0aadd2ba
core/src/main/scala/kafka/server/ReplicaManager.scala 6a56a772c134dbf1e70c1bfe067223009bfdbac8
core/src/main/scala/kafka/server/RequestPurgatory.scala 3d0ff1e2dbd6a5c3587cffa283db70415af83a7b
core/src/main/scala/kafka/server/TransactionManager.scala PRE-CREATION
core/src/main/scala/kafka/utils/ZkUtils.scala dcdc1ce2b02c996294e19cf480736106aaf29511
core/src/test/scala/unit/kafka/api/RequestResponseSerializationTest.scala a2117b34c2ee3554602fe068eed0c90b075958c1
Diff: https://reviews.apache.org/r/24340/diff/
Testing
-------
Thanks,
Dong Lin
Re: Review Request 24340: Patch for KAFKA-1565
Posted by Dong Lin <li...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24340/
-----------------------------------------------------------
(Updated Aug. 5, 2014, 9:49 p.m.)
Review request for kafka.
Bugs: KAFKA-1565
https://issues.apache.org/jira/browse/KAFKA-1565
Repository: kafka
Description (updated)
-------
KAFKA-1522 Tansactional messaging request/response definitions
Diffs (updated)
-----
core/src/main/scala/kafka/admin/TopicCommand.scala 8d5c2e7088fc6e8bf69e775ea7f5893b94580fdf
core/src/main/scala/kafka/api/RequestKeys.scala fbfc9d3aeaffed4ca85902125fcc1050086835db
core/src/main/scala/kafka/api/TransactionRequest.scala PRE-CREATION
core/src/main/scala/kafka/api/TransactionResponse.scala PRE-CREATION
core/src/main/scala/kafka/api/TxCoordinatorMetadataRequest.scala PRE-CREATION
core/src/main/scala/kafka/api/TxCoordinatorMetadataResponse.scala PRE-CREATION
core/src/main/scala/kafka/common/ErrorMapping.scala 5559d26ba2b96059f719754a351fa4598ca8a70b
core/src/main/scala/kafka/common/Topic.scala ad759786d1c22f67c47808c0b8f227eb2b1a9aa8
core/src/main/scala/kafka/controller/ControllerChannelManager.scala 8763968fbff697e4c5c98ab1274627c192a4d26a
core/src/main/scala/kafka/message/Message.scala d2a7293c7be4022af30884330924791340acc5c1
core/src/main/scala/kafka/server/KafkaApis.scala 0b668f230c8556fdf08654ce522a11847d0bf39b
core/src/main/scala/kafka/server/KafkaConfig.scala ef75b67b67676ae5b8931902cbc8c0c2cc72c0d3
core/src/main/scala/kafka/server/KafkaServer.scala c22e51e0412843ec993721ad3230824c0aadd2ba
core/src/main/scala/kafka/server/TransactionManager.scala PRE-CREATION
core/src/main/scala/kafka/utils/ZkUtils.scala dcdc1ce2b02c996294e19cf480736106aaf29511
core/src/test/scala/unit/kafka/api/RequestResponseSerializationTest.scala a2117b34c2ee3554602fe068eed0c90b075958c1
Diff: https://reviews.apache.org/r/24340/diff/
Testing
-------
Thanks,
Dong Lin