You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "eolivelli (via GitHub)" <gi...@apache.org> on 2023/05/11 12:35:52 UTC

[GitHub] [pulsar] eolivelli commented on a diff in pull request #20304: [fix][broker] Allow Access to System Topic Metadata for Reader Creation Post-Namespace Deletion

eolivelli commented on code in PR #20304:
URL: https://github.com/apache/pulsar/pull/20304#discussion_r1191112174


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java:
##########
@@ -4409,7 +4409,8 @@ public CompletableFuture<PartitionedTopicMetadata> getPartitionedTopicMetadata(
         // serve/redirect request else fail partitioned-metadata-request so, client fails while creating
         // producer/consumer
         authorizationFuture.thenCompose(__ ->
-                        checkLocalOrGetPeerReplicationCluster(pulsar, topicName.getNamespaceObject()))
+                        checkLocalOrGetPeerReplicationCluster(pulsar, topicName.getNamespaceObject(),
+                                SystemTopicNames.isSystemTopic(topicName)))

Review Comment:
   please add a comment here, about why system topics should be allowed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org