You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2021/09/20 15:16:51 UTC

[GitHub] [hadoop] ferhui commented on a change in pull request #3386: HDFS-16213. De-flake TestFsDatasetImpl#testDnRestartWithHardLink

ferhui commented on a change in pull request #3386:
URL: https://github.com/apache/hadoop/pull/3386#discussion_r712267897



##########
File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java
##########
@@ -1049,12 +1050,17 @@ static File moveBlockFiles(Block b, ReplicaInfo replicaInfo, File destdir)
   static File[] hardLinkBlockFiles(ReplicaInfo srcReplica, File dstMeta,
       File dstFile)
       throws IOException {
+    FsVolumeSpi srcReplicaVolume = srcReplica.getVolume();

Review comment:
       Hi @virajjasani here I have one question to ask you.
   It seems that there is no change in code logic. Are these codes for adding debug or trace info?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org