You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@allura.apache.org by br...@apache.org on 2026/08/06 17:16:18 UTC

(allura) 01/02: [#6687] mark rss as not a link

This is an automated email from the ASF dual-hosted git repository.

asf-gitbox-commits pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/allura.git

commit bacea1563d3fee55240cd92247cd8b5988aedd20
Author: Dave Brondsema <da...@brondsema.net>
AuthorDate: Thu Aug 6 13:01:25 2026 -0400

    [#6687] mark rss <guid> as not a link
---
 Allura/allura/model/artifact.py                        | 1 +
 ForgeGit/forgegit/tests/functional/test_controllers.py | 1 +
 2 files changed, 2 insertions(+)

diff --git a/Allura/allura/model/artifact.py b/Allura/allura/model/artifact.py
index 761f49f01..1ba02de73 100644
--- a/Allura/allura/model/artifact.py
+++ b/Allura/allura/model/artifact.py
@@ -1057,6 +1057,7 @@ def feed(cls, q, feed_type, title, link, description,
                           pubdate=r.pubdate,
                           description=r.description,
                           unique_id=h.absurl(r.unique_id),
+                          unique_id_is_permalink=False,
                           author_name=r.author_name,
                           author_link=h.absurl(r.author_link))
         return feed
diff --git a/ForgeGit/forgegit/tests/functional/test_controllers.py b/ForgeGit/forgegit/tests/functional/test_controllers.py
index fb986710a..4b6c18224 100644
--- a/ForgeGit/forgegit/tests/functional/test_controllers.py
+++ b/ForgeGit/forgegit/tests/functional/test_controllers.py
@@ -260,6 +260,7 @@ def test_feed(self):
             link = 'http://localhost/p/test/src-git/ci/9a7df788cf800241e3bb5a849c8870f2f8259d98/'
             assert earliest_commit.find('link').text == link
             assert earliest_commit.find('guid').text == link
+            assert earliest_commit.find('guid').attrib['isPermaLink'] == 'false'
 
         # .atom has slightly different structure
         prefix = '{http://www.w3.org/2005/Atom}'