[jira] [Commented] (JSPWIKI-665) Page View Plugin and page renames and deletions

["Glen Mazza (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/JSPWIKI-665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13485542#comment-13485542 ] 

Glen Mazza commented on JSPWIKI-665:
------------------------------------

This problem is making testing via the PageViewPluginTest difficult.  Enclosed patch fixes the problem with PVPT's testShowCountsBasic() by using new pages not referenced by any other test.  However, it introduces a problem in testShowCountsSorted() because it ends up seeing new pages (already deleted in testShowCountsBasic()) that end up conflicting with what it is trying to test.  Along with attached patch, I'd recommend disabling (ignoring) the testShowCountsSorted() just to allow JSPWiki to build until this issue is fixed.
                
> Page View Plugin and page renames and deletions
> -----------------------------------------------
>
>                 Key: JSPWIKI-665
>                 URL: https://issues.apache.org/jira/browse/JSPWIKI-665
>             Project: JSPWiki
>          Issue Type: Improvement
>          Components: Core & storage
>    Affects Versions: 2.8.4
>            Reporter: Bruno Peeters
>            Priority: Minor
>
> When a wiki page is renamed or deleted, the counters used by the PageViewPlugin (http://www.jspwiki.org/wiki/PageViewPlugin) are not adapted accordingly. As a results of this, the overview of counters can contains pages that do not exist anymore. The counters of these pages will not be incremented anymore, so they will disappear of the top list, but they still remain in the full list. It would make sense to remove the counters for deleted pages. It would defnitely make sense to update the counters when a page is renamed.
> A visit to a non existing page is also stored by the PageViewPlugin, eg by clicking on a link to a page showing the message "This page does not exist. Why don't you go and create it?" is stored as a valid visit. Counting visits to non existing pages seems something of very low value.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira