You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Chengwei Yang <ch...@gmail.com> on 2014/03/13 07:06:53 UTC
Review Request 19173: mesos--cluster.sh: do not say OK if fail
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19173/
-----------------------------------------------------------
Review request for mesos.
Bugs: MESOS-1090
https://issues.apache.org/jira/browse/MESOS-1090
Repository: mesos-git
Description
-------
mesos-<start|stop>-cluster.sh: do not say OK if fail
This is a small enhancement to mesos-<start|stop>-cluster.sh, so it
won't say kind of *OK* if it did fail.
Diffs
-----
src/deploy/mesos-start-cluster.sh.in 1221afa1ee79bfb11bf49939c5d269b1bf834e8d
src/deploy/mesos-stop-cluster.sh.in 6f71050fcad46cef7806e251a7eb6786de2f0c72
Diff: https://reviews.apache.org/r/19173/diff/
Testing
-------
done.
Thanks,
Chengwei Yang
Re: Review Request 19173: mesos--cluster.sh: do not say OK if
fail
Posted by "Timothy St. Clair" <ts...@redhat.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19173/#review37104
-----------------------------------------------------------
Ship it!
Ship It!
- Timothy St. Clair
On March 13, 2014, 6:06 a.m., Chengwei Yang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19173/
> -----------------------------------------------------------
>
> (Updated March 13, 2014, 6:06 a.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-1090
> https://issues.apache.org/jira/browse/MESOS-1090
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> mesos-<start|stop>-cluster.sh: do not say OK if fail
>
> This is a small enhancement to mesos-<start|stop>-cluster.sh, so it
> won't say kind of *OK* if it did fail.
>
>
> Diffs
> -----
>
> src/deploy/mesos-start-cluster.sh.in 1221afa1ee79bfb11bf49939c5d269b1bf834e8d
> src/deploy/mesos-stop-cluster.sh.in 6f71050fcad46cef7806e251a7eb6786de2f0c72
>
> Diff: https://reviews.apache.org/r/19173/diff/
>
>
> Testing
> -------
>
> done.
>
>
> Thanks,
>
> Chengwei Yang
>
>
Re: Review Request 19173: mesos--cluster.sh: do not say OK if
fail
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19173/#review38579
-----------------------------------------------------------
Ship it!
Ship It!
- Niklas Nielsen
On March 25, 2014, 6:23 p.m., Chengwei Yang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19173/
> -----------------------------------------------------------
>
> (Updated March 25, 2014, 6:23 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-1090
> https://issues.apache.org/jira/browse/MESOS-1090
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> mesos-<start|stop>-cluster.sh: do not say OK if fail
>
> This is a small enhancement to mesos-<start|stop>-cluster.sh, so it
> won't say kind of *OK* if it did fail.
>
> Review: https://reviews.apache.org/r/19173
>
>
> Diffs
> -----
>
> src/deploy/mesos-start-cluster.sh.in 1221afa1ee79bfb11bf49939c5d269b1bf834e8d
> src/deploy/mesos-stop-cluster.sh.in 6f71050fcad46cef7806e251a7eb6786de2f0c72
>
> Diff: https://reviews.apache.org/r/19173/diff/
>
>
> Testing
> -------
>
> done.
>
>
> Thanks,
>
> Chengwei Yang
>
>
Re: Review Request 19173: mesos--cluster.sh: do not say OK if
fail
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19173/#review38577
-----------------------------------------------------------
Patch looks great!
Reviews applied: [19173]
All tests passed.
- Mesos ReviewBot
On March 26, 2014, 1:23 a.m., Chengwei Yang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19173/
> -----------------------------------------------------------
>
> (Updated March 26, 2014, 1:23 a.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-1090
> https://issues.apache.org/jira/browse/MESOS-1090
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> mesos-<start|stop>-cluster.sh: do not say OK if fail
>
> This is a small enhancement to mesos-<start|stop>-cluster.sh, so it
> won't say kind of *OK* if it did fail.
>
> Review: https://reviews.apache.org/r/19173
>
>
> Diffs
> -----
>
> src/deploy/mesos-start-cluster.sh.in 1221afa1ee79bfb11bf49939c5d269b1bf834e8d
> src/deploy/mesos-stop-cluster.sh.in 6f71050fcad46cef7806e251a7eb6786de2f0c72
>
> Diff: https://reviews.apache.org/r/19173/diff/
>
>
> Testing
> -------
>
> done.
>
>
> Thanks,
>
> Chengwei Yang
>
>
Re: Review Request 19173: mesos--cluster.sh: do not say OK if
fail
Posted by Chengwei Yang <ch...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19173/
-----------------------------------------------------------
(Updated March 27, 2014, 10:09 a.m.)
Review request for mesos and Niklas Nielsen.
Bugs: MESOS-1090
https://issues.apache.org/jira/browse/MESOS-1090
Repository: mesos-git
Description
-------
mesos-<start|stop>-cluster.sh: do not say OK if fail
This is a small enhancement to mesos-<start|stop>-cluster.sh, so it
won't say kind of *OK* if it did fail.
Review: https://reviews.apache.org/r/19173
Diffs
-----
src/deploy/mesos-start-cluster.sh.in 1221afa1ee79bfb11bf49939c5d269b1bf834e8d
src/deploy/mesos-stop-cluster.sh.in 6f71050fcad46cef7806e251a7eb6786de2f0c72
Diff: https://reviews.apache.org/r/19173/diff/
Testing
-------
done.
Thanks,
Chengwei Yang
Re: Review Request 19173: mesos--cluster.sh: do not say OK if
fail
Posted by Chengwei Yang <ch...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19173/
-----------------------------------------------------------
(Updated March 26, 2014, 9:23 a.m.)
Review request for mesos.
Changes
-------
Added my handle to TODO as Niklas suggested.
Bugs: MESOS-1090
https://issues.apache.org/jira/browse/MESOS-1090
Repository: mesos-git
Description (updated)
-------
mesos-<start|stop>-cluster.sh: do not say OK if fail
This is a small enhancement to mesos-<start|stop>-cluster.sh, so it
won't say kind of *OK* if it did fail.
Review: https://reviews.apache.org/r/19173
Diffs (updated)
-----
src/deploy/mesos-start-cluster.sh.in 1221afa1ee79bfb11bf49939c5d269b1bf834e8d
src/deploy/mesos-stop-cluster.sh.in 6f71050fcad46cef7806e251a7eb6786de2f0c72
Diff: https://reviews.apache.org/r/19173/diff/
Testing
-------
done.
Thanks,
Chengwei Yang
Re: Review Request 19173: mesos--cluster.sh: do not say OK if
fail
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19173/#review38563
-----------------------------------------------------------
src/deploy/mesos-stop-cluster.sh.in
<https://reviews.apache.org/r/19173/#comment70824>
Great - thanks!
Can you add your handle to the TODO? The usual syntax is TODO(<handle>): <message>
- Niklas Nielsen
On March 12, 2014, 11:06 p.m., Chengwei Yang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19173/
> -----------------------------------------------------------
>
> (Updated March 12, 2014, 11:06 p.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-1090
> https://issues.apache.org/jira/browse/MESOS-1090
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> mesos-<start|stop>-cluster.sh: do not say OK if fail
>
> This is a small enhancement to mesos-<start|stop>-cluster.sh, so it
> won't say kind of *OK* if it did fail.
>
>
> Diffs
> -----
>
> src/deploy/mesos-start-cluster.sh.in 1221afa1ee79bfb11bf49939c5d269b1bf834e8d
> src/deploy/mesos-stop-cluster.sh.in 6f71050fcad46cef7806e251a7eb6786de2f0c72
>
> Diff: https://reviews.apache.org/r/19173/diff/
>
>
> Testing
> -------
>
> done.
>
>
> Thanks,
>
> Chengwei Yang
>
>