You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/10/26 07:03:07 UTC
[GitHub] [incubator-nuttx] yamt commented on a change in pull request #2111: LIBCXX related fixes
yamt commented on a change in pull request #2111:
URL: https://github.com/apache/incubator-nuttx/pull/2111#discussion_r511750792
##########
File path: libs/libxx/libcxx.defs
##########
@@ -20,22 +20,61 @@
VERSION=11.0.0
-$(TOPDIR)/include/libcxx:
+libcxx-$(VERSION).src.tar.xz:
Review comment:
because
1. it's convenient for me during development
2. it can be useful for offline build
##########
File path: libs/libxx/libcxx-misc.patch
##########
@@ -0,0 +1,22 @@
+--- libcxx/src/locale.cpp.orig4 2020-10-23 07:25:28.000000000 +0900
++++ libcxx/src/locale.cpp 2020-10-23 07:25:38.000000000 +0900
Review comment:
i suspect it's better to keep things separate for making them upstream.
this patch is separated because it isn't directly related to nuttx.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org