You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@uniffle.apache.org by zu...@apache.org on 2024/02/06 08:08:42 UTC
(incubator-uniffle) branch master updated: [MINOR] improvement(CI): Rework build and rust workflow events (#1508)
This is an automated email from the ASF dual-hosted git repository.
zuston pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-uniffle.git
The following commit(s) were added to refs/heads/master by this push:
new 2be821519 [MINOR] improvement(CI): Rework build and rust workflow events (#1508)
2be821519 is described below
commit 2be82151994947a9a9b799a38d2da7a928a23836
Author: Enrico Minack <gi...@enrico.minack.dev>
AuthorDate: Tue Feb 6 09:08:37 2024 +0100
[MINOR] improvement(CI): Rework build and rust workflow events (#1508)
### What changes were proposed in this pull request?
Rework events that trigger `build` and `rust` workflows: the `push` event only triggers on branches `master`, `branch-*` and tags, not on any other branch. Other branches are already covered by the `pull_request` event.
Further, allows to trigger those workflows on branches and tags manually.
### Why are the changes needed?
Currently you have both `push` and `pull_request` run on commits done to branches that have pull requests. Branches are eventually merged into one of the above branches via pull requests. Hence, running `push` on those branches is pretty redundant.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Manually.
---
.github/workflows/build.yml | 12 ++++++++++--
.github/workflows/rust.yml | 14 +++++++++++---
.github/workflows/test-results.yml | 2 +-
3 files changed, 22 insertions(+), 6 deletions(-)
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 766d18c2d..9a232523c 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -17,7 +17,15 @@
name: build
-on: [push, pull_request]
+on:
+ push:
+ branches:
+ - 'master'
+ - 'branch-*'
+ tags:
+ - '*'
+ pull_request:
+ workflow_dispatch:
concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
@@ -52,7 +60,7 @@ jobs:
with:
maven-args: test-compile spotbugs:check
cache-key: spotbugs
-
+
java-11:
needs: [spotbugs] # delay execution
name: 'compile'
diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml
index 29c60fcbd..ba19555a8 100644
--- a/.github/workflows/rust.yml
+++ b/.github/workflows/rust.yml
@@ -17,7 +17,15 @@
name: Rust
-on: [push, pull_request]
+on:
+ push:
+ branches:
+ - 'master'
+ - 'branch-*'
+ tags:
+ - '*'
+ pull_request:
+ workflow_dispatch:
env:
CARGO_TERM_COLOR: always
@@ -34,7 +42,7 @@ jobs:
- name: Install native libs
run: sudo apt-get install -y libkrb5-dev libgsasl-dev
-
+
- name: Install Protoc
uses: arduino/setup-protoc@v2
with:
@@ -59,4 +67,4 @@ jobs:
- name: Run tests with memory-prof
working-directory: ./rust/experimental/server
run: cargo test --verbose --features memory-prof
- if: ${{ matrix.features == 'memory-prof' }}
\ No newline at end of file
+ if: ${{ matrix.features == 'memory-prof' }}
diff --git a/.github/workflows/test-results.yml b/.github/workflows/test-results.yml
index 2ac7aa82a..7950b1394 100644
--- a/.github/workflows/test-results.yml
+++ b/.github/workflows/test-results.yml
@@ -48,5 +48,5 @@ jobs:
commit: ${{ github.event.workflow_run.head_sha }}
event_file: artifacts/Event File/event.json
event_name: ${{ github.event.workflow_run.event }}
- check_name: Test Results (${{ github.event.workflow_run.event }})
+ check_name: Test Results
files: "artifacts/**/*.xml"