You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2006/10/18 04:28:57 UTC

svn commit: r465127 - in /tomcat: connectors/trunk/http11/src/java/org/apache/coyote/http11/filters/SavedRequestInputFilter.java container/tc5.5.x/webapps/docs/changelog.xml

Author: markt
Date: Tue Oct 17 19:28:56 2006
New Revision: 465127

URL: http://svn.apache.org/viewvc?view=rev&rev=465127
Log:
Fix bug 40771. Correct doRead method so Filters and Valves can read POST data. patch provided by Michael Dufel.

Modified:
    tomcat/connectors/trunk/http11/src/java/org/apache/coyote/http11/filters/SavedRequestInputFilter.java
    tomcat/container/tc5.5.x/webapps/docs/changelog.xml

Modified: tomcat/connectors/trunk/http11/src/java/org/apache/coyote/http11/filters/SavedRequestInputFilter.java
URL: http://svn.apache.org/viewvc/tomcat/connectors/trunk/http11/src/java/org/apache/coyote/http11/filters/SavedRequestInputFilter.java?view=diff&rev=465127&r1=465126&r2=465127
==============================================================================
--- tomcat/connectors/trunk/http11/src/java/org/apache/coyote/http11/filters/SavedRequestInputFilter.java (original)
+++ tomcat/connectors/trunk/http11/src/java/org/apache/coyote/http11/filters/SavedRequestInputFilter.java Tue Oct 17 19:28:56 2006
@@ -55,6 +55,9 @@
         	writeLength = input.getLength();
         }
         
+        if(input.getOffset()>= input.getEnd())
+            return -1;
+        
         input.substract(chunk.getBuffer(), 0, writeLength);
         chunk.setOffset(0);
         chunk.setEnd(writeLength);

Modified: tomcat/container/tc5.5.x/webapps/docs/changelog.xml
URL: http://svn.apache.org/viewvc/tomcat/container/tc5.5.x/webapps/docs/changelog.xml?view=diff&rev=465127&r1=465126&r2=465127
==============================================================================
--- tomcat/container/tc5.5.x/webapps/docs/changelog.xml (original)
+++ tomcat/container/tc5.5.x/webapps/docs/changelog.xml Tue Oct 17 19:28:56 2006
@@ -55,6 +55,15 @@
       </fix>
     </changelog>
   </subsection> 
+  <subsection name="Coyote">
+    <changelog>
+      <fix>
+        <bug>40771</bug>: Fix implementation of
+        SavedRequestInputFilter.doRead() so POST data may be read using a
+        Valve or Filter. Patch provided by Michael Dufel. (markt)
+      </fix>
+    </changelog>
+  </subsection> 
   <subsection name="Webapps">
     <changelog>
       <fix>
@@ -494,7 +503,7 @@
         HttpSession.getId will no longer throw an ISE when the session is invalid (remm)
       </fix>
       <fix>
-         ore detailed errors for naming issues (remm)
+         More detailed errors for naming issues (remm)
       </fix>
       <docs>
         Add documentation for the Transaction element (remm)



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org