You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "dukian (JIRA)" <ji...@apache.org> on 2010/11/22 16:57:13 UTC
[jira] Created: (OFBIZ-4031) Add Traditional Chinese translation
for applications, ecommerce, and ofbizsetup
Add Traditional Chinese translation for applications, ecommerce, and ofbizsetup
-------------------------------------------------------------------------------
Key: OFBIZ-4031
URL: https://issues.apache.org/jira/browse/OFBIZ-4031
Project: OFBiz
Issue Type: Improvement
Affects Versions: SVN trunk
Reporter: dukian
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-4031) Add Traditional Chinese translation for
applications, ecommerce, and ofbizsetup
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-4031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacques Le Roux closed OFBIZ-4031.
----------------------------------
Resolution: Fixed
Fix Version/s: SVN trunk
Assignee: Jacques Le Roux
Thanks Dukian,
Your patch is in trunk at r1039574
> Add Traditional Chinese translation for applications, ecommerce, and ofbizsetup
> -------------------------------------------------------------------------------
>
> Key: OFBIZ-4031
> URL: https://issues.apache.org/jira/browse/OFBIZ-4031
> Project: OFBiz
> Issue Type: Improvement
> Affects Versions: SVN trunk
> Reporter: dukian
> Assignee: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: OFBIZ-4031_zh_TW.patch.zip
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-4031) Add Traditional Chinese translation
for applications, ecommerce, and ofbizsetup
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-4031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12964563#action_12964563 ]
Jacques Le Roux commented on OFBIZ-4031:
----------------------------------------
Thanks Dukian,
According to your py program (sounds good to me), there was only one error remaining. It's fixed at r
If you want to check more I have not removed the culprit lines but commented them out with one these comments
<!-- error introduced with 1039574, OFBIZ-4031 -->
<!-- duplicate -->
> Add Traditional Chinese translation for applications, ecommerce, and ofbizsetup
> -------------------------------------------------------------------------------
>
> Key: OFBIZ-4031
> URL: https://issues.apache.org/jira/browse/OFBIZ-4031
> Project: OFBiz
> Issue Type: Improvement
> Affects Versions: SVN trunk
> Reporter: dukian
> Assignee: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: chk_files.txt, chk_r1039859.txt, OFBIZ-4031_zh_TW.patch.zip, trans_chk.py
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (OFBIZ-4031) Add Traditional Chinese
translation for applications, ecommerce, and ofbizsetup
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-4031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12964563#action_12964563 ]
Jacques Le Roux edited comment on OFBIZ-4031 at 11/28/10 11:36 AM:
-------------------------------------------------------------------
*******EDIT****** forgot the revision number
Thanks Dukian,
According to your py program (sounds good to me), there was only one error remaining. It's fixed at r1039892
If you want to check more I have not removed the culprit lines but commented them out with one these comments
<!-- error introduced with 1039574, OFBIZ-4031 -->
<!-- duplicate -->
was (Author: jacques.le.roux):
Thanks Dukian,
According to your py program (sounds good to me), there was only one error remaining. It's fixed at r
If you want to check more I have not removed the culprit lines but commented them out with one these comments
<!-- error introduced with 1039574, OFBIZ-4031 -->
<!-- duplicate -->
> Add Traditional Chinese translation for applications, ecommerce, and ofbizsetup
> -------------------------------------------------------------------------------
>
> Key: OFBIZ-4031
> URL: https://issues.apache.org/jira/browse/OFBIZ-4031
> Project: OFBiz
> Issue Type: Improvement
> Affects Versions: SVN trunk
> Reporter: dukian
> Assignee: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: chk_files.txt, chk_r1039859.txt, OFBIZ-4031_zh_TW.patch.zip, trans_chk.py
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-4031) Add Traditional Chinese translation
for applications, ecommerce, and ofbizsetup
Posted by "dukian (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-4031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
dukian updated OFBIZ-4031:
--------------------------
Attachment: OFBIZ-4031-FAULTS.png
Hi Jacques,
Because I misused merge tool under Mercurial MQ for several months(maintains zh_TW patch), those were removed properties but still add <value> tags to related position.
The case likes attachment OFBIZ-4031-FAULTS.png: the left side is my patch, the center is base revision, the right side is new revision.
I consider these <value> tags should be erased. Thanks for you support.
> Add Traditional Chinese translation for applications, ecommerce, and ofbizsetup
> -------------------------------------------------------------------------------
>
> Key: OFBIZ-4031
> URL: https://issues.apache.org/jira/browse/OFBIZ-4031
> Project: OFBiz
> Issue Type: Improvement
> Affects Versions: SVN trunk
> Reporter: dukian
> Assignee: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: chk_files.txt, chk_r1039859.txt, OFBIZ-4031-FAULTS.png, OFBIZ-4031_zh_TW.patch.zip, trans_chk.py
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-4031) Add Traditional Chinese translation
for applications, ecommerce, and ofbizsetup
Posted by "dukian (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-4031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
dukian updated OFBIZ-4031:
--------------------------
Attachment: OFBIZ-4031_zh_TW.patch.zip
$ svn info
Path: .
URL: https://svn.apache.org/repos/asf/ofbiz/trunk
Repository Root: https://svn.apache.org/repos/asf
Repository UUID: 13f79535-47bb-0310-9956-ffa450edef68
Revision: 1037754
Node Kind: directory
Schedule: normal
Last Changed Author: hansbak
Last Changed Rev: 1037624
Last Changed Date: 2010-11-22 15:55:56 +0800 (Mon, 22 Nov 2010)
$ svn st
M applications/party/config/PartyUiLabels.xml
M applications/party/config/PartyErrorUiLabels.xml
M applications/party/config/PartyEntityLabels.xml
M applications/product/config/ProductEntityLabels.xml
M applications/product/config/ProductUiLabels.xml
A applications/product/config/promotext_zh_TW.properties
M applications/product/config/ProductErrorUiLabels.xml
M applications/marketing/config/MarketingEntityLabels.xml
M applications/marketing/config/MarketingUiLabels.xml
M applications/humanres/config/HumanResUiLabels.xml
M applications/manufacturing/config/ManufacturingEntityLabels.xml
M applications/manufacturing/config/ManufacturingReportsUiLabels.xml
M applications/manufacturing/config/ManufacturingUiLabels.xml
M applications/workeffort/config/WorkEffortEntityLabels.xml
M applications/workeffort/config/WorkEffortUiLabels.xml
M applications/commonext/config/SetupUiLabels.xml
M applications/accounting/config/AccountingErrorUiLabels.xml
M applications/accounting/config/AccountingEntityLabels.xml
M applications/accounting/config/AccountingUiLabels.xml
M applications/content/config/ContentErrorUiLabels.xml
M applications/content/config/ContentEntityLabels.xml
M applications/content/config/ContentUiLabels.xml
M applications/order/config/OrderErrorUiLabels.xml
M applications/order/config/OrderEntityLabels.xml
M applications/order/config/OrderUiLabels.xml
M framework/widget/config/conditional.xml
M framework/common/config/CommonHelpUiLabels.xml
M framework/common/config/CommonErrorUiLabels.xml
M framework/common/config/TemporalExpressionUiLabels.xml
M framework/common/config/CommonEntityLabels.xml
M framework/common/config/CommonUiLabels.xml
M framework/common/config/SecurityextUiLabels.xml
M framework/common/config/CommonPortalEntityLabels.xml
M framework/minilang/config/MiniLangErrorUiLabels.xml
M framework/minilang/config/DefaultMessages.xml
M framework/webtools/config/WebtoolsErrorUiLabels.xml
M framework/webtools/config/WebtoolsUiLabels.xml
M framework/service/config/ServiceErrorUiLabels.xml
M framework/images/webapp/images/calendarDateSelect/locale/zh.js
M framework/security/config/SecurityEntityLabels.xml
M framework/base/config/DateTimeLabels.xml
M framework/webapp/config/WebappEntityLabels.xml
M framework/webapp/config/WebappUiLabels.xml
M specialpurpose/ecommerce/config/EcommerceUiLabels.xml
M specialpurpose/myportal/config/MyPortalUiLabels.xml
> Add Traditional Chinese translation for applications, ecommerce, and ofbizsetup
> -------------------------------------------------------------------------------
>
> Key: OFBIZ-4031
> URL: https://issues.apache.org/jira/browse/OFBIZ-4031
> Project: OFBiz
> Issue Type: Improvement
> Affects Versions: SVN trunk
> Reporter: dukian
> Attachments: OFBIZ-4031_zh_TW.patch.zip
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-4031) Add Traditional Chinese translation
for applications, ecommerce, and ofbizsetup
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-4031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12964709#action_12964709 ]
Jacques Le Roux commented on OFBIZ-4031:
----------------------------------------
Thanks Dukian,
At r1040078, I have removed those lines. I just kept 2 duplicates in Chinese (and one in German), check if you like...
> Add Traditional Chinese translation for applications, ecommerce, and ofbizsetup
> -------------------------------------------------------------------------------
>
> Key: OFBIZ-4031
> URL: https://issues.apache.org/jira/browse/OFBIZ-4031
> Project: OFBiz
> Issue Type: Improvement
> Affects Versions: SVN trunk
> Reporter: dukian
> Assignee: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: chk_files.txt, chk_r1039859.txt, OFBIZ-4031-FAULTS.png, OFBIZ-4031_zh_TW.patch.zip, trans_chk.py
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-4031) Add Traditional Chinese translation
for applications, ecommerce, and ofbizsetup
Posted by "dukian (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-4031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
dukian updated OFBIZ-4031:
--------------------------
Attachment: chk_r1039859.txt
chk_files.txt
trans_chk.py
sorry for my mistake.
I just arrange a program to check this problem(trans_chk.py). It will take care each property set, and checks tag <value> is inside or outside.
And prepare all change file names in r1039574 to a text file: chk_files.txt, and execute following command under OFBiz directory:
{quote}
$ cat ../chk_files.txt | xargs python ~/trans_chk.py > chk_r1039574.txt
{quote}
I run above command under r1039574 and r1039859, and results as attachment.
It seems some probelms in specialpurpose/ecommerce/config/EcommerceUiLabels.xml.
please check it, thanks :-)
> Add Traditional Chinese translation for applications, ecommerce, and ofbizsetup
> -------------------------------------------------------------------------------
>
> Key: OFBIZ-4031
> URL: https://issues.apache.org/jira/browse/OFBIZ-4031
> Project: OFBiz
> Issue Type: Improvement
> Affects Versions: SVN trunk
> Reporter: dukian
> Assignee: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: chk_files.txt, chk_r1039859.txt, OFBIZ-4031_zh_TW.patch.zip, trans_chk.py
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-4031) Add Traditional Chinese translation
for applications, ecommerce, and ofbizsetup
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-4031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12964525#action_12964525 ]
Jacques Le Roux commented on OFBIZ-4031:
----------------------------------------
Hi Dukian,
At [r1039651|http://svn.apache.org/viewvc?rev=1039859&view=rev] I have fixed some errors in your patch. There are annoying because AFAIK we have noways to spot them automatically:
* The are not reported as errors by XSD when you load the file in an XML editor
* The Label manager does not report them
* The patch is 93074 lines and 5MB
* It's hard to scan this kind of errors in a patch even a small one
Could you please have a look to ensure that there are no other <value> tags outside of the <property> tags introduced with your changes, thanks!
There were also some duplicates, look for them at [r1039858|http://svn.apache.org/viewvc?rev=1039858&view=rev].
> Add Traditional Chinese translation for applications, ecommerce, and ofbizsetup
> -------------------------------------------------------------------------------
>
> Key: OFBIZ-4031
> URL: https://issues.apache.org/jira/browse/OFBIZ-4031
> Project: OFBiz
> Issue Type: Improvement
> Affects Versions: SVN trunk
> Reporter: dukian
> Assignee: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: OFBIZ-4031_zh_TW.patch.zip
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.