[jira] Closed: (OFBIZ-2978) gatewayMessage should be pgrMessage in savePaymentGatewayResponse of PaymentGatewayServices

["Scott Gray (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/OFBIZ-2978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Scott Gray closed OFBIZ-2978.
-----------------------------

       Resolution: Fixed
    Fix Version/s: SVN trunk

Thanks Abdullah, this is fixed in r821705

After looking at the revision history for the methods I decided that the original intention was to support both types of values but at some point someone committed an accidental 'fix' which reduced the support down to PaymentGatewayResponse values only.
So I decided in the end that the best way to fix this was to restore the original intention and simply improve the fix which broke that functionality.

> gatewayMessage should be pgrMessage in savePaymentGatewayResponse of PaymentGatewayServices
> -------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-2978
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2978
>             Project: OFBiz
>          Issue Type: Bug
>          Components: accounting
>            Reporter: Abdullah Shaikh
>            Assignee: Scott Gray
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-2978_gatewayMessage should be pgrMessage.patch, OFBIZ-2978_gatewayMessage should be pgrMessage.patch, OFBIZ-2978_gatewayMessage should be pgrMessage.patch
>
>
> In savePaymentGatewayResponse method of PaymentGatewayServices class, we are setting the "gatewayMessage" field on the GenericValue of PaymentGatewayRespMsg, but there is no field named "gatewayMessage" in entity PaymentGatewayRespMsg but instead we need to use "pgrMessage" in place of "gatewayMessage".
> I guess we mistakely assumed the GenericValue which we get from the context, context.get("paymentGatewayResponse");, to be of PaymentGatewayResponse, but its the GenericValue of PaymentGatewayRespMsg but while putting it on the context we named it as "paymentGatewayResponse".

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.