[GitHub] [geode] jinmeiliao commented on a change in pull request #5507: GEODE-8489: "Select *" query by DistributedSystemMBean should not hon…

[GitBox <gi...@apache.org>]

jinmeiliao commented on a change in pull request #5507:
URL: https://github.com/apache/geode/pull/5507#discussion_r488773618



##########
File path: geode-core/src/integrationTest/java/org/apache/geode/management/internal/beans/DistributedSystemMBeanIntegrationTest.java
##########
@@ -30,14 +31,16 @@
 import org.apache.geode.cache.RegionShortcut;
 import org.apache.geode.management.DistributedSystemMXBean;
 import org.apache.geode.management.internal.json.QueryResultFormatter;
+import org.apache.geode.management.model.Employee;
 import org.apache.geode.test.junit.assertions.TabularResultModelAssert;
 import org.apache.geode.test.junit.rules.GfshCommandRule;
 import org.apache.geode.test.junit.rules.MBeanServerConnectionRule;
 import org.apache.geode.test.junit.rules.ServerStarterRule;
 
 public class DistributedSystemMBeanIntegrationTest {
 
-  public static final String SELECT = "select * from /testRegion r where r.id=1";
+  public static final String SELECT_ALL = "select * from /testRegion r where r.id=1";

Review comment:
       the test is to verify the results are formatted correctly. If returning 0 results, no formats needed, that's not the purpose of the tests. I am sure there are other tests that tests 0 results.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org