[GitHub] [pinot] PrachiKhobragade commented on a diff in pull request #11101: Allow setting the default MergeRollupTask segment group manager

["PrachiKhobragade (via GitHub)" <gi...@apache.org>]

PrachiKhobragade commented on code in PR #11101:
URL: https://github.com/apache/pinot/pull/11101#discussion_r1262917809


##########
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/mergerollup/segmentgroupmananger/MergeRollupTaskSegmentGroupManagerProvider.java:
##########
@@ -27,20 +27,25 @@
  * Provider class for {@link MergeRollupTaskSegmentGroupManager}
  */
 public abstract class MergeRollupTaskSegmentGroupManagerProvider {
+
+  private static String _defaultMergeRollupTaskSegmentGroupManagerClassName =
+      "org.apache.pinot.plugin.minion.tasks.mergerollup.segmentgroupmananger.DefaultMergeRollupTaskSegmentGroupManager";

Review Comment:
   Better way would be class.getName(), so that any refactoring efforst won't miss this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org