You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/03/27 13:37:49 UTC
[GitHub] [pulsar] gaozhangmin opened a new pull request #14900: [fix][transaction] Properly close non durable cursor
gaozhangmin opened a new pull request #14900:
URL: https://github.com/apache/pulsar/pull/14900
Fixes #14880
### Motivation
Non durable cursor was not closed properly.
### Modifications
For non durable cursor, `cursor.asyncClose` did nothing. The proper way is `topic.getManagedLedger().asyncDeleteCursor`
### Documentation
Check the box below or label this PR directly (if you have committer privilege).
Need to update docs?
- [ ] `doc-required`
(If you need help on updating docs, create a doc issue)
- [ ] `no-need-doc`
(Please explain why)
- [ ] `doc`
(If this PR contains doc changes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin commented on pull request #14900: [fix][transaction] Properly close transaction-buffer-sub non durable cursor
Posted by GitBox <gi...@apache.org>.
gaozhangmin commented on pull request #14900:
URL: https://github.com/apache/pulsar/pull/14900#issuecomment-1080790300
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #14900: [fix][transaction] Properly close non durable cursor
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14900:
URL: https://github.com/apache/pulsar/pull/14900#issuecomment-1079933907
@gaozhangmin:Thanks for providing doc info!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #14900: [fix][transaction] Properly close transaction-buffer-sub non durable cursor
Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #14900:
URL: https://github.com/apache/pulsar/pull/14900
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin commented on pull request #14900: [fix][transaction] Properly close transaction-buffer-sub non durable cursor
Posted by GitBox <gi...@apache.org>.
gaozhangmin commented on pull request #14900:
URL: https://github.com/apache/pulsar/pull/14900#issuecomment-1079938623
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin commented on pull request #14900: [fix][transaction] Properly close transaction-buffer-sub non durable cursor
Posted by GitBox <gi...@apache.org>.
gaozhangmin commented on pull request #14900:
URL: https://github.com/apache/pulsar/pull/14900#issuecomment-1080542113
> LGTM, could you add a test.
@gaoran10 Test added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #14900: [fix][transaction] Properly close non durable cursor
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14900:
URL: https://github.com/apache/pulsar/pull/14900#issuecomment-1079933872
@gaozhangmin:Thanks for your contribution. For this PR, do we need to update docs?
(The [PR template contains info about doc](https://github.com/apache/pulsar/blob/master/.github/PULL_REQUEST_TEMPLATE.md#documentation), which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin commented on pull request #14900: [fix][transaction] Properly close transaction-buffer-sub non durable cursor
Posted by GitBox <gi...@apache.org>.
gaozhangmin commented on pull request #14900:
URL: https://github.com/apache/pulsar/pull/14900#issuecomment-1079945537
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin commented on pull request #14900: [fix][transaction] Properly close transaction-buffer-sub non durable cursor
Posted by GitBox <gi...@apache.org>.
gaozhangmin commented on pull request #14900:
URL: https://github.com/apache/pulsar/pull/14900#issuecomment-1080222684
I am checking the failed test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin commented on pull request #14900: [fix][transaction] Properly close transaction-buffer-sub non durable cursor
Posted by GitBox <gi...@apache.org>.
gaozhangmin commented on pull request #14900:
URL: https://github.com/apache/pulsar/pull/14900#issuecomment-1080463739
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gaozhangmin removed a comment on pull request #14900: [fix][transaction] Properly close transaction-buffer-sub non durable cursor
Posted by GitBox <gi...@apache.org>.
gaozhangmin removed a comment on pull request #14900:
URL: https://github.com/apache/pulsar/pull/14900#issuecomment-1079938623
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org