[GitHub] [iceberg] dramaticlly commented on a diff in pull request #4811: Python: Replace tox by pre-commit

[GitBox <gi...@apache.org>]

dramaticlly commented on code in PR #4811:
URL: https://github.com/apache/iceberg/pull/4811#discussion_r876429194


##########
python/pyproject.toml:
##########
@@ -20,4 +20,27 @@ requires = [
     "setuptools>=42",
     "wheel"
 ]
-build-backend = "setuptools.build_meta"
\ No newline at end of file
+build-backend = "setuptools.build_meta"
+
+[tool.black]
+line-length = 130
+target-version = ['py38']

Review Comment:
   curious to know why is this py38 instead of py37 (minimal version we support)?



##########
python/src/iceberg/expressions/literals.py:
##########
@@ -44,13 +44,7 @@
     TimeType,
     UUIDType,
 )
-from iceberg.utils.datetime import (

Review Comment:
   I feel like the format before looks more clear to me, what do you think?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org