You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/08/23 11:54:02 UTC
[GitHub] [arrow] milesgranger opened a new pull request, #13950: ARROW-15277: [Python] Use ChunkedArray::Make for chunked_array
milesgranger opened a new pull request, #13950:
URL: https://github.com/apache/arrow/pull/13950
Supersedes and will close #12096
[ARROW-15277](https://issues.apache.org/jira/browse/ARROW-15277)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #13950: ARROW-15277: [C++][Python] Use ChunkedArray::Make for chunked_array
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #13950:
URL: https://github.com/apache/arrow/pull/13950#issuecomment-1227118014
Benchmark runs are scheduled for baseline = 897c186f475f3dd82c1ab47e5cfb87cb0fed8440 and contender = dd0988b49cb6726cf915bb9f53d7320e3a97b00b. dd0988b49cb6726cf915bb9f53d7320e3a97b00b is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/532d3ca1f67344a690fe6542a2fca85d...553f5b5b71344739acfab3beeac1aee5/)
[Failed :arrow_down:0.58% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/9758e047a881472c88d9c019677215f0...407b8e154dcf41cebf3adbfe8bc7f46c/)
[Failed :arrow_down:0.0% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/2f68681b56364287ad9426444ddee580...56f5ee4356fb41b1a7f09b86e84f03d7/)
[Finished :arrow_down:0.39% :arrow_up:0.07%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/bd11f9d94f0a48a4b4dc0b14f6d2e96a...6b908bfed2f74c7bbd7235cfaaf5c4ec/)
Buildkite builds:
[Finished] [`dd0988b4` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1369)
[Failed] [`dd0988b4` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1385)
[Failed] [`dd0988b4` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1367)
[Finished] [`dd0988b4` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1384)
[Finished] [`897c186f` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1368)
[Failed] [`897c186f` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1384)
[Failed] [`897c186f` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1366)
[Finished] [`897c186f` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1383)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #13950: ARROW-15277: [C++][Python] Use ChunkedArray::Make for chunked_array
Posted by GitBox <gi...@apache.org>.
pitrou commented on PR #13950:
URL: https://github.com/apache/arrow/pull/13950#issuecomment-1226973904
Python CI was successful here: https://github.com/milesgranger/arrow/actions/runs/2924730791
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on a diff in pull request #13950: ARROW-15277: [Python] Use ChunkedArray::Make for chunked_array
Posted by GitBox <gi...@apache.org>.
pitrou commented on code in PR #13950:
URL: https://github.com/apache/arrow/pull/13950#discussion_r953890585
##########
python/pyarrow/tests/test_table.py:
##########
@@ -143,14 +140,15 @@ def test_chunked_array_to_numpy():
def test_chunked_array_mismatch_types():
- with pytest.raises(TypeError):
+ msg = "chunks must all be same type"
+ with pytest.raises(pa.ArrowInvalid, match=msg):
Review Comment:
Hmm... interesting. I would be in favor of changing the C++ side to return `TypeError` instead. Would you like to do that in this PR?
##########
python/pyarrow/tests/test_table.py:
##########
@@ -143,14 +140,15 @@ def test_chunked_array_to_numpy():
def test_chunked_array_mismatch_types():
- with pytest.raises(TypeError):
+ msg = "chunks must all be same type"
+ with pytest.raises(pa.ArrowInvalid, match=msg):
# Given array types are different
pa.chunked_array([
pa.array([1, 2, 3]),
pa.array([1., 2., 3.])
])
- with pytest.raises(TypeError):
+ with pytest.raises(pa.ArrowInvalid, match=msg):
Review Comment:
(same)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] milesgranger commented on pull request #13950: ARROW-15277: [Python] Use ChunkedArray::Make for chunked_array
Posted by GitBox <gi...@apache.org>.
milesgranger commented on PR #13950:
URL: https://github.com/apache/arrow/pull/13950#issuecomment-1225673477
@pitrou I believe this is ready for a review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou merged pull request #13950: ARROW-15277: [C++][Python] Use ChunkedArray::Make for chunked_array
Posted by GitBox <gi...@apache.org>.
pitrou merged PR #13950:
URL: https://github.com/apache/arrow/pull/13950
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #13950: ARROW-15277: [Python] Use ChunkedArray::Make for chunked_array
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13950:
URL: https://github.com/apache/arrow/pull/13950#issuecomment-1223961646
https://issues.apache.org/jira/browse/ARROW-15277
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #13950: ARROW-15277: [C++][Python] Use ChunkedArray::Make for chunked_array
Posted by GitBox <gi...@apache.org>.
pitrou commented on PR #13950:
URL: https://github.com/apache/arrow/pull/13950#issuecomment-1226881167
Rebased and a nit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] milesgranger commented on pull request #13950: ARROW-15277: [C++][Python] Use ChunkedArray::Make for chunked_array
Posted by GitBox <gi...@apache.org>.
milesgranger commented on PR #13950:
URL: https://github.com/apache/arrow/pull/13950#issuecomment-1226738685
I don't think the [R / AMD64 Windows R 3.6 RTools 35 failure](https://github.com/apache/arrow/runs/8003655286?check_suite_focus=true) is related...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #13950: ARROW-15277: [Python] Use ChunkedArray::Make for chunked_array
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13950:
URL: https://github.com/apache/arrow/pull/13950#issuecomment-1223961672
:warning: Ticket **has not been started in JIRA**, please click 'Start Progress'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #13950: ARROW-15277: [C++][Python] Use ChunkedArray::Make for chunked_array
Posted by GitBox <gi...@apache.org>.
pitrou commented on PR #13950:
URL: https://github.com/apache/arrow/pull/13950#issuecomment-1226876609
Indeed, it isn't.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org