[GitHub] [skywalking] aderm commented on a change in pull request #3621: Fix plugin test run.sh script parameter error

[GitBox <gi...@apache.org>]

aderm commented on a change in pull request #3621: Fix plugin test run.sh script parameter error
URL: https://github.com/apache/skywalking/pull/3621#discussion_r335022510
 
 

 ##########
 File path: test/plugin/run.sh
 ##########
 @@ -113,8 +114,17 @@ do_cleanup() {
     [[ -d ${home}/workspace ]] && rm -rf ${home}/workspace
 }
 
+check_scenario_name_param() {
+    if test -z "$scenario_name"; then
+        echo "Missing value for the scenario argument"
+        exit 0
+    fi
+}
+
 start_stamp=`date +%s`
 parse_commandline "$@"
+check_scenario_name_param()
 
 Review comment:
   yes, I has run it. 
   Ok, it look better.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services