You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/08/03 17:31:04 UTC

[GitHub] haojin2 commented on a change in pull request #12020: Fix flaky tests for test_hinge_loss

haojin2 commented on a change in pull request #12020: Fix flaky tests for test_hinge_loss
URL: https://github.com/apache/incubator-mxnet/pull/12020#discussion_r207615081
 
 

 ##########
 File path: tests/python/unittest/test_loss.py
 ##########
 @@ -292,7 +292,9 @@ def test_huber_loss():
     assert mod.score(data_iter, eval_metric=mx.metric.Loss())[0][1] < 0.05
 
 
-@with_seed(1234)
+# @zachgk: Getting ride of fixed seed as flakiness should not occur with increased tolerance,
+# tracked at https://github.com/apache/incubator-mxnet/issues/11695
 
 Review comment:
   We just decided that this is not needed, please simply link the issue in the description section of your PR

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services