You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "dhruba borthakur (Created) (JIRA)" <ji...@apache.org> on 2012/01/28 00:04:10 UTC
[jira] [Created] (HBASE-5295) Improve the Thrift API to switch
on/off writing to wal for Mutations
Improve the Thrift API to switch on/off writing to wal for Mutations
---------------------------------------------------------------------
Key: HBASE-5295
URL: https://issues.apache.org/jira/browse/HBASE-5295
Project: HBase
Issue Type: Improvement
Components: thrift
Reporter: dhruba borthakur
Assignee: dhruba borthakur
The thrift api currently does not support switching off updating wal for Puts/Deletes. Support it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5295) Improve the Thrift API to switch
on/off writing to wal for Mutations
Posted by "Phabricator (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HBASE-5295:
-------------------------------
Attachment: D3015.1.patch
mbautin requested code review of "[jira] [HBASE-5295] [89-fb] Improve the Thrift API to switch on/off writing to wal for Mutations".
Reviewers: Kannan, dhruba, sc, JIRA
Porting Dhruba's patch from HBASE-5295 to 89-fb add a writeToWAL flag to the Mutation Thrift API. Also adding a new unit test and fixing an inconsistency in the mutateRow API in case different Mutation objects have different values of writeToWAL specified.
TEST PLAN
Exiting unit tests
New unit test
REVISION DETAIL
https://reviews.facebook.net/D3015
AFFECTED FILES
src/main/java/org/apache/hadoop/hbase/KeyValue.java
src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java
src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java
src/main/java/org/apache/hadoop/hbase/thrift/ThriftUtilities.java
src/main/java/org/apache/hadoop/hbase/thrift/generated/Mutation.java
src/main/java/org/apache/hadoop/hbase/util/Bytes.java
src/main/resources/org/apache/hadoop/hbase/thrift/Hbase.thrift
src/test/java/org/apache/hadoop/hbase/HTestConst.java
src/test/java/org/apache/hadoop/hbase/thrift/TestMutationWriteToWAL.java
src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java
src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServerLegacy.java
MANAGE HERALD DIFFERENTIAL RULES
https://reviews.facebook.net/herald/view/differential/
WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/6861/
Tip: use the X-Herald-Rules header to filter Herald messages in your client.
> Improve the Thrift API to switch on/off writing to wal for Mutations
> ---------------------------------------------------------------------
>
> Key: HBASE-5295
> URL: https://issues.apache.org/jira/browse/HBASE-5295
> Project: HBase
> Issue Type: Improvement
> Components: thrift
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Attachments: D1515.1.patch, D1515.1.patch, D1515.1.patch, D1515.1.patch, D1515.2.patch, D1515.2.patch, D1515.2.patch, D1515.2.patch, D3015.1.patch
>
>
> The thrift api currently does not support switching off updating wal for Puts/Deletes. Support it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5295) Improve the Thrift API to switch
on/off writing to wal for Mutations
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195765#comment-13195765 ]
Phabricator commented on HBASE-5295:
------------------------------------
tedyu has commented on the revision "[jira] [HBASE-5295] Improve the Thrift API to switch on/off writing to wal for Mutations".
thrift2/TDelete doesn't support WAL switch.
Delete is a mutation:
public class Delete extends Mutation
thrift2/ThriftUtilities.java has out.setWriteToWAL() call for incrementFromThrift() and incrementFromThrift(). deleteFromThrift() should also have this call.
w.r.t. why two thrift packages are maintained, you can find some discussions in this JIRA:
https://issues.apache.org/jira/browse/HBASE-1744?focusedCommentId=12921845&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-12921845
There're so many Thrift experts at FB, I am sure they have better idea about the two packages.
REVISION DETAIL
https://reviews.facebook.net/D1515
> Improve the Thrift API to switch on/off writing to wal for Mutations
> ---------------------------------------------------------------------
>
> Key: HBASE-5295
> URL: https://issues.apache.org/jira/browse/HBASE-5295
> Project: HBase
> Issue Type: Improvement
> Components: thrift
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Attachments: D1515.1.patch, D1515.1.patch, D1515.1.patch, D1515.1.patch
>
>
> The thrift api currently does not support switching off updating wal for Puts/Deletes. Support it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5295) Improve the Thrift API to switch
on/off writing to wal for Mutations
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HBASE-5295:
-------------------------------
Attachment: D1515.1.patch
dhruba requested code review of "[jira] [HBASE-5295] Improve the Thrift API to switch on/off writing to wal for Mutations".
Reviewers: sc, tedyu, stack
Enhance the thrift api to have the ability to switch of wal when doing a put or delete. The only change is adding a new field to the thrift Mutation object.
TEST PLAN
TestThriftServer
REVISION DETAIL
https://reviews.facebook.net/D1515
AFFECTED FILES
src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java
src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java
src/main/java/org/apache/hadoop/hbase/thrift/generated/Mutation.java
src/main/java/org/apache/hadoop/hbase/thrift/generated/BatchMutation.java
src/main/java/org/apache/hadoop/hbase/thrift/generated/Hbase.java
src/main/java/org/apache/hadoop/hbase/thrift/generated/TScan.java
src/main/java/org/apache/hadoop/hbase/thrift/generated/TRowResult.java
src/main/resources/org/apache/hadoop/hbase/thrift/Hbase.thrift
MANAGE HERALD DIFFERENTIAL RULES
https://reviews.facebook.net/herald/view/differential/
WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/3165/
Tip: use the X-Herald-Rules header to filter Herald messages in your client.
> Improve the Thrift API to switch on/off writing to wal for Mutations
> ---------------------------------------------------------------------
>
> Key: HBASE-5295
> URL: https://issues.apache.org/jira/browse/HBASE-5295
> Project: HBase
> Issue Type: Improvement
> Components: thrift
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Attachments: D1515.1.patch, D1515.1.patch, D1515.1.patch, D1515.1.patch
>
>
> The thrift api currently does not support switching off updating wal for Puts/Deletes. Support it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5295) Improve the Thrift API to switch
on/off writing to wal for Mutations
Posted by "Phabricator (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13272576#comment-13272576 ]
Phabricator commented on HBASE-5295:
------------------------------------
dhruba has closed the revision "[jira] [HBASE-5295] Improve the Thrift API to switch on/off writing to wal for Mutations".
REVISION DETAIL
https://reviews.facebook.net/D1515
To: sc, tedyu, stack, dhruba
Cc: JIRA, tedyu, dhruba
> Improve the Thrift API to switch on/off writing to wal for Mutations
> ---------------------------------------------------------------------
>
> Key: HBASE-5295
> URL: https://issues.apache.org/jira/browse/HBASE-5295
> Project: HBase
> Issue Type: Improvement
> Components: thrift
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Attachments: D1515.1.patch, D1515.1.patch, D1515.1.patch, D1515.1.patch, D1515.2.patch, D1515.2.patch, D1515.2.patch, D1515.2.patch, D3015.1.patch, D3015.2.patch, D3015.3.patch, D3015.4.patch
>
>
> The thrift api currently does not support switching off updating wal for Puts/Deletes. Support it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5295) Improve the Thrift API to switch
on/off writing to wal for Mutations
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195764#comment-13195764 ]
Phabricator commented on HBASE-5295:
------------------------------------
tedyu has commented on the revision "[jira] [HBASE-5295] Improve the Thrift API to switch on/off writing to wal for Mutations".
thrift2/TDelete doesn't support WAL switch.
Delete is a mutation:
public class Delete extends Mutation
thrift2/ThriftUtilities.java has out.setWriteToWAL() call for incrementFromThrift() and incrementFromThrift(). deleteFromThrift() should also have this call.
w.r.t. why two thrift packages are maintained, you can find some discussions in this JIRA:
https://issues.apache.org/jira/browse/HBASE-1744?focusedCommentId=12921845&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-12921845
There're so many Thrift experts at FB, I am sure they have better idea about the two packages.
REVISION DETAIL
https://reviews.facebook.net/D1515
> Improve the Thrift API to switch on/off writing to wal for Mutations
> ---------------------------------------------------------------------
>
> Key: HBASE-5295
> URL: https://issues.apache.org/jira/browse/HBASE-5295
> Project: HBase
> Issue Type: Improvement
> Components: thrift
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Attachments: D1515.1.patch, D1515.1.patch, D1515.1.patch, D1515.1.patch
>
>
> The thrift api currently does not support switching off updating wal for Puts/Deletes. Support it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5295) Improve the Thrift API to switch
on/off writing to wal for Mutations
Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13198009#comment-13198009 ]
Zhihong Yu commented on HBASE-5295:
-----------------------------------
I was in the process of integrating the patch :-)
Integrated to TRUNK.
Thanks for the patch, Dhruba.
> Improve the Thrift API to switch on/off writing to wal for Mutations
> ---------------------------------------------------------------------
>
> Key: HBASE-5295
> URL: https://issues.apache.org/jira/browse/HBASE-5295
> Project: HBase
> Issue Type: Improvement
> Components: thrift
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Attachments: D1515.1.patch, D1515.1.patch, D1515.1.patch, D1515.1.patch, D1515.2.patch, D1515.2.patch, D1515.2.patch, D1515.2.patch
>
>
> The thrift api currently does not support switching off updating wal for Puts/Deletes. Support it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5295) Improve the Thrift API to switch
on/off writing to wal for Mutations
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195680#comment-13195680 ]
Phabricator commented on HBASE-5295:
------------------------------------
tedyu has commented on the revision "[jira] [HBASE-5295] Improve the Thrift API to switch on/off writing to wal for Mutations".
INLINE COMMENTS
src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java:859 What about thrift2 ?
e.g. src/main/java/org/apache/hadoop/hbase/thrift2/ThriftUtilities.java has counterparts for this method.
REVISION DETAIL
https://reviews.facebook.net/D1515
> Improve the Thrift API to switch on/off writing to wal for Mutations
> ---------------------------------------------------------------------
>
> Key: HBASE-5295
> URL: https://issues.apache.org/jira/browse/HBASE-5295
> Project: HBase
> Issue Type: Improvement
> Components: thrift
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Attachments: D1515.1.patch, D1515.1.patch, D1515.1.patch, D1515.1.patch
>
>
> The thrift api currently does not support switching off updating wal for Puts/Deletes. Support it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5295) Improve the Thrift API to switch
on/off writing to wal for Mutations
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195766#comment-13195766 ]
Phabricator commented on HBASE-5295:
------------------------------------
tedyu has commented on the revision "[jira] [HBASE-5295] Improve the Thrift API to switch on/off writing to wal for Mutations".
thrift2/TDelete doesn't support WAL switch.
Delete is a mutation:
public class Delete extends Mutation
thrift2/ThriftUtilities.java has out.setWriteToWAL() call for incrementFromThrift() and incrementFromThrift(). deleteFromThrift() should also have this call.
w.r.t. why two thrift packages are maintained, you can find some discussions in this JIRA:
https://issues.apache.org/jira/browse/HBASE-1744?focusedCommentId=12921845&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-12921845
There're so many Thrift experts at FB, I am sure they have better idea about the two packages.
REVISION DETAIL
https://reviews.facebook.net/D1515
> Improve the Thrift API to switch on/off writing to wal for Mutations
> ---------------------------------------------------------------------
>
> Key: HBASE-5295
> URL: https://issues.apache.org/jira/browse/HBASE-5295
> Project: HBase
> Issue Type: Improvement
> Components: thrift
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Attachments: D1515.1.patch, D1515.1.patch, D1515.1.patch, D1515.1.patch
>
>
> The thrift api currently does not support switching off updating wal for Puts/Deletes. Support it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5295) Improve the Thrift API to switch
on/off writing to wal for Mutations
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195698#comment-13195698 ]
Phabricator commented on HBASE-5295:
------------------------------------
dhruba has commented on the revision "[jira] [HBASE-5295] Improve the Thrift API to switch on/off writing to wal for Mutations".
INLINE COMMENTS
src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java:859 thrift2/TPut already has the feature to switch off wal if needed, no further work is necessary.
also, just curious: the two thrift apis are not same. there are some features exposed via thrift that are not exposed via thrift2 and vice-versa. can you pl educate me on the history on why we have two different thrift apis?
REVISION DETAIL
https://reviews.facebook.net/D1515
> Improve the Thrift API to switch on/off writing to wal for Mutations
> ---------------------------------------------------------------------
>
> Key: HBASE-5295
> URL: https://issues.apache.org/jira/browse/HBASE-5295
> Project: HBase
> Issue Type: Improvement
> Components: thrift
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Attachments: D1515.1.patch, D1515.1.patch, D1515.1.patch, D1515.1.patch
>
>
> The thrift api currently does not support switching off updating wal for Puts/Deletes. Support it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5295) Improve the Thrift API to switch
on/off writing to wal for Mutations
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195681#comment-13195681 ]
Phabricator commented on HBASE-5295:
------------------------------------
tedyu has commented on the revision "[jira] [HBASE-5295] Improve the Thrift API to switch on/off writing to wal for Mutations".
INLINE COMMENTS
src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java:859 What about thrift2 ?
e.g. src/main/java/org/apache/hadoop/hbase/thrift2/ThriftUtilities.java has counterparts for this method.
REVISION DETAIL
https://reviews.facebook.net/D1515
> Improve the Thrift API to switch on/off writing to wal for Mutations
> ---------------------------------------------------------------------
>
> Key: HBASE-5295
> URL: https://issues.apache.org/jira/browse/HBASE-5295
> Project: HBase
> Issue Type: Improvement
> Components: thrift
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Attachments: D1515.1.patch, D1515.1.patch, D1515.1.patch, D1515.1.patch
>
>
> The thrift api currently does not support switching off updating wal for Puts/Deletes. Support it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5295) Improve the Thrift API to switch
on/off writing to wal for Mutations
Posted by "Phabricator (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13268724#comment-13268724 ]
Phabricator commented on HBASE-5295:
------------------------------------
Kannan has commented on the revision "[jira] [HBASE-5295] [89-fb] Improve the Thrift API to switch on/off writing to wal for Mutations".
INLINE COMMENTS
src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java:989 @mikhail: the tighter check you added to make sure all mutations have the same writeToWAL setting should be added for this case too.
Otherwise, rest of the diff looks really good. And nice test!
REVISION DETAIL
https://reviews.facebook.net/D3015
> Improve the Thrift API to switch on/off writing to wal for Mutations
> ---------------------------------------------------------------------
>
> Key: HBASE-5295
> URL: https://issues.apache.org/jira/browse/HBASE-5295
> Project: HBase
> Issue Type: Improvement
> Components: thrift
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Attachments: D1515.1.patch, D1515.1.patch, D1515.1.patch, D1515.1.patch, D1515.2.patch, D1515.2.patch, D1515.2.patch, D1515.2.patch, D3015.1.patch
>
>
> The thrift api currently does not support switching off updating wal for Puts/Deletes. Support it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5295) Improve the Thrift API to switch
on/off writing to wal for Mutations
Posted by "dhruba borthakur (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
dhruba borthakur updated HBASE-5295:
------------------------------------
Status: Patch Available (was: Open)
> Improve the Thrift API to switch on/off writing to wal for Mutations
> ---------------------------------------------------------------------
>
> Key: HBASE-5295
> URL: https://issues.apache.org/jira/browse/HBASE-5295
> Project: HBase
> Issue Type: Improvement
> Components: thrift
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Attachments: D1515.1.patch, D1515.1.patch, D1515.1.patch, D1515.1.patch
>
>
> The thrift api currently does not support switching off updating wal for Puts/Deletes. Support it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5295) Improve the Thrift API to switch
on/off writing to wal for Mutations
Posted by "dhruba borthakur (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13198005#comment-13198005 ]
dhruba borthakur commented on HBASE-5295:
-----------------------------------------
Can some kind soul pl commit this one?
> Improve the Thrift API to switch on/off writing to wal for Mutations
> ---------------------------------------------------------------------
>
> Key: HBASE-5295
> URL: https://issues.apache.org/jira/browse/HBASE-5295
> Project: HBase
> Issue Type: Improvement
> Components: thrift
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Attachments: D1515.1.patch, D1515.1.patch, D1515.1.patch, D1515.1.patch, D1515.2.patch, D1515.2.patch, D1515.2.patch, D1515.2.patch
>
>
> The thrift api currently does not support switching off updating wal for Puts/Deletes. Support it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5295) Improve the Thrift API to switch
on/off writing to wal for Mutations
Posted by "Phabricator (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13268898#comment-13268898 ]
Phabricator commented on HBASE-5295:
------------------------------------
Kannan has commented on the revision "[jira] [HBASE-5295] [89-fb] Improve the Thrift API to switch on/off writing to wal for Mutations".
looks good! nice work as usual Mikhail.
INLINE COMMENTS
src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java:2370 good catch!
REVISION DETAIL
https://reviews.facebook.net/D3015
> Improve the Thrift API to switch on/off writing to wal for Mutations
> ---------------------------------------------------------------------
>
> Key: HBASE-5295
> URL: https://issues.apache.org/jira/browse/HBASE-5295
> Project: HBase
> Issue Type: Improvement
> Components: thrift
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Attachments: D1515.1.patch, D1515.1.patch, D1515.1.patch, D1515.1.patch, D1515.2.patch, D1515.2.patch, D1515.2.patch, D1515.2.patch, D3015.1.patch, D3015.2.patch, D3015.3.patch, D3015.4.patch
>
>
> The thrift api currently does not support switching off updating wal for Puts/Deletes. Support it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5295) Improve the Thrift API to switch
on/off writing to wal for Mutations
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13196587#comment-13196587 ]
Phabricator commented on HBASE-5295:
------------------------------------
tedyu has accepted the revision "[jira] [HBASE-5295] Improve the Thrift API to switch on/off writing to wal for Mutations".
REVISION DETAIL
https://reviews.facebook.net/D1515
> Improve the Thrift API to switch on/off writing to wal for Mutations
> ---------------------------------------------------------------------
>
> Key: HBASE-5295
> URL: https://issues.apache.org/jira/browse/HBASE-5295
> Project: HBase
> Issue Type: Improvement
> Components: thrift
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Attachments: D1515.1.patch, D1515.1.patch, D1515.1.patch, D1515.1.patch, D1515.2.patch, D1515.2.patch, D1515.2.patch, D1515.2.patch
>
>
> The thrift api currently does not support switching off updating wal for Puts/Deletes. Support it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5295) Improve the Thrift API to switch
on/off writing to wal for Mutations
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195695#comment-13195695 ]
Phabricator commented on HBASE-5295:
------------------------------------
dhruba has commented on the revision "[jira] [HBASE-5295] Improve the Thrift API to switch on/off writing to wal for Mutations".
INLINE COMMENTS
src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java:859 thrift2/TPut already has the feature to switch off wal if needed, no further work is necessary.
also, just curious: the two thrift apis are not same. there are some features exposed via thrift that are not exposed via thrift2 and vice-versa. can you pl educate me on the history on why we have two different thrift apis?
REVISION DETAIL
https://reviews.facebook.net/D1515
> Improve the Thrift API to switch on/off writing to wal for Mutations
> ---------------------------------------------------------------------
>
> Key: HBASE-5295
> URL: https://issues.apache.org/jira/browse/HBASE-5295
> Project: HBase
> Issue Type: Improvement
> Components: thrift
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Attachments: D1515.1.patch, D1515.1.patch, D1515.1.patch, D1515.1.patch
>
>
> The thrift api currently does not support switching off updating wal for Puts/Deletes. Support it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5295) Improve the Thrift API to switch
on/off writing to wal for Mutations
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13196588#comment-13196588 ]
Phabricator commented on HBASE-5295:
------------------------------------
tedyu has accepted the revision "[jira] [HBASE-5295] Improve the Thrift API to switch on/off writing to wal for Mutations".
REVISION DETAIL
https://reviews.facebook.net/D1515
> Improve the Thrift API to switch on/off writing to wal for Mutations
> ---------------------------------------------------------------------
>
> Key: HBASE-5295
> URL: https://issues.apache.org/jira/browse/HBASE-5295
> Project: HBase
> Issue Type: Improvement
> Components: thrift
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Attachments: D1515.1.patch, D1515.1.patch, D1515.1.patch, D1515.1.patch, D1515.2.patch, D1515.2.patch, D1515.2.patch, D1515.2.patch
>
>
> The thrift api currently does not support switching off updating wal for Puts/Deletes. Support it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5295) Improve the Thrift API to switch
on/off writing to wal for Mutations
Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13196046#comment-13196046 ]
Zhihong Yu commented on HBASE-5295:
-----------------------------------
There were no hanging tests for patch v2.
> Improve the Thrift API to switch on/off writing to wal for Mutations
> ---------------------------------------------------------------------
>
> Key: HBASE-5295
> URL: https://issues.apache.org/jira/browse/HBASE-5295
> Project: HBase
> Issue Type: Improvement
> Components: thrift
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Attachments: D1515.1.patch, D1515.1.patch, D1515.1.patch, D1515.1.patch, D1515.2.patch, D1515.2.patch, D1515.2.patch, D1515.2.patch
>
>
> The thrift api currently does not support switching off updating wal for Puts/Deletes. Support it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5295) Improve the Thrift API to switch
on/off writing to wal for Mutations
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195697#comment-13195697 ]
Phabricator commented on HBASE-5295:
------------------------------------
dhruba has commented on the revision "[jira] [HBASE-5295] Improve the Thrift API to switch on/off writing to wal for Mutations".
INLINE COMMENTS
src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java:859 thrift2/TPut already has the feature to switch off wal if needed, no further work is necessary.
also, just curious: the two thrift apis are not same. there are some features exposed via thrift that are not exposed via thrift2 and vice-versa. can you pl educate me on the history on why we have two different thrift apis?
REVISION DETAIL
https://reviews.facebook.net/D1515
> Improve the Thrift API to switch on/off writing to wal for Mutations
> ---------------------------------------------------------------------
>
> Key: HBASE-5295
> URL: https://issues.apache.org/jira/browse/HBASE-5295
> Project: HBase
> Issue Type: Improvement
> Components: thrift
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Attachments: D1515.1.patch, D1515.1.patch, D1515.1.patch, D1515.1.patch
>
>
> The thrift api currently does not support switching off updating wal for Puts/Deletes. Support it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5295) Improve the Thrift API to switch
on/off writing to wal for Mutations
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13198087#comment-13198087 ]
Hudson commented on HBASE-5295:
-------------------------------
Integrated in HBase-TRUNK #2650 (See [https://builds.apache.org/job/HBase-TRUNK/2650/])
HBASE-5295 Improve the Thrift API to switch on/off writing to wal for Mutations (Dhruba)
tedyu :
Files :
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift/generated/BatchMutation.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift/generated/Hbase.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift/generated/Mutation.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift/generated/TRowResult.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift/generated/TScan.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift2/ThriftUtilities.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TDelete.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TGet.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift2/generated/THBaseService.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TIncrement.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TPut.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TResult.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift2/generated/TScan.java
* /hbase/trunk/src/main/resources/org/apache/hadoop/hbase/thrift/Hbase.thrift
* /hbase/trunk/src/main/resources/org/apache/hadoop/hbase/thrift2/hbase.thrift
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java
> Improve the Thrift API to switch on/off writing to wal for Mutations
> ---------------------------------------------------------------------
>
> Key: HBASE-5295
> URL: https://issues.apache.org/jira/browse/HBASE-5295
> Project: HBase
> Issue Type: Improvement
> Components: thrift
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Attachments: D1515.1.patch, D1515.1.patch, D1515.1.patch, D1515.1.patch, D1515.2.patch, D1515.2.patch, D1515.2.patch, D1515.2.patch
>
>
> The thrift api currently does not support switching off updating wal for Puts/Deletes. Support it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5295) Improve the Thrift API to switch
on/off writing to wal for Mutations
Posted by "Phabricator (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HBASE-5295:
-------------------------------
Attachment: D3015.2.patch
mbautin updated the revision "[jira] [HBASE-5295] [89-fb] Improve the Thrift API to switch on/off writing to wal for Mutations".
Reviewers: Kannan, dhruba, sc, JIRA
Addressing Kannan's comment. Testing both API methods in the unit test.
REVISION DETAIL
https://reviews.facebook.net/D3015
AFFECTED FILES
src/main/java/org/apache/hadoop/hbase/KeyValue.java
src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java
src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java
src/main/java/org/apache/hadoop/hbase/thrift/ThriftUtilities.java
src/main/java/org/apache/hadoop/hbase/thrift/generated/Mutation.java
src/main/java/org/apache/hadoop/hbase/util/Bytes.java
src/main/resources/org/apache/hadoop/hbase/thrift/Hbase.thrift
src/test/java/org/apache/hadoop/hbase/HTestConst.java
src/test/java/org/apache/hadoop/hbase/thrift/TestMutationWriteToWAL.java
src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java
src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServerLegacy.java
> Improve the Thrift API to switch on/off writing to wal for Mutations
> ---------------------------------------------------------------------
>
> Key: HBASE-5295
> URL: https://issues.apache.org/jira/browse/HBASE-5295
> Project: HBase
> Issue Type: Improvement
> Components: thrift
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Attachments: D1515.1.patch, D1515.1.patch, D1515.1.patch, D1515.1.patch, D1515.2.patch, D1515.2.patch, D1515.2.patch, D1515.2.patch, D3015.1.patch, D3015.2.patch
>
>
> The thrift api currently does not support switching off updating wal for Puts/Deletes. Support it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5295) Improve the Thrift API to switch
on/off writing to wal for Mutations
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13196586#comment-13196586 ]
Phabricator commented on HBASE-5295:
------------------------------------
tedyu has accepted the revision "[jira] [HBASE-5295] Improve the Thrift API to switch on/off writing to wal for Mutations".
REVISION DETAIL
https://reviews.facebook.net/D1515
> Improve the Thrift API to switch on/off writing to wal for Mutations
> ---------------------------------------------------------------------
>
> Key: HBASE-5295
> URL: https://issues.apache.org/jira/browse/HBASE-5295
> Project: HBase
> Issue Type: Improvement
> Components: thrift
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Attachments: D1515.1.patch, D1515.1.patch, D1515.1.patch, D1515.1.patch, D1515.2.patch, D1515.2.patch, D1515.2.patch, D1515.2.patch
>
>
> The thrift api currently does not support switching off updating wal for Puts/Deletes. Support it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5295) Improve the Thrift API to switch
on/off writing to wal for Mutations
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195686#comment-13195686 ]
Hadoop QA commented on HBASE-5295:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12512345/D1515.1.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
-1 javadoc. The javadoc tool appears to have generated -140 warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 161 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat
org.apache.hadoop.hbase.mapred.TestTableMapReduce
org.apache.hadoop.hbase.client.TestFromClientSide
org.apache.hadoop.hbase.io.hfile.TestHFileBlock
org.apache.hadoop.hbase.mapreduce.TestImportTsv
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/866//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/866//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/866//console
This message is automatically generated.
> Improve the Thrift API to switch on/off writing to wal for Mutations
> ---------------------------------------------------------------------
>
> Key: HBASE-5295
> URL: https://issues.apache.org/jira/browse/HBASE-5295
> Project: HBase
> Issue Type: Improvement
> Components: thrift
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Attachments: D1515.1.patch, D1515.1.patch, D1515.1.patch, D1515.1.patch
>
>
> The thrift api currently does not support switching off updating wal for Puts/Deletes. Support it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5295) Improve the Thrift API to switch
on/off writing to wal for Mutations
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HBASE-5295:
-------------------------------
Attachment: D1515.2.patch
dhruba updated the revision "[jira] [HBASE-5295] Improve the Thrift API to switch on/off writing to wal for Mutations".
Reviewers: sc, tedyu, stack
Incorporated changes to thrift2 as well.
REVISION DETAIL
https://reviews.facebook.net/D1515
AFFECTED FILES
src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java
src/main/java/org/apache/hadoop/hbase/thrift2/ThriftUtilities.java
src/main/java/org/apache/hadoop/hbase/thrift2/generated/TResult.java
src/main/java/org/apache/hadoop/hbase/thrift2/generated/TGet.java
src/main/java/org/apache/hadoop/hbase/thrift2/generated/TDelete.java
src/main/java/org/apache/hadoop/hbase/thrift2/generated/THBaseService.java
src/main/java/org/apache/hadoop/hbase/thrift2/generated/TIncrement.java
src/main/java/org/apache/hadoop/hbase/thrift2/generated/TScan.java
src/main/java/org/apache/hadoop/hbase/thrift2/generated/TPut.java
src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java
src/main/java/org/apache/hadoop/hbase/thrift/generated/Mutation.java
src/main/java/org/apache/hadoop/hbase/thrift/generated/BatchMutation.java
src/main/java/org/apache/hadoop/hbase/thrift/generated/Hbase.java
src/main/java/org/apache/hadoop/hbase/thrift/generated/TScan.java
src/main/java/org/apache/hadoop/hbase/thrift/generated/TRowResult.java
src/main/resources/org/apache/hadoop/hbase/thrift/Hbase.thrift
src/main/resources/org/apache/hadoop/hbase/thrift2/hbase.thrift
> Improve the Thrift API to switch on/off writing to wal for Mutations
> ---------------------------------------------------------------------
>
> Key: HBASE-5295
> URL: https://issues.apache.org/jira/browse/HBASE-5295
> Project: HBase
> Issue Type: Improvement
> Components: thrift
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Attachments: D1515.1.patch, D1515.1.patch, D1515.1.patch, D1515.1.patch, D1515.2.patch, D1515.2.patch, D1515.2.patch, D1515.2.patch
>
>
> The thrift api currently does not support switching off updating wal for Puts/Deletes. Support it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5295) Improve the Thrift API to switch
on/off writing to wal for Mutations
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HBASE-5295:
-------------------------------
Attachment: D1515.1.patch
dhruba requested code review of "[jira] [HBASE-5295] Improve the Thrift API to switch on/off writing to wal for Mutations".
Reviewers: sc, tedyu, stack
Enhance the thrift api to have the ability to switch of wal when doing a put or delete. The only change is adding a new field to the thrift Mutation object.
TEST PLAN
TestThriftServer
REVISION DETAIL
https://reviews.facebook.net/D1515
AFFECTED FILES
src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java
src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java
src/main/java/org/apache/hadoop/hbase/thrift/generated/Mutation.java
src/main/java/org/apache/hadoop/hbase/thrift/generated/BatchMutation.java
src/main/java/org/apache/hadoop/hbase/thrift/generated/Hbase.java
src/main/java/org/apache/hadoop/hbase/thrift/generated/TScan.java
src/main/java/org/apache/hadoop/hbase/thrift/generated/TRowResult.java
src/main/resources/org/apache/hadoop/hbase/thrift/Hbase.thrift
MANAGE HERALD DIFFERENTIAL RULES
https://reviews.facebook.net/herald/view/differential/
WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/3165/
Tip: use the X-Herald-Rules header to filter Herald messages in your client.
> Improve the Thrift API to switch on/off writing to wal for Mutations
> ---------------------------------------------------------------------
>
> Key: HBASE-5295
> URL: https://issues.apache.org/jira/browse/HBASE-5295
> Project: HBase
> Issue Type: Improvement
> Components: thrift
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Attachments: D1515.1.patch, D1515.1.patch, D1515.1.patch, D1515.1.patch
>
>
> The thrift api currently does not support switching off updating wal for Puts/Deletes. Support it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5295) Improve the Thrift API to switch
on/off writing to wal for Mutations
Posted by "Phabricator (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HBASE-5295:
-------------------------------
Attachment: D3015.3.patch
mbautin updated the revision "[jira] [HBASE-5295] [89-fb] Improve the Thrift API to switch on/off writing to wal for Mutations".
Reviewers: Kannan, dhruba, sc, JIRA
Testing deletes. Fixed a bug: we were always writing deletes to WAL (this is fixed in trunk).
REVISION DETAIL
https://reviews.facebook.net/D3015
AFFECTED FILES
src/main/java/org/apache/hadoop/hbase/KeyValue.java
src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java
src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java
src/main/java/org/apache/hadoop/hbase/thrift/ThriftUtilities.java
src/main/java/org/apache/hadoop/hbase/thrift/generated/Mutation.java
src/main/java/org/apache/hadoop/hbase/util/Bytes.java
src/main/resources/org/apache/hadoop/hbase/thrift/Hbase.thrift
src/test/java/org/apache/hadoop/hbase/HTestConst.java
src/test/java/org/apache/hadoop/hbase/thrift/TestMutationWriteToWAL.java
src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java
src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServerLegacy.java
> Improve the Thrift API to switch on/off writing to wal for Mutations
> ---------------------------------------------------------------------
>
> Key: HBASE-5295
> URL: https://issues.apache.org/jira/browse/HBASE-5295
> Project: HBase
> Issue Type: Improvement
> Components: thrift
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Attachments: D1515.1.patch, D1515.1.patch, D1515.1.patch, D1515.1.patch, D1515.2.patch, D1515.2.patch, D1515.2.patch, D1515.2.patch, D3015.1.patch, D3015.2.patch, D3015.3.patch
>
>
> The thrift api currently does not support switching off updating wal for Puts/Deletes. Support it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5295) Improve the Thrift API to switch
on/off writing to wal for Mutations
Posted by "Phabricator (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13269852#comment-13269852 ]
Phabricator commented on HBASE-5295:
------------------------------------
Kannan has accepted the revision "[jira] [HBASE-5295] [89-fb] Improve the Thrift API to switch on/off writing to wal for Mutations".
sorry for forgetting to hit accept last time :)
REVISION DETAIL
https://reviews.facebook.net/D3015
BRANCH
hbase_5295_improve_the_thrift_api_to_switch_v6
> Improve the Thrift API to switch on/off writing to wal for Mutations
> ---------------------------------------------------------------------
>
> Key: HBASE-5295
> URL: https://issues.apache.org/jira/browse/HBASE-5295
> Project: HBase
> Issue Type: Improvement
> Components: thrift
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Attachments: D1515.1.patch, D1515.1.patch, D1515.1.patch, D1515.1.patch, D1515.2.patch, D1515.2.patch, D1515.2.patch, D1515.2.patch, D3015.1.patch, D3015.2.patch, D3015.3.patch, D3015.4.patch
>
>
> The thrift api currently does not support switching off updating wal for Puts/Deletes. Support it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5295) Improve the Thrift API to switch
on/off writing to wal for Mutations
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195962#comment-13195962 ]
Hadoop QA commented on HBASE-5295:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12512389/D1515.2.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
-1 javadoc. The javadoc tool appears to have generated -140 warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 161 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat
org.apache.hadoop.hbase.mapred.TestTableMapReduce
org.apache.hadoop.hbase.io.hfile.TestHFileBlock
org.apache.hadoop.hbase.mapreduce.TestImportTsv
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/868//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/868//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/868//console
This message is automatically generated.
> Improve the Thrift API to switch on/off writing to wal for Mutations
> ---------------------------------------------------------------------
>
> Key: HBASE-5295
> URL: https://issues.apache.org/jira/browse/HBASE-5295
> Project: HBase
> Issue Type: Improvement
> Components: thrift
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Attachments: D1515.1.patch, D1515.1.patch, D1515.1.patch, D1515.1.patch, D1515.2.patch, D1515.2.patch, D1515.2.patch, D1515.2.patch
>
>
> The thrift api currently does not support switching off updating wal for Puts/Deletes. Support it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5295) Improve the Thrift API to switch
on/off writing to wal for Mutations
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195767#comment-13195767 ]
Phabricator commented on HBASE-5295:
------------------------------------
tedyu has commented on the revision "[jira] [HBASE-5295] Improve the Thrift API to switch on/off writing to wal for Mutations".
thrift2/TDelete doesn't support WAL switch.
Delete is a mutation:
public class Delete extends Mutation
thrift2/ThriftUtilities.java has out.setWriteToWAL() call for incrementFromThrift() and incrementFromThrift(). deleteFromThrift() should also have this call.
w.r.t. why two thrift packages are maintained, you can find some discussions in this JIRA:
https://issues.apache.org/jira/browse/HBASE-1744?focusedCommentId=12921845&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-12921845
There're so many Thrift experts at FB, I am sure they have better idea about the two packages.
REVISION DETAIL
https://reviews.facebook.net/D1515
> Improve the Thrift API to switch on/off writing to wal for Mutations
> ---------------------------------------------------------------------
>
> Key: HBASE-5295
> URL: https://issues.apache.org/jira/browse/HBASE-5295
> Project: HBase
> Issue Type: Improvement
> Components: thrift
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Attachments: D1515.1.patch, D1515.1.patch, D1515.1.patch, D1515.1.patch
>
>
> The thrift api currently does not support switching off updating wal for Puts/Deletes. Support it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5295) Improve the Thrift API to switch
on/off writing to wal for Mutations
Posted by "Phabricator (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13269976#comment-13269976 ]
Phabricator commented on HBASE-5295:
------------------------------------
mbautin has committed the revision "[jira] [HBASE-5295] [89-fb] Improve the Thrift API to switch on/off writing to wal for Mutations".
REVISION DETAIL
https://reviews.facebook.net/D3015
COMMIT
https://reviews.facebook.net/rHBASEEIGHTNINEFBBRANCH1335234
> Improve the Thrift API to switch on/off writing to wal for Mutations
> ---------------------------------------------------------------------
>
> Key: HBASE-5295
> URL: https://issues.apache.org/jira/browse/HBASE-5295
> Project: HBase
> Issue Type: Improvement
> Components: thrift
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Attachments: D1515.1.patch, D1515.1.patch, D1515.1.patch, D1515.1.patch, D1515.2.patch, D1515.2.patch, D1515.2.patch, D1515.2.patch, D3015.1.patch, D3015.2.patch, D3015.3.patch, D3015.4.patch
>
>
> The thrift api currently does not support switching off updating wal for Puts/Deletes. Support it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5295) Improve the Thrift API to switch
on/off writing to wal for Mutations
Posted by "Phabricator (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HBASE-5295:
-------------------------------
Attachment: D3015.4.patch
mbautin updated the revision "[jira] [HBASE-5295] [89-fb] Improve the Thrift API to switch on/off writing to wal for Mutations".
Reviewers: Kannan, dhruba, sc, JIRA
Simplifying a couple of lines
REVISION DETAIL
https://reviews.facebook.net/D3015
AFFECTED FILES
src/main/java/org/apache/hadoop/hbase/KeyValue.java
src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java
src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java
src/main/java/org/apache/hadoop/hbase/thrift/ThriftUtilities.java
src/main/java/org/apache/hadoop/hbase/thrift/generated/Mutation.java
src/main/java/org/apache/hadoop/hbase/util/Bytes.java
src/main/resources/org/apache/hadoop/hbase/thrift/Hbase.thrift
src/test/java/org/apache/hadoop/hbase/HTestConst.java
src/test/java/org/apache/hadoop/hbase/thrift/TestMutationWriteToWAL.java
src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java
src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServerLegacy.java
> Improve the Thrift API to switch on/off writing to wal for Mutations
> ---------------------------------------------------------------------
>
> Key: HBASE-5295
> URL: https://issues.apache.org/jira/browse/HBASE-5295
> Project: HBase
> Issue Type: Improvement
> Components: thrift
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Attachments: D1515.1.patch, D1515.1.patch, D1515.1.patch, D1515.1.patch, D1515.2.patch, D1515.2.patch, D1515.2.patch, D1515.2.patch, D3015.1.patch, D3015.2.patch, D3015.3.patch, D3015.4.patch
>
>
> The thrift api currently does not support switching off updating wal for Puts/Deletes. Support it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5295) Improve the Thrift API to switch
on/off writing to wal for Mutations
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195679#comment-13195679 ]
Phabricator commented on HBASE-5295:
------------------------------------
tedyu has commented on the revision "[jira] [HBASE-5295] Improve the Thrift API to switch on/off writing to wal for Mutations".
INLINE COMMENTS
src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java:859 What about thrift2 ?
e.g. src/main/java/org/apache/hadoop/hbase/thrift2/ThriftUtilities.java has counterparts for this method.
REVISION DETAIL
https://reviews.facebook.net/D1515
> Improve the Thrift API to switch on/off writing to wal for Mutations
> ---------------------------------------------------------------------
>
> Key: HBASE-5295
> URL: https://issues.apache.org/jira/browse/HBASE-5295
> Project: HBase
> Issue Type: Improvement
> Components: thrift
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Attachments: D1515.1.patch, D1515.1.patch, D1515.1.patch, D1515.1.patch
>
>
> The thrift api currently does not support switching off updating wal for Puts/Deletes. Support it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5295) Improve the Thrift API to switch
on/off writing to wal for Mutations
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13196589#comment-13196589 ]
Phabricator commented on HBASE-5295:
------------------------------------
tedyu has accepted the revision "[jira] [HBASE-5295] Improve the Thrift API to switch on/off writing to wal for Mutations".
REVISION DETAIL
https://reviews.facebook.net/D1515
> Improve the Thrift API to switch on/off writing to wal for Mutations
> ---------------------------------------------------------------------
>
> Key: HBASE-5295
> URL: https://issues.apache.org/jira/browse/HBASE-5295
> Project: HBase
> Issue Type: Improvement
> Components: thrift
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Attachments: D1515.1.patch, D1515.1.patch, D1515.1.patch, D1515.1.patch, D1515.2.patch, D1515.2.patch, D1515.2.patch, D1515.2.patch
>
>
> The thrift api currently does not support switching off updating wal for Puts/Deletes. Support it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5295) Improve the Thrift API to switch
on/off writing to wal for Mutations
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195678#comment-13195678 ]
Phabricator commented on HBASE-5295:
------------------------------------
tedyu has commented on the revision "[jira] [HBASE-5295] Improve the Thrift API to switch on/off writing to wal for Mutations".
INLINE COMMENTS
src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java:859 What about thrift2 ?
e.g. src/main/java/org/apache/hadoop/hbase/thrift2/ThriftUtilities.java has counterparts for this method.
REVISION DETAIL
https://reviews.facebook.net/D1515
> Improve the Thrift API to switch on/off writing to wal for Mutations
> ---------------------------------------------------------------------
>
> Key: HBASE-5295
> URL: https://issues.apache.org/jira/browse/HBASE-5295
> Project: HBase
> Issue Type: Improvement
> Components: thrift
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Attachments: D1515.1.patch, D1515.1.patch, D1515.1.patch, D1515.1.patch
>
>
> The thrift api currently does not support switching off updating wal for Puts/Deletes. Support it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5295) Improve the Thrift API to switch
on/off writing to wal for Mutations
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195696#comment-13195696 ]
Phabricator commented on HBASE-5295:
------------------------------------
dhruba has commented on the revision "[jira] [HBASE-5295] Improve the Thrift API to switch on/off writing to wal for Mutations".
INLINE COMMENTS
src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java:859 thrift2/TPut already has the feature to switch off wal if needed, no further work is necessary.
also, just curious: the two thrift apis are not same. there are some features exposed via thrift that are not exposed via thrift2 and vice-versa. can you pl educate me on the history on why we have two different thrift apis?
REVISION DETAIL
https://reviews.facebook.net/D1515
> Improve the Thrift API to switch on/off writing to wal for Mutations
> ---------------------------------------------------------------------
>
> Key: HBASE-5295
> URL: https://issues.apache.org/jira/browse/HBASE-5295
> Project: HBase
> Issue Type: Improvement
> Components: thrift
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Attachments: D1515.1.patch, D1515.1.patch, D1515.1.patch, D1515.1.patch
>
>
> The thrift api currently does not support switching off updating wal for Puts/Deletes. Support it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5295) Improve the Thrift API to switch
on/off writing to wal for Mutations
Posted by "Zhihong Yu (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhihong Yu updated HBASE-5295:
------------------------------
Resolution: Fixed
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
> Improve the Thrift API to switch on/off writing to wal for Mutations
> ---------------------------------------------------------------------
>
> Key: HBASE-5295
> URL: https://issues.apache.org/jira/browse/HBASE-5295
> Project: HBase
> Issue Type: Improvement
> Components: thrift
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Attachments: D1515.1.patch, D1515.1.patch, D1515.1.patch, D1515.1.patch, D1515.2.patch, D1515.2.patch, D1515.2.patch, D1515.2.patch
>
>
> The thrift api currently does not support switching off updating wal for Puts/Deletes. Support it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5295) Improve the Thrift API to switch
on/off writing to wal for Mutations
Posted by "Phabricator (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13269824#comment-13269824 ]
Phabricator commented on HBASE-5295:
------------------------------------
mbautin has commented on the revision "[jira] [HBASE-5295] [89-fb] Improve the Thrift API to switch on/off writing to wal for Mutations".
@Kannan: thanks for reviewing! Could you please accept the diff if it looks good?
REVISION DETAIL
https://reviews.facebook.net/D3015
> Improve the Thrift API to switch on/off writing to wal for Mutations
> ---------------------------------------------------------------------
>
> Key: HBASE-5295
> URL: https://issues.apache.org/jira/browse/HBASE-5295
> Project: HBase
> Issue Type: Improvement
> Components: thrift
> Reporter: dhruba borthakur
> Assignee: dhruba borthakur
> Attachments: D1515.1.patch, D1515.1.patch, D1515.1.patch, D1515.1.patch, D1515.2.patch, D1515.2.patch, D1515.2.patch, D1515.2.patch, D3015.1.patch, D3015.2.patch, D3015.3.patch, D3015.4.patch
>
>
> The thrift api currently does not support switching off updating wal for Puts/Deletes. Support it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira