[GitHub] [spark] holdenk commented on a change in pull request #30693: [SPARK-33716][K8S] Fix potential race condition during pod termination

[GitBox <gi...@apache.org>]

holdenk commented on a change in pull request #30693:
URL: https://github.com/apache/spark/pull/30693#discussion_r539824745



##########
File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsSnapshot.scala
##########
@@ -93,7 +93,9 @@ object ExecutorPodsSnapshot extends Logging {
       (
         pod.getStatus == null ||
         pod.getStatus.getPhase == null ||
-        pod.getStatus.getPhase.toLowerCase(Locale.ROOT) != "terminating"
+          (pod.getStatus.getPhase.toLowerCase(Locale.ROOT) != "terminating" &&
+           pod.getStatus.getPhase.toLowerCase(Locale.ROOT) != "running" &&
+           pod.getStatus.getPhase.toLowerCase(Locale.ROOT) != "pending")

Review comment:
       No, but these are the cases which if it's deleted timestamp it might not be deleted. For example if it's in a failed state it's ok if its detected as deleted.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org