You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@arrow.apache.org by "Deneche A. Hakim (JIRA)" <ji...@apache.org> on 2016/12/06 17:06:58 UTC

[jira] [Created] (ARROW-407) BitVector.copyFromSafe() should re-allocate if necessary instead of returning false

Deneche A. Hakim created ARROW-407:
--------------------------------------

             Summary: BitVector.copyFromSafe() should re-allocate if necessary instead of returning false
                 Key: ARROW-407
                 URL: https://issues.apache.org/jira/browse/ARROW-407
             Project: Apache Arrow
          Issue Type: Bug
          Components: Java - Vectors
            Reporter: Deneche A. Hakim
            Assignee: Deneche A. Hakim


Current implementation:
{code}
public boolean copyFromSafe(int inIndex, int outIndex, BitVector from) {
    if (outIndex >= this.getValueCapacity()) {
      decrementAllocationMonitor();
      return false;
    }
    copyFrom(inIndex, outIndex, from);
    return true;
  }
{code}

doesn't match the expectation from "safe" methods. The method should try to re-allocate if it's running out of space instead of returning false



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)