You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2021/09/01 09:11:01 UTC
[jira] [Work logged] (BEAM-12683) PythonPostCommits
RecommendationAIIT.test_create_catalog_item failing
[ https://issues.apache.org/jira/browse/BEAM-12683?focusedWorklogId=644854&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-644854 ]
ASF GitHub Bot logged work on BEAM-12683:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Sep/21 09:10
Start Date: 01/Sep/21 09:10
Worklog Time Spent: 10m
Work Description: emilymye commented on a change in pull request #15330:
URL: https://github.com/apache/beam/pull/15330#discussion_r699632517
##########
File path: sdks/python/apache_beam/ml/gcp/recommendations_ai_test_it.py
##########
@@ -102,7 +104,13 @@ def test_predict(self):
assert_that(output, is_not_empty())
+ @classmethod
+ def tearDownClass(cls):
+ client = recommendationengine.CatalogServiceClient()
+ client.delete_catalog_item(
Review comment:
Ideally we list and delete, with exception catching here (see precommit failure) in case another instance has decided to delete the same object.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 644854)
Time Spent: 4.5h (was: 4h 20m)
> PythonPostCommits RecommendationAIIT.test_create_catalog_item failing
> ---------------------------------------------------------------------
>
> Key: BEAM-12683
> URL: https://issues.apache.org/jira/browse/BEAM-12683
> Project: Beam
> Issue Type: Bug
> Components: test-failures
> Affects Versions: 2.33.0
> Reporter: Emily Ye
> Assignee: Matthias Baetens
> Priority: P2
> Time Spent: 4.5h
> Remaining Estimate: 0h
>
> Failures:
> * [https://ci-beam.apache.org/job/beam_PostCommit_Python36/4167/ (*)|https://ci-beam.apache.org/job/beam_PostCommit_Python36/4168/]
> * [https://ci-beam.apache.org/job/beam_PostCommit_Python37/4080/]
> * [https://ci-beam.apache.org/job/beam_PostCommit_Python38/1490/]
> The only change around this time was [https://github.com/apache/beam/pull/15202,] but note that python37 fails before this change.
> *This is not the first failure in a row, but it is for this test. It occurs after #15202.
>
>
>
>
>
> ----
> _After you've filled out the above details, please [assign the issue to an individual|https://beam.apache.org/contribute/postcommits-guides/index.html#find_specialist]. Assignee should [treat test failures as high-priority|https://beam.apache.org/contribute/postcommits-policies/#assigned-failing-test], helping to fix the issue or find a more appropriate owner. See [Apache Beam Post-Commit Policies|https://beam.apache.org/contribute/postcommits-policies]._
--
This message was sent by Atlassian Jira
(v8.3.4#803005)