You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/11/24 11:15:36 UTC

[GitHub] [apisix-dashboard] starsz opened a new issue #866: feat: manager-api need show version info

starsz opened a new issue #866:
URL: https://github.com/apache/apisix-dashboard/issues/866


   # Feature request
   
   ## Please describe your feature
   
   Hi, I think manager-api needs version info. 
   
   Like: `./manager-api version`
   
   And when `manager-api` start, show the manager-api version.
   
   releated #853 
   
   ## Describe the solution you'd like
   
   In golang, there are some ways to manage version.
   
   1. Create a file, named `version.go` and write the current version in this file.
   
   2. Use go build ldflags. Such as 
   `go build -ldflags "-X main.VERSION=1.0.0 -X 'main.BUILD_TIME=date' -X 'main.GO_VERSION=go version'"`
   We can add this into Makefile.
   
   I prefer the second solution.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] membphis closed issue #866: feat: manager-api need show version info

Posted by GitBox <gi...@apache.org>.
membphis closed issue #866:
URL: https://github.com/apache/apisix-dashboard/issues/866


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #866: feat: manager-api need show version info

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #866:
URL: https://github.com/apache/apisix-dashboard/issues/866#issuecomment-733418617


   Do we have any ideas?
   
   cc @liuxiran @tokers @nic-chen @membphis @ShiningRush 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] tokers commented on issue #866: feat: manager-api need show version info

Posted by GitBox <gi...@apache.org>.
tokers commented on issue #866:
URL: https://github.com/apache/apisix-dashboard/issues/866#issuecomment-733420085


   AFAIK, Most golang projects are using the second way to inject the version info.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] tokers commented on issue #866: feat: manager-api need show version info

Posted by GitBox <gi...@apache.org>.
tokers commented on issue #866:
URL: https://github.com/apache/apisix-dashboard/issues/866#issuecomment-733574205


   @nic-chen The status API in #849 exposes APISIX instances' data, which contains APISIX version.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] membphis commented on issue #866: feat: manager-api need show version info

Posted by GitBox <gi...@apache.org>.
membphis commented on issue #866:
URL: https://github.com/apache/apisix-dashboard/issues/866#issuecomment-733484147


   > Most golang projects are using the second way to inject the version info, like istio, etcd.
   
   This is a good reason.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan edited a comment on issue #866: feat: manager-api need show version info

Posted by GitBox <gi...@apache.org>.
juzhiyuan edited a comment on issue #866:
URL: https://github.com/apache/apisix-dashboard/issues/866#issuecomment-733418617


   Do we have any ideas?
   
   cc @liuxiran @tokers @nic-chen @membphis @ShiningRush @spacewander 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] nic-chen commented on issue #866: feat: manager-api need show version info

Posted by GitBox <gi...@apache.org>.
nic-chen commented on issue #866:
URL: https://github.com/apache/apisix-dashboard/issues/866#issuecomment-733600753


   > @nic-chen The status API in #849 exposes APISIX instances' data, which contains APISIX version.
   
   sure. I know that. but I think we should expose data of `manager-api` too. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] tokers edited a comment on issue #866: feat: manager-api need show version info

Posted by GitBox <gi...@apache.org>.
tokers edited a comment on issue #866:
URL: https://github.com/apache/apisix-dashboard/issues/866#issuecomment-733420085


   AFAIK, Most golang projects are using the second way to inject the version info, like istio, etcd.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] nic-chen commented on issue #866: feat: manager-api need show version info

Posted by GitBox <gi...@apache.org>.
nic-chen commented on issue #866:
URL: https://github.com/apache/apisix-dashboard/issues/866#issuecomment-733515541


   second way +1
   but could the version be read by status API mention in #849 ?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org