You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/04/16 07:04:36 UTC
[GitHub] [incubator-mxnet] MoisesHer opened a new pull request #18082: Add
gelu fuse ops
MoisesHer opened a new pull request #18082: Add gelu fuse ops
URL: https://github.com/apache/incubator-mxnet/pull/18082
## Description ##
This PR adds into elementwise fused-operators LeakyReLU:gelu
## Checklist ##
### Essentials ###
Please feel free to remove inapplicable items for your PR.
- [x] Changes are complete (i.e. I finished coding on this PR)
- [x] All changes have test coverage:
- Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
- [x] Code is well-documented:
- [x] To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
### Changes ###
- [x] In pointwise fusion pass, set as fusion-compatible both LeakyReLU and _backward_LeakyReLU if activation type is in the provided list (only "gelu" for now)
- [x] In the fused-ops code generator, include functions for LeakyReLU:gelu and _backward_LeakyReLU:gelu
- [x] Included test into tests/python/gpu/test_fusion.py
## Comments ##
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] ptrendx commented on a change in pull request
#18082: Add gelu fuse ops
Posted by GitBox <gi...@apache.org>.
ptrendx commented on a change in pull request #18082: Add gelu fuse ops
URL: https://github.com/apache/incubator-mxnet/pull/18082#discussion_r409713331
##########
File path: src/operator/fusion/fused_op-inl.h
##########
@@ -543,6 +552,13 @@ __device__ inline DType relu(const DType val) {
return val > 0 ? val : 0;
}
+__constant__ const float SQRT_2 = 1.4142135623730950488016887242096;
Review comment:
Are you sure you want to use constant memory here? It should be constexpr or something.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] MoisesHer commented on issue #18082: Add gelu
fuse ops
Posted by GitBox <gi...@apache.org>.
MoisesHer commented on issue #18082: Add gelu fuse ops
URL: https://github.com/apache/incubator-mxnet/pull/18082#issuecomment-615020849
@mxnet-bot run ci [centos-gpu, unix-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] MoisesHer commented on a change in pull request
#18082: Add gelu fuse ops
Posted by GitBox <gi...@apache.org>.
MoisesHer commented on a change in pull request #18082: Add gelu fuse ops
URL: https://github.com/apache/incubator-mxnet/pull/18082#discussion_r409751099
##########
File path: src/operator/fusion/fused_op-inl.h
##########
@@ -543,6 +552,13 @@ __device__ inline DType relu(const DType val) {
return val > 0 ? val : 0;
}
+__constant__ const float SQRT_2 = 1.4142135623730950488016887242096;
Review comment:
Thank you, I just removed "__constant__"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] ptrendx merged pull request #18082: Add gelu fuse
ops
Posted by GitBox <gi...@apache.org>.
ptrendx merged pull request #18082: Add gelu fuse ops
URL: https://github.com/apache/incubator-mxnet/pull/18082
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] mxnet-bot commented on issue #18082: Add gelu
fuse ops
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on issue #18082: Add gelu fuse ops
URL: https://github.com/apache/incubator-mxnet/pull/18082#issuecomment-615020905
Jenkins CI successfully triggered : [unix-gpu, centos-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] mxnet-bot commented on issue #18082: Add gelu
fuse ops
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on issue #18082: Add gelu fuse ops
URL: https://github.com/apache/incubator-mxnet/pull/18082#issuecomment-614455249
Hey @MoisesHer , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [website, unix-cpu, edge, miscellaneous, centos-cpu, windows-gpu, unix-gpu, windows-cpu, clang, centos-gpu, sanity]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services