[GitHub] [apisix-website] 1502shivam-singh commented on pull request #297: fix: darkMode enhanced

[GitBox <gi...@apache.org>]

1502shivam-singh commented on pull request #297:
URL: https://github.com/apache/apisix-website/pull/297#issuecomment-817136261


   > @Yiyiyimu @juzhiyuan @nic-chen @gxthrj
   > How is it now?
   > ![scrnli_10_04_2021_15-38-50](https://user-images.githubusercontent.com/40708551/114266705-4b1b4080-9a15-11eb-9f36-3581053eef0e.png)
   
   Some points -
   - Avoid using pure black, like you have used in description section. Hurts eyes when using dark mode, when its actually needed i.e. in dark. Try material design based colors
   - Don't grey out the CTA's, like the "View on GitHub" button
   - Watch out for the other greyed out buttons like the "subscribe" button. The button and button text contrast is quite low.
   - Contrast issues elsewhere in the site
   
   ![image](https://user-images.githubusercontent.com/57267960/114270652-2c27a900-9a2b-11eb-83be-ccec5404a205.png)
   
   ![image](https://user-images.githubusercontent.com/57267960/114270685-698c3680-9a2b-11eb-9190-9d8b94798ef6.png)
   
   - Something not related to your doing, but some company logos in "Who is using this" section don't have an alpha property, so it looks odd that some have a white background while other don't and they don't mix properly.
   
   Fact is, that the images on the home-page are not yet optimized to fit in a dark mode. Like the design image in description section doesn't look like it belongs to this website in dark mode, because of color differences and all. It even looks as if its cropped out uneven, without any space tbh 😕.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org