You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/05/08 12:13:17 UTC

[GitHub] [apisix-dashboard] iamayushdas opened a new pull request #1881: chore: refactored test login.spec.js

iamayushdas opened a new pull request #1881:
URL: https://github.com/apache/apisix-dashboard/pull/1881


   Please answer these questions before submitting a pull request, **or your PR will get closed**.
   
   **Why submit this pull request?**
   
   - [ ] Bugfix
   - [ ] New feature provided
   - [ ] Improve performance
   - [ ] Backport patches
   - [x] Refactor
   
   **What changes will this PR take into?**
   
   Refactor Testcase for Frontend.
   
   **Related issues**
   
   related issue #1774 
   
   **Checklist:**
   
   - [x] Did you explain what problem does this PR solve? Or what new features have been added?
   - [x] Have you added corresponding test cases?
   - [ ] Have you modified the corresponding document?
   - [x] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #1881: chore: refactored test login.spec.js

Posted by GitBox <gi...@apache.org>.
liuxiran commented on a change in pull request #1881:
URL: https://github.com/apache/apisix-dashboard/pull/1881#discussion_r629843361



##########
File path: web/cypress/integration/user/login.spec.js
##########
@@ -17,39 +17,45 @@
 /* eslint-disable no-undef */
 
 context('Login Test', () => {
+  const selector = {
+    errorExplain: '.ant-form-item-explain',
+    usernameInput: '#control-ref_username',
+    passwordInput: '#control-ref_password',
+    notification: '.ant-notification-notice-message',
+  };
+

Review comment:
       but other prs define `data` to store test data,  it would be better to keep the same way 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] iamayushdas commented on a change in pull request #1881: chore: refactored test login.spec.js

Posted by GitBox <gi...@apache.org>.
iamayushdas commented on a change in pull request #1881:
URL: https://github.com/apache/apisix-dashboard/pull/1881#discussion_r630259580



##########
File path: web/cypress/integration/user/login.spec.js
##########
@@ -17,39 +17,45 @@
 /* eslint-disable no-undef */
 
 context('Login Test', () => {
+  const selector = {
+    errorExplain: '.ant-form-item-explain',
+    usernameInput: '#control-ref_username',
+    passwordInput: '#control-ref_password',
+    notification: '.ant-notification-notice-message',
+  };
+

Review comment:
       done!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1881: chore: refactored test login.spec.js

Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1881:
URL: https://github.com/apache/apisix-dashboard/pull/1881#issuecomment-835333257






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #1881: chore: refactored test login.spec.js

Posted by GitBox <gi...@apache.org>.
liuxiran commented on a change in pull request #1881:
URL: https://github.com/apache/apisix-dashboard/pull/1881#discussion_r629840470



##########
File path: web/cypress/integration/user/login.spec.js
##########
@@ -17,39 +17,45 @@
 /* eslint-disable no-undef */
 
 context('Login Test', () => {
+  const selector = {
+    errorExplain: '.ant-form-item-explain',
+    usernameInput: '#control-ref_username',
+    passwordInput: '#control-ref_password',
+    notification: '.ant-notification-notice-message',
+  };
+

Review comment:
       do we need to define `data`? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1881: chore: refactored test login.spec.js

Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1881:
URL: https://github.com/apache/apisix-dashboard/pull/1881#issuecomment-835333257


   Deploy preview for *apisix-dashboard* processing.
   
   Building with commit b24417b7f88634b78387a5c036e8136815a5fd86
   
   https://app.netlify.com/sites/apisix-dashboard/deploys/609a9c05384a2300078ec673


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] codecov-commenter commented on pull request #1881: chore: refactored test login.spec.js

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1881:
URL: https://github.com/apache/apisix-dashboard/pull/1881#issuecomment-835343156


   # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1881?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1881](https://codecov.io/gh/apache/apisix-dashboard/pull/1881?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (01fc99f) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/b1e66a286a7fa0fd276bcd4bf1dee8a065947676?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b1e66a2) will **increase** coverage by `0.06%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1881/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-dashboard/pull/1881?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #1881      +/-   ##
   ==========================================
   + Coverage   72.10%   72.17%   +0.06%     
   ==========================================
     Files         125      125              
     Lines        2947     2947              
     Branches      711      711              
   ==========================================
   + Hits         2125     2127       +2     
   + Misses        822      820       -2     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | frontend-e2e-test | `72.17% <ø> (+0.06%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1881?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [web/src/helpers.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1881/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9oZWxwZXJzLnRzeA==) | `72.13% <0.00%> (+3.27%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1881?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1881?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b1e66a2...01fc99f](https://codecov.io/gh/apache/apisix-dashboard/pull/1881?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] iamayushdas commented on a change in pull request #1881: chore: refactored test login.spec.js

Posted by GitBox <gi...@apache.org>.
iamayushdas commented on a change in pull request #1881:
URL: https://github.com/apache/apisix-dashboard/pull/1881#discussion_r629841040



##########
File path: web/cypress/integration/user/login.spec.js
##########
@@ -17,39 +17,45 @@
 /* eslint-disable no-undef */
 
 context('Login Test', () => {
+  const selector = {
+    errorExplain: '.ant-form-item-explain',
+    usernameInput: '#control-ref_username',
+    passwordInput: '#control-ref_password',
+    notification: '.ant-notification-notice-message',
+  };
+

Review comment:
       no, not here




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] commented on pull request #1881: chore: refactored test login.spec.js

Posted by GitBox <gi...@apache.org>.
netlify[bot] commented on pull request #1881:
URL: https://github.com/apache/apisix-dashboard/pull/1881#issuecomment-835333257


   Deploy preview for *apisix-dashboard* processing.
   
   Building with commit 01fc99ffb36360da6ab84f5aafdded10cadcf991
   
   https://app.netlify.com/sites/apisix-dashboard/deploys/60968057edc1db000889ccbd


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] liuxiran commented on pull request #1881: chore: refactored test login.spec.js

Posted by GitBox <gi...@apache.org>.
liuxiran commented on pull request #1881:
URL: https://github.com/apache/apisix-dashboard/pull/1881#issuecomment-839357597


   > @liuxiran can you retrigger CI , as i have checked it again, everything is working fine
   > ![Screenshot from 2021-05-11 21-09-12](https://user-images.githubusercontent.com/40708551/117844533-60e28680-b29d-11eb-846d-03bed8fcad69.png)
   
   Ok, retry CI. Mark the error: https://github.com/apache/apisix-dashboard/pull/1881/checks?check_run_id=2557014779, maybe it is an un stable case,need some time to fix it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1881: chore: refactored test login.spec.js

Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1881:
URL: https://github.com/apache/apisix-dashboard/pull/1881#issuecomment-835333257


   Deploy preview for *apisix-dashboard* ready!
   
   Built with commit 01fc99ffb36360da6ab84f5aafdded10cadcf991
   
   https://deploy-preview-1881--apisix-dashboard.netlify.app


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] LiteSun merged pull request #1881: chore: refactored test login.spec.js

Posted by GitBox <gi...@apache.org>.
LiteSun merged pull request #1881:
URL: https://github.com/apache/apisix-dashboard/pull/1881


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1881: chore: refactored test login.spec.js

Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1881:
URL: https://github.com/apache/apisix-dashboard/pull/1881#issuecomment-835333257


   Deploy preview for *apisix-dashboard* ready!
   
   Built with commit 1fa05fb15892a3694dc01ab58f06609ea47eb285
   
   https://deploy-preview-1881--apisix-dashboard.netlify.app


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] LiteSun merged pull request #1881: chore: refactored test login.spec.js

Posted by GitBox <gi...@apache.org>.
LiteSun merged pull request #1881:
URL: https://github.com/apache/apisix-dashboard/pull/1881


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1881: chore: refactored test login.spec.js

Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #1881:
URL: https://github.com/apache/apisix-dashboard/pull/1881#issuecomment-838708215


   @liuxiran can you retrigger CI , as i have checked it again, everything is working fine
   ![Screenshot from 2021-05-11 21-09-12](https://user-images.githubusercontent.com/40708551/117844533-60e28680-b29d-11eb-846d-03bed8fcad69.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org