Re: git commit: use vfb to run chrome headless

[Andrew Grieve <ag...@google.com>]

Just looking through diffs.

I don't think the kill -9 will ever be called since the previous line does
an exec.


On Thu, Feb 20, 2014 at 2:52 PM, <dr...@apache.org> wrote:

> Repository: cordova-medic
> Updated Branches:
>   refs/heads/master 90367aefe -> dd5173036
>
>
> use vfb to run chrome headless
>
>
> Project: http://git-wip-us.apache.org/repos/asf/cordova-medic/repo
> Commit:
> http://git-wip-us.apache.org/repos/asf/cordova-medic/commit/dd517303
> Tree: http://git-wip-us.apache.org/repos/asf/cordova-medic/tree/dd517303
> Diff: http://git-wip-us.apache.org/repos/asf/cordova-medic/diff/dd517303
>
> Branch: refs/heads/master
> Commit: dd5173036939fc1505a71601b15062116e65c6cc
> Parents: 90367ae
> Author: David Kemp <dr...@chromium.org>
> Authored: Thu Feb 20 14:51:31 2014 -0500
> Committer: David Kemp <dr...@chromium.org>
> Committed: Thu Feb 20 14:51:31 2014 -0500
>
> ----------------------------------------------------------------------
>  runner/runchrome.sh | 4 ++++
>  1 file changed, 4 insertions(+)
> ----------------------------------------------------------------------
>
>
>
> http://git-wip-us.apache.org/repos/asf/cordova-medic/blob/dd517303/runner/runchrome.sh
> ----------------------------------------------------------------------
> diff --git a/runner/runchrome.sh b/runner/runchrome.sh
> index 516f52c..c779145 100755
> --- a/runner/runchrome.sh
> +++ b/runner/runchrome.sh
> @@ -1,5 +1,9 @@
>  #!/bin/sh
>  # loads and runs the chrome-apps test
>  #
> +/opt/X11/bin/Xvfb :99 -ac &
> +PID_XVFB="$!"
> +export DISPLAY=:99
>  exec /Applications/Google\ Chrome.app/Contents/MacOS/Google\ Chrome
> --load-and-launch-app=$1  --no-startup-window
> +kill -9 $PID_VFB
>
>
>