You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "potiuk (via GitHub)" <gi...@apache.org> on 2024/10/31 18:24:44 UTC
[PR] Test standard provider with Airflow 2.8 and 2.9 [airflow]
potiuk opened a new pull request, #43556:
URL: https://github.com/apache/airflow/pull/43556
The standard provider has now min version of Airflow = 2.8 since #43553, but we have not tested it for Airflow 2.8 and 2.9.
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Test standard provider with Airflow 2.8 and 2.9 [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #43556:
URL: https://github.com/apache/airflow/pull/43556#discussion_r1842120046
##########
providers/src/airflow/providers/standard/__init__.py:
##########
@@ -15,3 +15,12 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
+from __future__ import annotations
+
+from packaging.version import Version
+
+from airflow import __version__ as airflow_version
+
+AIRFLOW_VERSION = Version(airflow_version)
+AIRFLOW_V_2_10_PLUS = Version(AIRFLOW_VERSION.base_version) >= Version("2.10.0")
+AIRFLOW_V_3_0_PLUS = Version(AIRFLOW_VERSION.base_version) >= Version("3.0.0")
Review Comment:
aaaaaa! !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Test standard provider with Airflow 2.8 and 2.9 [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #43556:
URL: https://github.com/apache/airflow/pull/43556#issuecomment-2453543671
There are still some interesting problems to solve :). I already found another teething problem from providers move :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Test standard provider with Airflow 2.8 and 2.9 [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #43556:
URL: https://github.com/apache/airflow/pull/43556
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Test standard provider with Airflow 2.8 and 2.9 [airflow]
Posted by "Lee-W (via GitHub)" <gi...@apache.org>.
Lee-W commented on code in PR #43556:
URL: https://github.com/apache/airflow/pull/43556#discussion_r1827120044
##########
providers/src/airflow/providers/standard/operators/python.py:
##########
@@ -187,7 +188,15 @@ def __init__(
def execute(self, context: Context) -> Any:
context_merge(context, self.op_kwargs, templates_dict=self.templates_dict)
self.op_kwargs = self.determine_kwargs(context)
- self._asset_events = context_get_outlet_events(context)
+
Review Comment:
Just checked. I think you're right 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Test standard provider with Airflow 2.8 and 2.9 [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #43556:
URL: https://github.com/apache/airflow/pull/43556#issuecomment-2464130128
Actually - really the thing is that that it was only working on 2.10 when ENABLE_AIP_44 was used, so we really should only enable it only for Airlfow 3+
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Test standard provider with Airflow 2.8 and 2.9 [airflow]
Posted by "gopidesupavan (via GitHub)" <gi...@apache.org>.
gopidesupavan commented on PR #43556:
URL: https://github.com/apache/airflow/pull/43556#issuecomment-2450992672
> Ha.... so we are NOT good with standard provider for 2.8 and 2.9 YET
hm sorry my bad 😞 , i thought only on airflow 2.10
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Test standard provider with Airflow 2.8 and 2.9 [airflow]
Posted by "gopidesupavan (via GitHub)" <gi...@apache.org>.
gopidesupavan commented on PR #43556:
URL: https://github.com/apache/airflow/pull/43556#issuecomment-2466397589
> @gopidesupavan - you can rebase and check yout #43818 now
woohoo merged thank you @potiuk :) . Let me rebase other pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Test standard provider with Airflow 2.8 and 2.9 [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #43556:
URL: https://github.com/apache/airflow/pull/43556#discussion_r1827054502
##########
providers/tests/openlineage/utils/test_utils.py:
##########
@@ -43,14 +43,11 @@
from airflow.utils.task_group import TaskGroup
from airflow.utils.types import DagRunType
-from tests_common.test_utils.compat import AIRFLOW_V_2_10_PLUS, BashOperator, PythonOperator
+from tests_common.test_utils.compat import BashOperator, PythonOperator
from tests_common.test_utils.mock_operators import MockOperator
BASH_OPERATOR_PATH = "airflow.providers.standard.operators.bash"
PYTHON_OPERATOR_PATH = "airflow.providers.standard.operators.python"
-if not AIRFLOW_V_2_10_PLUS:
Review Comment:
We don't need it any more - because when we run the tests using new "standard" provider - we will always get base operator paths from those standard providers, not from the "airlfow.operators" package :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Test standard provider with Airflow 2.8 and 2.9 [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #43556:
URL: https://github.com/apache/airflow/pull/43556#issuecomment-2450994506
> > Ha.... so we are NOT good with standard provider for 2.8 and 2.9 YET
>
> hm sorry my bad 😞 , i thought only on airflow 2.10
No worries :). Nice excercise to fix it for 2.8 and 2.9 :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Test standard provider with Airflow 2.8 and 2.9 [airflow]
Posted by "gopidesupavan (via GitHub)" <gi...@apache.org>.
gopidesupavan commented on PR #43556:
URL: https://github.com/apache/airflow/pull/43556#issuecomment-2462954597
alright got it where the failures coming from for this `providers/tests/standard/operators/test_python.py::TestBranchExternalPythonOperator::test_use_airflow_context_touch_other_variables` its acutally difference in the deserialisation between 2.8 and 2.10
2.10 has this casting Context: https://github.com/apache/airflow/blob/v2-10-stable/airflow/serialization/serialized_objects.py#L829, where as 2.8 and 2.9 doesn't have this implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Test standard provider with Airflow 2.8 and 2.9 [airflow]
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on code in PR #43556:
URL: https://github.com/apache/airflow/pull/43556#discussion_r1841998063
##########
providers/src/airflow/providers/standard/__init__.py:
##########
@@ -15,3 +15,12 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
+from __future__ import annotations
+
+from packaging.version import Version
+
+from airflow import __version__ as airflow_version
+
+AIRFLOW_VERSION = Version(airflow_version)
+AIRFLOW_V_2_10_PLUS = Version(AIRFLOW_VERSION.base_version) >= Version("2.10.0")
+AIRFLOW_V_3_0_PLUS = Version(AIRFLOW_VERSION.base_version) >= Version("3.0.0")
Review Comment:
Raised https://github.com/apache/airflow/pull/44017
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Test standard provider with Airflow 2.8 and 2.9 [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #43556:
URL: https://github.com/apache/airflow/pull/43556#issuecomment-2463555353
> Happy to make changes, I believe only need some test fixes and use_airflow_context Parameter checks between Versions
I am fixing it :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Test standard provider with Airflow 2.8 and 2.9 [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #43556:
URL: https://github.com/apache/airflow/pull/43556#discussion_r1835122537
##########
providers/src/airflow/providers/standard/sensors/time.py:
##########
@@ -102,7 +119,9 @@ def __init__(
def execute(self, context: Context) -> NoReturn:
self.defer(
- trigger=DateTimeTrigger(moment=self.target_datetime, end_from_trigger=self.end_from_trigger),
+ trigger=DateTimeTrigger(moment=self.target_datetime, end_from_trigger=self.end_from_trigger)
+ if AIRFLOW_V_3_0_PLUS
Review Comment:
Let me try
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Test standard provider with Airflow 2.8 and 2.9 [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #43556:
URL: https://github.com/apache/airflow/pull/43556#discussion_r1835446355
##########
providers/src/airflow/providers/standard/sensors/time.py:
##########
@@ -102,7 +119,9 @@ def __init__(
def execute(self, context: Context) -> NoReturn:
self.defer(
- trigger=DateTimeTrigger(moment=self.target_datetime, end_from_trigger=self.end_from_trigger),
+ trigger=DateTimeTrigger(moment=self.target_datetime, end_from_trigger=self.end_from_trigger)
+ if AIRFLOW_V_3_0_PLUS
Review Comment:
Indeed!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Test standard provider with Airflow 2.8 and 2.9 [airflow]
Posted by "gopidesupavan (via GitHub)" <gi...@apache.org>.
gopidesupavan commented on PR #43556:
URL: https://github.com/apache/airflow/pull/43556#issuecomment-2464468231
> Actually - really the thing is that that it was only working on 2.10 when ENABLE_AIP_44 was used, so we really should only enable it only for Airlfow 3+
Yes your correct. for airflow less thank 3 versions we can disable, currently by default its coming as true for all the versions.
I ran this in local ,
`breeze shell --use-airflow-version 2.8.4 --mount-sources providers-and-tests` and in the tests its coming as true.
raised change here: https://github.com/apache/airflow/pull/43818
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Test standard provider with Airflow 2.8 and 2.9 [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #43556:
URL: https://github.com/apache/airflow/pull/43556#issuecomment-2463475323
> alright got it where the failures coming from for this providers/tests/standard/operators/test_python.py::TestBranchExternalPythonOperator::test_use_airflow_context_touch_other_variables its acutally difference in the deserialisation between 2.8 and 2.10
Nice. Good job. So now we have to find out how this deserialization happened in 2.8/2.9 PythonVirtualenv. Let me take a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Test standard provider with Airflow 2.8 and 2.9 [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #43556:
URL: https://github.com/apache/airflow/pull/43556#issuecomment-2463487767
AH... Of course. Sending context was added in 3.0.0 :) . So the fact that it actually works on 2.10 is a bonus of new standard providers, but there should be no expectation it should work on 2.8 or 2.9 because it never worked there!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Test standard provider with Airflow 2.8 and 2.9 [airflow]
Posted by "gopidesupavan (via GitHub)" <gi...@apache.org>.
gopidesupavan commented on PR #43556:
URL: https://github.com/apache/airflow/pull/43556#issuecomment-2463502317
Happy to make changes, I believe only need some test fixes and use_airflow_context
Parameter checks between Versions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Test standard provider with Airflow 2.8 and 2.9 [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #43556:
URL: https://github.com/apache/airflow/pull/43556#issuecomment-2453556498
The fix here https://github.com/apache/airflow/pull/43617 allows to iterate fast on the "main providers" + "old airflow" case :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Test standard provider with Airflow 2.8 and 2.9 [airflow]
Posted by "gopidesupavan (via GitHub)" <gi...@apache.org>.
gopidesupavan commented on code in PR #43556:
URL: https://github.com/apache/airflow/pull/43556#discussion_r1827304576
##########
providers/tests/openlineage/utils/test_utils.py:
##########
@@ -43,14 +43,11 @@
from airflow.utils.task_group import TaskGroup
from airflow.utils.types import DagRunType
-from tests_common.test_utils.compat import AIRFLOW_V_2_10_PLUS, BashOperator, PythonOperator
+from tests_common.test_utils.compat import BashOperator, PythonOperator
from tests_common.test_utils.mock_operators import MockOperator
BASH_OPERATOR_PATH = "airflow.providers.standard.operators.bash"
PYTHON_OPERATOR_PATH = "airflow.providers.standard.operators.python"
-if not AIRFLOW_V_2_10_PLUS:
Review Comment:
Yes agree :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Test standard provider with Airflow 2.8 and 2.9 [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #43556:
URL: https://github.com/apache/airflow/pull/43556#issuecomment-2450666870
Ha.... so we are NOT good with standard provider for 2.8 and 2.9 YET
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Test standard provider with Airflow 2.8 and 2.9 [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #43556:
URL: https://github.com/apache/airflow/pull/43556#discussion_r1826954915
##########
providers/src/airflow/providers/standard/operators/python.py:
##########
@@ -187,7 +188,15 @@ def __init__(
def execute(self, context: Context) -> Any:
context_merge(context, self.op_kwargs, templates_dict=self.templates_dict)
self.op_kwargs = self.determine_kwargs(context)
- self._asset_events = context_get_outlet_events(context)
+
Review Comment:
@Lee-W @uranusjr (cc: @gopidesupavan ) -> can you please take a look? I think - by looking at the history of changes/matching them to released versions, I figured out how to implement "standard-provider" python to work with past versions of Airflow re assets/datasets - to support various renames that you implemented in the past
2.8, 2.9 -> no datasets/assets support
2.10.* (also 2.11 in the future) -> self._dataset_events = context_get_outlet_events(context)
3.0+ > self._asset_events = context_get_outlet_events(context)
There was also a rename of context_get_outlet_events (used to be named context_get_dataset_events) - but I believe it's never been relesed.
Could you please review and confirm?
Was there the _dataset_events support before 2.10.0 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Test standard provider with Airflow 2.8 and 2.9 [airflow]
Posted by "Lee-W (via GitHub)" <gi...@apache.org>.
Lee-W commented on code in PR #43556:
URL: https://github.com/apache/airflow/pull/43556#discussion_r1831922829
##########
providers/src/airflow/providers/standard/sensors/time.py:
##########
@@ -102,7 +119,9 @@ def __init__(
def execute(self, context: Context) -> NoReturn:
self.defer(
- trigger=DateTimeTrigger(moment=self.target_datetime, end_from_trigger=self.end_from_trigger),
+ trigger=DateTimeTrigger(moment=self.target_datetime, end_from_trigger=self.end_from_trigger)
+ if AIRFLOW_V_3_0_PLUS
Review Comment:
I thought it's 2_10_PLUS?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Test standard provider with Airflow 2.8 and 2.9 [airflow]
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on code in PR #43556:
URL: https://github.com/apache/airflow/pull/43556#discussion_r1841784583
##########
providers/src/airflow/providers/standard/__init__.py:
##########
@@ -15,3 +15,12 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
+from __future__ import annotations
+
+from packaging.version import Version
+
+from airflow import __version__ as airflow_version
+
+AIRFLOW_VERSION = Version(airflow_version)
+AIRFLOW_V_2_10_PLUS = Version(AIRFLOW_VERSION.base_version) >= Version("2.10.0")
+AIRFLOW_V_3_0_PLUS = Version(AIRFLOW_VERSION.base_version) >= Version("3.0.0")
Review Comment:
This will be overridden during release time as the provider `__init__` is generated from template.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Test standard provider with Airflow 2.8 and 2.9 [airflow]
Posted by "gopidesupavan (via GitHub)" <gi...@apache.org>.
gopidesupavan commented on PR #43556:
URL: https://github.com/apache/airflow/pull/43556#issuecomment-2463491363
> AH... Of course. Sending context was added in 3.0.0 :) . So the fact that it actually works on 2.10 is a bonus of new standard providers, but there should be no expectation it should work on 2.8 or 2.9 because it never worked there!
Yeah that's correct, should we make necessary changes to support it only for 2.10+
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Test standard provider with Airflow 2.8 and 2.9 [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #43556:
URL: https://github.com/apache/airflow/pull/43556#issuecomment-2466279211
@gopidesupavan - you can rebase and check yout #43818 now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org