You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "AlinsRan (via GitHub)" <gi...@apache.org> on 2023/08/01 05:39:53 UTC

[GitHub] [apisix] AlinsRan commented on a diff in pull request #9903: feat: support host level dynamic setting of tls protocol version

AlinsRan commented on code in PR #9903:
URL: https://github.com/apache/apisix/pull/9903#discussion_r1280130292


##########
apisix/init.lua:
##########
@@ -192,10 +211,16 @@ function _M.http_ssl_phase()
         if err then
             core.log.error("failed to fetch ssl config: ", err)
         end
+        core.log.error("failed to find any SSL certificate by SNI: ", sni)
         ngx_exit(-1)
     end
-end
 
+    ok ,err = apisix_ssl.set_protocols_by_clienthello(ngx_ctx.matched_ssl.value.ssl_protocols)

Review Comment:
   `api_ctx` has been released and should not be used.
   Can only be selected in `ngx_ctx` and `local variables`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org