You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/06/02 11:43:55 UTC
[GitHub] [ozone] nandakumar131 opened a new pull request, #3480: HDDS-6824. Revert changes made in proto.lock by HDDS-6768.
nandakumar131 opened a new pull request, #3480:
URL: https://github.com/apache/ozone/pull/3480
## What changes were proposed in this pull request?
Revert changes made in proto.lock by HDDS-6768
## What is the link to the Apache JIRA
HDDS-6824
## How was this patch tested?
Existing unit tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] nandakumar131 commented on a diff in pull request #3480: HDDS-6824. Revert changes made in proto.lock by HDDS-6768.
Posted by GitBox <gi...@apache.org>.
nandakumar131 commented on code in PR #3480:
URL: https://github.com/apache/ozone/pull/3480#discussion_r888767945
##########
hadoop-ozone/interface-client/src/main/proto/OmClientProtocol.proto:
##########
@@ -297,7 +299,8 @@ message OMResponse {
optional ListTrashResponse listTrashResponse = 91;
optional RecoverTrashResponse RecoverTrashResponse = 92;
- optional PurgeDirectoriesResponse purgeDirectoriesResponse = 93;
+ optional PurgePathsResponse purgePathsResponse = 93; // [deprecated = true]
Review Comment:
Fixed it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] rakeshadr commented on a diff in pull request #3480: HDDS-6824. Revert changes made in proto.lock by HDDS-6768.
Posted by GitBox <gi...@apache.org>.
rakeshadr commented on code in PR #3480:
URL: https://github.com/apache/ozone/pull/3480#discussion_r888826074
##########
hadoop-ozone/interface-client/src/main/proto/OmClientProtocol.proto:
##########
@@ -101,7 +101,8 @@ enum Type {
RevokeS3Secret = 93;
- PurgeDirectories = 94;
+ PurgePaths = 94; // [deprecated = true]
Review Comment:
@nandakumar131 I think, below test case will be happy, if we revert `case PurgePaths:` in OmUtils.java.
```
Error: org.apache.hadoop.ozone.om.ratis.TestOzoneManagerRatisServer.testIsReadOnlyCapturesAllCmdTypeEnums Time elapsed: 0.693 s <<< FAILURE!
java.lang.AssertionError: PurgePaths is not categorized in OmUtils#isReadyOnly
at org.junit.Assert.fail(Assert.java:89)
at org.junit.Assert.assertTrue(Assert.java:42)
at org.junit.Assert.assertFalse(Assert.java:65)
at org.apache.hadoop.ozone.om.ratis.TestOzoneManagerRatisServer.testIsReadOnlyCapturesAllCmdTypeEnums(TestOzoneManagerRatisServer.java:194)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] nandakumar131 merged pull request #3480: HDDS-6824. Revert changes made in proto.lock by HDDS-6768.
Posted by GitBox <gi...@apache.org>.
nandakumar131 merged PR #3480:
URL: https://github.com/apache/ozone/pull/3480
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] nandakumar131 commented on a diff in pull request #3480: HDDS-6824. Revert changes made in proto.lock by HDDS-6768.
Posted by GitBox <gi...@apache.org>.
nandakumar131 commented on code in PR #3480:
URL: https://github.com/apache/ozone/pull/3480#discussion_r888893108
##########
hadoop-ozone/interface-client/src/main/proto/OmClientProtocol.proto:
##########
@@ -101,7 +101,8 @@ enum Type {
RevokeS3Secret = 93;
- PurgeDirectories = 94;
+ PurgePaths = 94; // [deprecated = true]
Review Comment:
Fixed it. Thanks @rakeshadr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] nandakumar131 commented on a diff in pull request #3480: HDDS-6824. Revert changes made in proto.lock by HDDS-6768.
Posted by GitBox <gi...@apache.org>.
nandakumar131 commented on code in PR #3480:
URL: https://github.com/apache/ozone/pull/3480#discussion_r888767733
##########
hadoop-ozone/interface-client/src/main/proto/OmClientProtocol.proto:
##########
@@ -101,7 +101,8 @@ enum Type {
RevokeS3Secret = 93;
- PurgeDirectories = 94;
+ PurgePaths = 94; // [deprecated=true]
Review Comment:
deprecated keyword is not supported for enum in protobuf 2.5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] rakeshadr commented on a diff in pull request #3480: HDDS-6824. Revert changes made in proto.lock by HDDS-6768.
Posted by GitBox <gi...@apache.org>.
rakeshadr commented on code in PR #3480:
URL: https://github.com/apache/ozone/pull/3480#discussion_r888573067
##########
hadoop-ozone/interface-client/src/main/proto/OmClientProtocol.proto:
##########
@@ -101,7 +101,8 @@ enum Type {
RevokeS3Secret = 93;
- PurgeDirectories = 94;
+ PurgePaths = 94; // [deprecated=true]
Review Comment:
Any specific reason for commented out the statement. Should it be
`PurgePaths = 94 [deprecated=true];`
##########
hadoop-ozone/interface-client/src/main/proto/OmClientProtocol.proto:
##########
@@ -297,7 +299,8 @@ message OMResponse {
optional ListTrashResponse listTrashResponse = 91;
optional RecoverTrashResponse RecoverTrashResponse = 92;
- optional PurgeDirectoriesResponse purgeDirectoriesResponse = 93;
+ optional PurgePathsResponse purgePathsResponse = 93; // [deprecated = true]
Review Comment:
Here again the same as above. Should it be without comment line ?
I could see everywhere the deprecated line is commented out.
##########
hadoop-ozone/interface-client/src/main/proto/OmClientProtocol.proto:
##########
@@ -201,7 +202,8 @@ message OMRequest {
optional RevokeS3SecretRequest RevokeS3SecretRequest = 93;
- optional PurgeDirectoriesRequest purgeDirectoriesRequest = 94;
+ optional PurgePathsRequest purgePathsRequest = 94; // [deprecated = true]
Review Comment:
Here again the same as above. Should it be without comment line ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] rakeshadr commented on a diff in pull request #3480: HDDS-6824. Revert changes made in proto.lock by HDDS-6768.
Posted by GitBox <gi...@apache.org>.
rakeshadr commented on code in PR #3480:
URL: https://github.com/apache/ozone/pull/3480#discussion_r888826074
##########
hadoop-ozone/interface-client/src/main/proto/OmClientProtocol.proto:
##########
@@ -101,7 +101,8 @@ enum Type {
RevokeS3Secret = 93;
- PurgeDirectories = 94;
+ PurgePaths = 94; // [deprecated = true]
Review Comment:
@nandakumar131 I think, below test case will be happy, if we add `case PurgePaths:` in OmUtils.java.
```
Error: org.apache.hadoop.ozone.om.ratis.TestOzoneManagerRatisServer.testIsReadOnlyCapturesAllCmdTypeEnums Time elapsed: 0.693 s <<< FAILURE!
java.lang.AssertionError: PurgePaths is not categorized in OmUtils#isReadyOnly
at org.junit.Assert.fail(Assert.java:89)
at org.junit.Assert.assertTrue(Assert.java:42)
at org.junit.Assert.assertFalse(Assert.java:65)
at org.apache.hadoop.ozone.om.ratis.TestOzoneManagerRatisServer.testIsReadOnlyCapturesAllCmdTypeEnums(TestOzoneManagerRatisServer.java:194)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org