You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "xinyiZzz (via GitHub)" <gi...@apache.org> on 2023/11/23 07:57:42 UTC

[PR] [fix](memory) Fix thread_context check failed: thread_mem_tracker()->label() == "Orphan" [doris]

xinyiZzz opened a new pull request, #27468:
URL: https://github.com/apache/doris/pull/27468

   ## Proposed changes
   
   ```
   F1123 08:04:37.272737 754056 thread_context.h:169] Check failed: thread_mem_tracker()->label() == "Orphan" , attach mem tracker label: Query#Id=2d6d0263f4c84f95-a4c2c96307e78498
   *** Check failure stack trace: ***
       @     0x55a03307b4ed  google::LogMessage::Fail()
       @     0x55a03307da29  google::LogMessage::SendToLog()
       @     0x55a03307b056  google::LogMessage::Flush()
       @     0x55a03307e099  google::LogMessageFatal::~LogMessageFatal()
       @     0x55a01013a057  doris::ThreadContext::attach_task()
       @     0x55a0101354d8  doris::AttachTask::AttachTask()
       @     0x55a00fdb9981  doris::PlanFragmentExecutor::~PlanFragmentExecutor()
       @     0x55a00fba309d  doris::FragmentExecState::~FragmentExecState()
       @     0x55a00fba3192  std::_Sp_counted_ptr<>::_M_dispose()
       @     0x55a00ce78412  std::_Sp_counted_base<>::_M_release()
       @     0x55a00ce7814a  std::__shared_count<>::~__shared_count()
       @     0x55a00fbd493b  std::__shared_ptr<>::~__shared_ptr()
       @     0x55a00fb726b5  std::shared_ptr<>::~shared_ptr()
       @     0x55a00fb4ca9b  doris::FragmentMgr::cancel()
       @     0x55a00fdb4e44  doris::ThreadMemTrackerMgr::cancel_fragment()
       @     0x55a01f1ac4d7  Allocator<>::sys_memory_check()
       @     0x55a01f1afaf3  Allocator<>::memory_check()
       @     0x55a01f1b07b1  Allocator<>::alloc_impl()
       @     0x55a01f1b0537  Allocator<>::alloc()
   ```
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](memory) Fix thread_context check failed: thread_mem_tracker()->label() == "Orphan" [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27468:
URL: https://github.com/apache/doris/pull/27468#issuecomment-1824099152

   (From new machine)TeamCity pipeline, clickbench performance test result:
    the sum of best hot time: 44.05 seconds
    stream load tsv:          563 seconds loaded 74807831229 Bytes, about 126 MB/s
    stream load json:         18 seconds loaded 2358488459 Bytes, about 124 MB/s
    stream load orc:          65 seconds loaded 1101869774 Bytes, about 16 MB/s
    stream load parquet:          32 seconds loaded 861443392 Bytes, about 25 MB/s
    insert into select:          28.8 seconds inserted 10000000 Rows, about 347K ops/s
    storage size: 17098953655 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](memory) Fix thread_context check failed: thread_mem_tracker()->label() == "Orphan" [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27468:
URL: https://github.com/apache/doris/pull/27468#issuecomment-1824049543

   TeamCity be ut coverage result:
    Function Coverage: 36.58% (8449/23097) 
    Line Coverage: 28.87% (68677/237901)
    Region Coverage: 27.83% (35510/127600)
    Branch Coverage: 24.57% (18122/73756)
    Coverage Report: http://coverage.selectdb-in.cc/coverage/d03148319c12c7d250eab47dd7cc724fb79f5f60_d03148319c12c7d250eab47dd7cc724fb79f5f60/report/index.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](memory) Fix thread_context check failed: thread_mem_tracker()->label() == "Orphan" [doris]

Posted by "xinyiZzz (via GitHub)" <gi...@apache.org>.
xinyiZzz commented on PR #27468:
URL: https://github.com/apache/doris/pull/27468#issuecomment-1823987304

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](memory) Fix thread_context check failed: thread_mem_tracker()->label() == "Orphan" [doris]

Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #27468:
URL: https://github.com/apache/doris/pull/27468


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](memory) Fix thread_context check failed: thread_mem_tracker()->label() == "Orphan" [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27468:
URL: https://github.com/apache/doris/pull/27468#issuecomment-1823947070

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](memory) Fix thread_context check failed: thread_mem_tracker()->label() == "Orphan" [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27468:
URL: https://github.com/apache/doris/pull/27468#issuecomment-1825057259

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](memory) Fix thread_context check failed: thread_mem_tracker()->label() == "Orphan" [doris]

Posted by "xinyiZzz (via GitHub)" <gi...@apache.org>.
xinyiZzz commented on PR #27468:
URL: https://github.com/apache/doris/pull/27468#issuecomment-1823941352

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](memory) Fix thread_context check failed: thread_mem_tracker()->label() == "Orphan" [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27468:
URL: https://github.com/apache/doris/pull/27468#issuecomment-1824001512

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](memory) Fix thread_context check failed: thread_mem_tracker()->label() == "Orphan" [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27468:
URL: https://github.com/apache/doris/pull/27468#issuecomment-1824101536

   
   <details>
   <summary>TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'</summary>
   
   ```
   Tpch sf100 test result on commit d03148319c12c7d250eab47dd7cc724fb79f5f60, data reload: false
   
   run tpch-sf100 query with default conf and session variables
   q1	4918	4676	4664	4664
   q2	357	157	160	157
   q3	2057	1908	1882	1882
   q4	1402	1283	1256	1256
   q5	3940	3927	4049	3927
   q6	256	133	129	129
   q7	1426	886	877	877
   q8	2948	2783	2756	2756
   q9	9697	9533	9625	9533
   q10	3458	3539	3527	3527
   q11	372	252	246	246
   q12	432	286	291	286
   q13	4583	3821	3796	3796
   q14	326	295	284	284
   q15	579	538	517	517
   q16	661	577	605	577
   q17	1139	954	901	901
   q18	7866	7390	7448	7390
   q19	1652	1685	1671	1671
   q20	540	297	334	297
   q21	4421	3964	4020	3964
   q22	471	374	364	364
   Total cold run time: 53501 ms
   Total hot run time: 49001 ms
   
   run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
   q1	4567	4577	4575	4575
   q2	335	247	263	247
   q3	4047	4019	4011	4011
   q4	2717	2693	2696	2693
   q5	9723	9632	9679	9632
   q6	247	124	125	124
   q7	3016	2469	2512	2469
   q8	4464	4455	4465	4455
   q9	12920	12899	12954	12899
   q10	4077	4175	4172	4172
   q11	799	646	655	646
   q12	973	802	825	802
   q13	4297	3571	3552	3552
   q14	378	351	360	351
   q15	572	526	512	512
   q16	724	691	656	656
   q17	3883	3862	3937	3862
   q18	9562	8995	8988	8988
   q19	1813	1761	1775	1761
   q20	2395	2069	2049	2049
   q21	8867	8630	8675	8630
   q22	860	781	817	781
   Total cold run time: 81236 ms
   Total hot run time: 77867 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](memory) Fix thread_context check failed: thread_mem_tracker()->label() == "Orphan" [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27468:
URL: https://github.com/apache/doris/pull/27468#issuecomment-1825057278

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org