You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2018/01/08 19:10:55 UTC

[kudu-CR] KUDU-2236: use debug logging where appropriate

Hello Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/8961

to look at the new patch set (#2).

Change subject: KUDU-2236: use debug logging where appropriate
......................................................................

KUDU-2236: use debug logging where appropriate

The previous fixes for KUDU-2236 adjusted the test to ensure its success
when they should have instead addressed the regression in logging
behavior. I.e. testCloseShortlyAfterOpen() should not catch any scary
log messages because it itself isn't doing anything scary.

This patch addresses the fact that exception messages are spewed even
when we might expect them because a connection has been explicitly
closed. In such cases, DEBUG-level messages will be logged instead of
INFO- or WARN-level messages.

CapturingLogAppenders can now specify what log levels to read from, and
testCloseShortlyAfterOpen will now parse INFO-level messages or higher
(i.e. not DEBUG-level).

Change-Id: I780df2eeb51a14b65dd4283dfe9d4d6daf909661
---
M java/kudu-client/src/main/java/org/apache/kudu/client/ConnectToCluster.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Connection.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/util/CapturingLogAppender.java
4 files changed, 30 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/61/8961/2
-- 
To view, visit http://gerrit.cloudera.org:8080/8961
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I780df2eeb51a14b65dd4283dfe9d4d6daf909661
Gerrit-Change-Number: 8961
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins