[GitHub] [iceberg] aokolnychyi commented on a diff in pull request #4812: Spark 3.2: Support reading position deletes

[GitBox <gi...@apache.org>]

aokolnychyi commented on code in PR #4812:
URL: https://github.com/apache/iceberg/pull/4812#discussion_r887384420


##########
api/src/main/java/org/apache/iceberg/FileScanTask.java:
##########
@@ -26,15 +26,21 @@
  * A scan task over a range of a single file.
  */
 public interface FileScanTask extends ScanTask {
+
+  /**
+   * @return the file to scan
+   */
+  ContentFile<?> contentFile();

Review Comment:
   This PR raises a somehow similar question about the future of `FileScanTask` as in #4870. Maybe, we can discuss there a bit.
   
   Instead of adding a new method like `contentFile`, what about wrapping a delete file as `DataFile` and using the task without any changes?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org