You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2021/04/08 19:07:30 UTC
[GitHub] [trafficcontrol] mitchell852 opened a new issue #5724: PUT 3.x/servers with no xmppId (hashId) results in an internal server error
mitchell852 opened a new issue #5724:
URL: https://github.com/apache/trafficcontrol/issues/5724
## I'm submitting a ...
- bug report
## Traffic Control components affected ...
- Traffic Ops
## Current behavior:
PUT 3.x/servers with no xmppId (hashId) results in an internal server error
```
ERROR: api.go:209: 2021-04-08T18:39:19.577714586Z: 96.118.155.174:50696 original server had no XMPPID
```
## Expected behavior:
No ISE. You can't change xmppId after server create so i'm not even sure why the api is checking for one.
## Minimal reproduction of the problem with instructions:
Create a server, in the db, delete the xmppId.
PUT 3.x/servers/your-new-server-id and you should get a 500 Internal Server Error.
## Anything else:
Workaround: add an xmppId to the db for that server and the error goes away
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
https://apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] rawlinp commented on issue #5724: PUT /api/3.x/servers with no xmppId (hashId) results in an internal server error
Posted by GitBox <gi...@apache.org>.
rawlinp commented on issue #5724:
URL: https://github.com/apache/trafficcontrol/issues/5724#issuecomment-816087364
Yeah, I think the intent was to return an error to the user if they try to change a field that was made immutable. But in that case, the server update code should assume that a `nil` original XMPPID means that the original XMPPID is the server's `host_name` for comparison purposes.
Also, we should consider adding a DB migration to set nil/empty `xmpp_id` to `host_name`. That is what the CRConfig generation code basically does already.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] rawlinp closed issue #5724: PUT /api/3.x/servers with no xmppId (hashId) results in an internal server error
Posted by GitBox <gi...@apache.org>.
rawlinp closed issue #5724:
URL: https://github.com/apache/trafficcontrol/issues/5724
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org