You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/07/17 08:05:36 UTC
[GitHub] [iotdb] wangchao316 opened a new pull request #3556: fix test container error
wangchao316 opened a new pull request #3556:
URL: https://github.com/apache/iotdb/pull/3556
org.apache.thrift.TException: org.apache.iotdb.db.exception.metadata.MetadataException: The key tag1 is not a tag.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] LebronAl commented on pull request #3556: [IOTDB-1509] show timeseries throw a bug
Posted by GitBox <gi...@apache.org>.
LebronAl commented on pull request #3556:
URL: https://github.com/apache/iotdb/pull/3556#issuecomment-886313243
> Great Job~Finally we figured out what the problem was！
> Please add same logic for `showTimeseries` and some other similar method if there has in `CMManager`
Since the CI of master has been dead for a long time, I will merge this PR first. @wangchao316 will fix this review later this week.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #3556: fix test container error
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #3556:
URL: https://github.com/apache/iotdb/pull/3556#issuecomment-878899159
[](https://coveralls.io/builds/41447349)
Coverage decreased (-0.008%) to 68.163% when pulling **a4ef0de4cd4fd65e862d6cc622ef1e35eeb8cec5 on wangchao316:testfix** into **0147ec40145581b7a07a8a431c2043db501a45e9 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #3556: fix test container error
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #3556:
URL: https://github.com/apache/iotdb/pull/3556#issuecomment-878899159
[](https://coveralls.io/builds/41446971)
Coverage decreased (-0.05%) to 68.117% when pulling **8fd8b372c45fb2d519655514357e827c0423ebb3 on wangchao316:testfix** into **0147ec40145581b7a07a8a431c2043db501a45e9 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] LebronAl merged pull request #3556: [IOTDB-1509] show timeseries throw a bug
Posted by GitBox <gi...@apache.org>.
LebronAl merged pull request #3556:
URL: https://github.com/apache/iotdb/pull/3556
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] wangchao316 commented on pull request #3556: fix test container error
Posted by GitBox <gi...@apache.org>.
wangchao316 commented on pull request #3556:
URL: https://github.com/apache/iotdb/pull/3556#issuecomment-881854355
> > This error occurs because the creation sequence is not synchronized to the follower. As a result, the query sequence cannot be found. This problem is increasing timeout and requires additional sleep between creation and query.
>
> If we query the followers of the data group, should we synchronize with the leader of the data group?
no , we can add retry for this error. because this situation does not often
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #3556: fix test container error
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #3556:
URL: https://github.com/apache/iotdb/pull/3556#issuecomment-878899159
[](https://coveralls.io/builds/41447001)
Coverage decreased (-0.02%) to 68.151% when pulling **8fd8b372c45fb2d519655514357e827c0423ebb3 on wangchao316:testfix** into **0147ec40145581b7a07a8a431c2043db501a45e9 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #3556: fix test container error
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #3556:
URL: https://github.com/apache/iotdb/pull/3556#issuecomment-878899159
[](https://coveralls.io/builds/41447314)
Coverage decreased (-0.02%) to 68.149% when pulling **a4ef0de4cd4fd65e862d6cc622ef1e35eeb8cec5 on wangchao316:testfix** into **0147ec40145581b7a07a8a431c2043db501a45e9 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #3556: fix test container error
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #3556:
URL: https://github.com/apache/iotdb/pull/3556#issuecomment-878899159
[](https://coveralls.io/builds/41447145)
Coverage decreased (-0.02%) to 68.151% when pulling **a4ef0de4cd4fd65e862d6cc622ef1e35eeb8cec5 on wangchao316:testfix** into **0147ec40145581b7a07a8a431c2043db501a45e9 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] neuyilan edited a comment on pull request #3556: fix test container error
Posted by GitBox <gi...@apache.org>.
neuyilan edited a comment on pull request #3556:
URL: https://github.com/apache/iotdb/pull/3556#issuecomment-878945388
> This error occurs because the creation sequence is not synchronized to the follower.
Yeah, I know, but how long does it take for the follower to synchronize the leader? Is it affected by the state of the virtual machine where the follower is located? After all, our tests are all in the cloud environment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] LebronAl commented on pull request #3556: [IOTDB-1509] show timeseries throw a bug
Posted by GitBox <gi...@apache.org>.
LebronAl commented on pull request #3556:
URL: https://github.com/apache/iotdb/pull/3556#issuecomment-884953521
ping, any updates?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] neuyilan commented on pull request #3556: fix test container error
Posted by GitBox <gi...@apache.org>.
neuyilan commented on pull request #3556:
URL: https://github.com/apache/iotdb/pull/3556#issuecomment-878945388
> This error occurs because the creation sequence is not synchronized to the follower.
Yeah, I know, but how long does it take for the follower to synchronize the leader? Is it affected by the state of the virtual machine where the follower is located? After all, our tests are all in the cloud environment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #3556: fix test container error
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #3556:
URL: https://github.com/apache/iotdb/pull/3556#issuecomment-878899159
[](https://coveralls.io/builds/41320467)
Coverage decreased (-0.04%) to 68.134% when pulling **b860ed1d6f322a4659e52c918965b2b335df4ef3 on wangchao316:testfix** into **0147ec40145581b7a07a8a431c2043db501a45e9 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] wangchao316 commented on pull request #3556: fix test container error
Posted by GitBox <gi...@apache.org>.
wangchao316 commented on pull request #3556:
URL: https://github.com/apache/iotdb/pull/3556#issuecomment-878940106
> I think this is just one probability problem :), when one docker container or VM stop more than the time you set, it still fails :)
> so... I still do not know whether is there a better solution.....
this pr is sloved for next error:
org.apache.thrift.TException: org.apache.iotdb.db.exception.metadata.MetadataException: The key tag1 is not a tag.
This error occurs because the creation sequence is not synchronized to the follower. As a result, the query sequence cannot be found. This problem is increasing timeout and requires additional sleep between creation and query.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #3556: fix test container error
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #3556:
URL: https://github.com/apache/iotdb/pull/3556#issuecomment-878899159
[](https://coveralls.io/builds/41447360)
Coverage decreased (-0.04%) to 68.132% when pulling **a4ef0de4cd4fd65e862d6cc622ef1e35eeb8cec5 on wangchao316:testfix** into **0147ec40145581b7a07a8a431c2043db501a45e9 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] LebronAl commented on pull request #3556: fix test container error
Posted by GitBox <gi...@apache.org>.
LebronAl commented on pull request #3556:
URL: https://github.com/apache/iotdb/pull/3556#issuecomment-880020619
> This error occurs because the creation sequence is not synchronized to the follower. As a result, the query sequence cannot be found. This problem is increasing timeout and requires additional sleep between creation and query.
If we query the followers of the data group, should we synchronize with the leader of the data group?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] wangchao316 commented on a change in pull request #3556: fix test container error
Posted by GitBox <gi...@apache.org>.
wangchao316 commented on a change in pull request #3556:
URL: https://github.com/apache/iotdb/pull/3556#discussion_r671666239
##########
File path: cluster/src/main/java/org/apache/iotdb/cluster/metadata/CMManager.java
##########
@@ -1565,7 +1565,7 @@ public MNode getMNode(MNode deviceMNode, String measurementName) {
() -> {
try {
showTimeseries(group, plan, resultSet, context);
- } catch (CheckConsistencyException e) {
+ } catch (CheckConsistencyException | MetadataException e) {
Review comment:
The show timeseries root... command is used to query all DataGroup groups. If a DataGroup group does not have a sequence, an error is reported. As a result, other DataGroups that have a sequence cannot obtain the result.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls commented on pull request #3556: fix test container error
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #3556:
URL: https://github.com/apache/iotdb/pull/3556#issuecomment-878899159
[](https://coveralls.io/builds/41320042)
Coverage decreased (-0.02%) to 68.153% when pulling **b860ed1d6f322a4659e52c918965b2b335df4ef3 on wangchao316:testfix** into **0147ec40145581b7a07a8a431c2043db501a45e9 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] wangchao316 closed pull request #3556: fix test container error
Posted by GitBox <gi...@apache.org>.
wangchao316 closed pull request #3556:
URL: https://github.com/apache/iotdb/pull/3556
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org