You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by viirya <gi...@git.apache.org> on 2018/04/13 13:07:57 UTC
[GitHub] spark pull request #21065: [SPARK-23979][SQL] MultiAlias should not be a Cod...
GitHub user viirya opened a pull request:
https://github.com/apache/spark/pull/21065
[SPARK-23979][SQL] MultiAlias should not be a CodegenFallback
## What changes were proposed in this pull request?
Just found `MultiAlias` is a `CodegenFallback`. It should not be as looks like `MultiAlias` won't be evaluated.
## How was this patch tested?
Existing tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/viirya/spark-1 multialias-without-codegenfallback
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/21065.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #21065
----
commit 05a57cbeaba9294ba55c4cc1bf9b782b86eb8770
Author: Liang-Chi Hsieh <vi...@...>
Date: 2018-04-13T13:00:21Z
MultiAlias should not be a CodegenFallback.
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21065: [SPARK-23979][SQL] MultiAlias should not be a CodegenFal...
Posted by viirya <gi...@git.apache.org>.
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21065
cc @cloud-fan @hvanhovell
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21065: [SPARK-23979][SQL] MultiAlias should not be a CodegenFal...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21065
**[Test build #89341 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89341/testReport)** for PR 21065 at commit [`05a57cb`](https://github.com/apache/spark/commit/05a57cbeaba9294ba55c4cc1bf9b782b86eb8770).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21065: [SPARK-23979][SQL] MultiAlias should not be a CodegenFal...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21065
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89341/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21065: [SPARK-23979][SQL] MultiAlias should not be a CodegenFal...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21065
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21065: [SPARK-23979][SQL] MultiAlias should not be a CodegenFal...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21065
**[Test build #89341 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89341/testReport)** for PR 21065 at commit [`05a57cb`](https://github.com/apache/spark/commit/05a57cbeaba9294ba55c4cc1bf9b782b86eb8770).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21065: [SPARK-23979][SQL] MultiAlias should not be a CodegenFal...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21065
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2318/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21065: [SPARK-23979][SQL] MultiAlias should not be a CodegenFal...
Posted by cloud-fan <gi...@git.apache.org>.
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21065
LGTM, merging to master!
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21065: [SPARK-23979][SQL] MultiAlias should not be a CodegenFal...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21065
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #21065: [SPARK-23979][SQL] MultiAlias should not be a Cod...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/21065
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org