[jira] [Commented] (OFBIZ-5255) Error in fieldlookup.js

["Jacques Le Roux (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-5255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13698285#comment-13698285 ] 

Jacques Le Roux commented on OFBIZ-5255:
----------------------------------------

This could be related with the quirk I identified in my 1st comment at OFBIZ-5211, we could indeed fix it in releases (this line dates from the JQuery branch merge 2,5 yeard ago), I have to check...
                
> Error in fieldlookup.js
> -----------------------
>
>                 Key: OFBIZ-5255
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5255
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ALL APPLICATIONS
>    Affects Versions: Release Branch 12.04
>         Environment: All
>            Reporter: Skip Dever
>            Priority: Minor
>
> On line 221 in fieldlookup.js is the statement:
> if (ajaxurl != "" && showDescription != "")
> This logic is incorrect because showDescription is normally a boolean and if you pass showDescription="false" to the macro, showDescription != "" evaluates to false.
> I am not sure what the author was trying to test for, but I modified it to either comment out showDescription != "", or change it to:
> if (ajaxurl != "" && !(showDescription === ""))
> The author needs to test this with a macro that passes showDescription="false".  For example, in ordermgr\entry\checkinits.ftl, modify line 104 and add showDescription="false" as a macro argument.  
> Doing so will disable the autocompletion until a modification is made to fieldlookup.js as above.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira