You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@weex.apache.org by gubaojian <gi...@git.apache.org> on 2017/10/09 11:21:10 UTC
[GitHub] incubator-weex pull request #774: fix scroll to bug and add md5 for template
GitHub user gubaojian opened a pull request:
https://github.com/apache/incubator-weex/pull/774
fix scroll to bug and add md5 for template
1、record md5 when js execute exception
2、fix scroll to element not scroll when none scroll action
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gubaojian/incubator-weex release-0.16
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-weex/pull/774.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #774
----
commit 5e85cea995793180ff4cd0f3cd2d72f188ad75f7
Author: jianbai.gbj <ji...@alibaba-inc.com>
Date: 2017-10-09T11:19:33Z
fix scroll to bug and add md5 for template
----
---
[GitHub] incubator-weex pull request #774: fix scroll to bug and add md5 for template
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-weex/pull/774
---
[GitHub] incubator-weex pull request #774: fix scroll to bug and add md5 for template
Posted by YorkShen <gi...@git.apache.org>.
Github user YorkShen commented on a diff in the pull request:
https://github.com/apache/incubator-weex/pull/774#discussion_r143443048
--- Diff: android/sdk/src/main/java/com/taobao/weex/utils/WXFileUtils.java ---
@@ -130,4 +134,26 @@ public static boolean saveFile(String path, byte[] content, Context context) {
}
return false;
}
+
+ public static String md5(String template){
+ try {
+ if(template == null){
+ return "";
+ }
+ return md5(template.getBytes("UTF-8"));
+ } catch (UnsupportedEncodingException e) {
+ return "";
+ }
+ }
+
+ public static String md5(byte[] bts){
+ try {
+ MessageDigest digest = MessageDigest.getInstance("MD5");
+ digest.update(bts);
+ BigInteger bigInt = new BigInteger(1, digest.digest());
--- End diff --
Using new String(byte []) is a better choice.
---
[GitHub] incubator-weex issue #774: fix scroll to bug and add md5 for template
Posted by liweiting <gi...@git.apache.org>.
Github user liweiting commented on the issue:
https://github.com/apache/incubator-weex/pull/774
点个赞
---
[GitHub] incubator-weex issue #774: fix scroll to bug and add md5 for template
Posted by weex-bot <gi...@git.apache.org>.
Github user weex-bot commented on the issue:
https://github.com/apache/incubator-weex/pull/774
<!--
0 failure:
0 warning:
2 messages
-->
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Messages</th>
</tr>
</thead>
<tbody><tr>
<td>:book:</td>
<td>has no jsfm file changed.</td>
</tr>
<tr>
<td>:book:</td>
<td>jsfm test finished.</td>
</tr>
</tbody>
</table>
<p align="right">
Generated by :no_entry_sign: <a href="http://github.com/danger/danger-js/">dangerJS</a>
</p>
---