[jira] [Commented] (CAMEL-10573) Align FallbackTypeConverter loading in OSGI environments

["Christian Schneider (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CAMEL-10573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15864083#comment-15864083 ] 

Christian Schneider commented on CAMEL-10573:
---------------------------------------------

I think the commit 05ba679d3906528cb is causing a severe issue with the activemq-camel component (AMQ-6597). The BundleComponentResolver seems to detect the activemq component inside the activemq-osgi bundle. This causes the activemq component to not work at all.

The issue seems to be caused by removing the test for a matching class:
                            if (test.matches(clazz)) {
                                classes.add(clazz);
                            }

After all though loading the foreign class is the problem in the first place. As activemq OSGi has DynamicImport-Package * it will be able to load all classes in the OSGi system and will create a wiring to the classes package. 
I will create a separate issue to track and solve this problem.

> Align FallbackTypeConverter loading in OSGI environments
> --------------------------------------------------------
>
>                 Key: CAMEL-10573
>                 URL: https://issues.apache.org/jira/browse/CAMEL-10573
>             Project: Camel
>          Issue Type: Bug
>          Components: karaf, osgi
>            Reporter: John Poth
>            Assignee: John Poth
>             Fix For: 2.18.2, 2.19.0
>
>
> In a OSGI environment only, FallBackTypeConverters are [required|https://github.com/apache/camel/blob/d5f0aefdffc74ac0971b87946a21fe4be8c305b4/camel-core/src/main/java/org/apache/camel/impl/osgi/Activator.java#L428] to be annotated with @Converter whereas otherwise they are [not|https://github.com/apache/camel/blob/00fef5857c0bcb0fc7a02f19f5ba51ef0382133d/camel-core/src/main/java/org/apache/camel/impl/converter/AnnotationTypeConverterLoader.java#L170].
> This causes [camel-jackson's|https://github.com/apache/camel/blob/2b4b9df67da4b84cb69d9dd42ef77155a803679a/components/camel-jackson/src/main/java/org/apache/camel/component/jackson/converter/JacksonTypeConverters.java] FallbackTypeConverter to not be loaded and a 'NoTypeConversionAvailableException' will be thrown. 
> I will provide a PR.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)