You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/02/24 01:01:56 UTC

[GitHub] [airflow] kaxil opened a new pull request #7519: [AIRFLOW-6895] AzureFileShareHook: Move DB call out of __init__

kaxil opened a new pull request #7519: [AIRFLOW-6895] AzureFileShareHook: Move DB call out of __init__
URL: https://github.com/apache/airflow/pull/7519
 
 
   Currently, the Azure client is created in AzureFileShareHook.__init__ . This gets connection data from DB.
   
   
   
   ---
   Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
   
   Make sure to mark the boxes below before creating PR: [x]
   
   - [x] Description above provides context of the change
   - [x] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
   - [x] Unit tests coverage for changes (not needed for documentation changes)
   - [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
   - [x] Relevant documentation is updated including usage instructions.
   - [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   <sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io commented on issue #7519: [AIRFLOW-6895] AzureFileShareHook: Move DB call out of __init__

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #7519: [AIRFLOW-6895] AzureFileShareHook: Move DB call out of __init__
URL: https://github.com/apache/airflow/pull/7519#issuecomment-590319172
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7519?src=pr&el=h1) Report
   > Merging [#7519](https://codecov.io/gh/apache/airflow/pull/7519?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/305053cb7c72220fbe32e4fab7cb1da49d5a14e2?src=pr&el=desc) will **decrease** coverage by `0.28%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7519/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7519?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #7519      +/-   ##
   ==========================================
   - Coverage   86.81%   86.52%   -0.29%     
   ==========================================
     Files         893      893              
     Lines       42186    42210      +24     
   ==========================================
   - Hits        36622    36522     -100     
   - Misses       5564     5688     +124
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7519?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...providers/microsoft/azure/hooks/azure\_fileshare.py](https://codecov.io/gh/apache/airflow/pull/7519/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbWljcm9zb2Z0L2F6dXJlL2hvb2tzL2F6dXJlX2ZpbGVzaGFyZS5weQ==) | `100% <100%> (ø)` | :arrow_up: |
   | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7519/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7519/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7519/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `47.18% <0%> (-45.08%)` | :arrow_down: |
   | [...viders/cncf/kubernetes/operators/kubernetes\_pod.py](https://codecov.io/gh/apache/airflow/pull/7519/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvY25jZi9rdWJlcm5ldGVzL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZC5weQ==) | `69.69% <0%> (-25.21%)` | :arrow_down: |
   | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7519/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | [airflow/www/views.py](https://codecov.io/gh/apache/airflow/pull/7519/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvdmlld3MucHk=) | `76.19% <0%> (-0.1%)` | :arrow_down: |
   | [airflow/executors/kubernetes\_executor.py](https://codecov.io/gh/apache/airflow/pull/7519/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMva3ViZXJuZXRlc19leGVjdXRvci5weQ==) | `56.8% <0%> (ø)` | :arrow_up: |
   | [airflow/kubernetes/pod\_generator.py](https://codecov.io/gh/apache/airflow/pull/7519/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9nZW5lcmF0b3IucHk=) | `96.51% <0%> (+0.01%)` | :arrow_up: |
   | [...flow/providers/google/cloud/operators/cloud\_sql.py](https://codecov.io/gh/apache/airflow/pull/7519/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL29wZXJhdG9ycy9jbG91ZF9zcWwucHk=) | `84.68% <0%> (+0.06%)` | :arrow_up: |
   | ... and [2 more](https://codecov.io/gh/apache/airflow/pull/7519/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7519?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7519?src=pr&el=footer). Last update [305053c...ec319ee](https://codecov.io/gh/apache/airflow/pull/7519?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] dimberman merged pull request #7519: [AIRFLOW-6895] AzureFileShareHook: Move DB call out of __init__

Posted by GitBox <gi...@apache.org>.
dimberman merged pull request #7519: [AIRFLOW-6895] AzureFileShareHook: Move DB call out of __init__
URL: https://github.com/apache/airflow/pull/7519
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services