You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@superset.apache.org by GitBox <gi...@apache.org> on 2018/02/11 03:10:40 UTC

[GitHub] mistercrunch commented on a change in pull request #4389: [geo] introduce "Auto Zoom" control

mistercrunch commented on a change in pull request #4389: [geo] introduce "Auto Zoom" control
URL: https://github.com/apache/incubator-superset/pull/4389#discussion_r167418260
 
 

 ##########
 File path: superset/assets/javascripts/chart/Chart.jsx
 ##########
 @@ -188,6 +188,7 @@ class Chart extends React.PureComponent {
       });
       this.props.actions.chartRenderingSucceeded(this.props.chartKey);
     } catch (e) {
+      console.error(e);  // eslint-disable-line
 
 Review comment:
   I was thinking about keeping that one around (that's why I silenced the linter). This gives us a stack trace instead of swallowing errors happening in the visualizations. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services