[GitHub] [echarts] jiawulin001 commented on a diff in pull request #16861: fix: markArea display filter correction

[GitBox <gi...@apache.org>]

jiawulin001 commented on code in PR #16861:
URL: https://github.com/apache/echarts/pull/16861#discussion_r849406769


##########
src/coord/cartesian/Cartesian2D.ts:
##########
@@ -105,6 +106,18 @@ class Cartesian2D extends Cartesian<Axis2D> implements CoordinateSystem {
             && this.getAxis('y').containData(data[1]);
     }
 
+    containZone(data1: ScaleDataValue[], data2: ScaleDataValue[]): boolean {
+        const zoneCorner1 = this.dataToPoint(data1);
+        const zoneCorner2 = this.dataToPoint(data2);
+        const area = this.getArea();
+        return rectRectIntersect(

Review Comment:
   Thank you for pointing that out! BoundingRect.intersect in use now!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org