You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/09 13:39:38 UTC

[GitHub] [airflow] mik-laj opened a new pull request #12948: Clean up redirects.txt

mik-laj opened a new pull request #12948:
URL: https://github.com/apache/airflow/pull/12948


   Hello,
   
   In Airflow 2.0, we are missing a few more files, but I will redirect them with .htaccess, because these will be moved between different documentation packages.
   ```
   ./executor/mesos.html
   ./howto/connection/aws.html
   ./howto/connection/gcp.html
   ./howto/connection/gcp_sql.html
   ./howto/connection/grpc.html
   ./howto/connection/index.html
   ./howto/connection/mysql.html
   ./howto/connection/oracle.html
   ./howto/connection/postgres.html
   ./howto/connection/ssh.html
   ./howto/operator/dingding.html
   ./howto/operator/gcp/bigtable.html
   ./howto/operator/gcp/cloud_build.html
   ./howto/operator/gcp/compute.html
   ./howto/operator/gcp/function.html
   ./howto/operator/gcp/gcs.html
   ./howto/operator/gcp/gcs_to_gdrive.html
   ./howto/operator/gcp/index.html
   ./howto/operator/gcp/natural_language.html
   ./howto/operator/gcp/spanner.html
   ./howto/operator/gcp/speech.html
   ./howto/operator/gcp/sql.html
   ./howto/operator/gcp/transfer.html
   ./howto/operator/gcp/translate-speech.html
   ./howto/operator/gcp/translate.html
   ./howto/operator/gcp/video.html
   ./howto/operator/gcp/vision.html
   ./howto/operator/papermill.html
   ./profiling.html
   ```
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj edited a comment on pull request #12948: Clean up redirects.txt

Posted by GitBox <gi...@apache.org>.
mik-laj edited a comment on pull request #12948:
URL: https://github.com/apache/airflow/pull/12948#issuecomment-741827633


   @ashb That would be good, but we can also do it in "post production".


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ashb commented on a change in pull request #12948: Clean up redirects.txt

Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #12948:
URL: https://github.com/apache/airflow/pull/12948#discussion_r539323045



##########
File path: docs/apache-airflow/redirects.txt
##########
@@ -15,68 +15,15 @@
 # specific language governing permissions and limitations
 # under the License.
 
-# New URL for Google Guide index
-howto/operator/gcp/index.rst howto/operator/google/index.rst
-# New URLs for Google Guides
-howto/operator/gcp/ads.rst howto/operator/google/ads.rst

Review comment:
       Nice one!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj commented on a change in pull request #12948: Clean up redirects.txt

Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #12948:
URL: https://github.com/apache/airflow/pull/12948#discussion_r539322471



##########
File path: docs/apache-airflow/redirects.txt
##########
@@ -15,68 +15,15 @@
 # specific language governing permissions and limitations
 # under the License.
 
-# New URL for Google Guide index
-howto/operator/gcp/index.rst howto/operator/google/index.rst
-# New URLs for Google Guides
-howto/operator/gcp/ads.rst howto/operator/google/ads.rst

Review comment:
       > In Airflow 2.0, we are missing a few more files, but I will redirect them with .htaccess, because these files are moved between different documentation packages.
   
   I'm working on it now.
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj commented on a change in pull request #12948: Clean up redirects.txt

Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #12948:
URL: https://github.com/apache/airflow/pull/12948#discussion_r539322987



##########
File path: docs/apache-airflow/redirects.txt
##########
@@ -15,68 +15,15 @@
 # specific language governing permissions and limitations
 # under the License.
 
-# New URL for Google Guide index
-howto/operator/gcp/index.rst howto/operator/google/index.rst
-# New URLs for Google Guides
-howto/operator/gcp/ads.rst howto/operator/google/ads.rst

Review comment:
       <img width="1382" alt="Screenshot 2020-12-09 at 14 52 18" src="https://user-images.githubusercontent.com/12058428/101638283-28105e00-3a2e-11eb-8634-cc56efba65f9.png">
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ashb commented on pull request #12948: Clean up redirects.txt

Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #12948:
URL: https://github.com/apache/airflow/pull/12948#issuecomment-741824060


   @mik-laj Do you want this in before we cut 2.0.0rc1 (i.e. for 2.0.0 docs build if we do it "properly")?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ashb commented on a change in pull request #12948: Clean up redirects.txt

Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #12948:
URL: https://github.com/apache/airflow/pull/12948#discussion_r539321328



##########
File path: docs/apache-airflow/redirects.txt
##########
@@ -15,68 +15,15 @@
 # specific language governing permissions and limitations
 # under the License.
 
-# New URL for Google Guide index
-howto/operator/gcp/index.rst howto/operator/google/index.rst
-# New URLs for Google Guides
-howto/operator/gcp/ads.rst howto/operator/google/ads.rst

Review comment:
       What happens if someone navigates to `/docs/stable/howto/operator/google/ads.html` -- can we redirect that to the stable version of the new provider?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj commented on a change in pull request #12948: Clean up redirects.txt

Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #12948:
URL: https://github.com/apache/airflow/pull/12948#discussion_r539343157



##########
File path: docs/apache-airflow/redirects.txt
##########
@@ -15,68 +15,16 @@
 # specific language governing permissions and limitations
 # under the License.
 
-# New URL for Google Guide index
-howto/operator/gcp/index.rst howto/operator/google/index.rst
-# New URLs for Google Guides
-howto/operator/gcp/ads.rst howto/operator/google/ads.rst
-howto/operator/gcp/analytics.rst howto/operator/google/marketing_platform/analytics.rst
-howto/operator/gcp/automl.rst howto/operator/google/cloud/automl.rst
-howto/operator/gcp/bigquery.rst howto/operator/google/cloud/bigquery.rst
-howto/operator/gcp/bigquery_dts.rst howto/operator/google/cloud/bigquery_dts.rst
-howto/operator/gcp/bigtable.rst howto/operator/google/cloud/bigtable.rst
-howto/operator/gcp/campaign_manager.rst howto/operator/google/marketing_platform/campaign_manager.rst
-howto/operator/gcp/cloud_build.rst howto/operator/google/cloud/cloud_build.rst
-howto/operator/gcp/cloud_memorystore.rst howto/operator/google/cloud/cloud_memorystore.rst
-howto/operator/gcp/cloud_sql.rst howto/operator/google/cloud/cloud_sql.rst
-howto/operator/gcp/cloud_storage_transfer_service.rst howto/operator/google/cloud/cloud_storage_transfer_service.rst
-howto/operator/gcp/compute.rst howto/operator/google/cloud/compute.rst
-howto/operator/gcp/datacatalog.rst howto/operator/google/cloud/datacatalog.rst
-howto/operator/gcp/datafusion.rst howto/operator/google/cloud/datafusion.rst
-howto/operator/gcp/dataproc.rst howto/operator/google/cloud/dataproc.rst
-howto/operator/gcp/display_video.rst howto/operator/google/marketing_platform/display_video.rst
-howto/operator/gcp/facebook_ads_to_gcs.rst howto/operator/google/transfer/facebook_ads_to_gcs.rst
-howto/operator/gcp/firestore.rst howto/operator/google/firebase/firestore.rst
-howto/operator/gcp/functions.rst howto/operator/google/cloud/functions.rst
-howto/operator/gcp/gcs.rst howto/operator/google/cloud/gcs.rst
-howto/operator/gcp/gcs_to_gcs.rst howto/operator/google/transfer/gcs_to_gcs.rst
-howto/operator/gcp/gcs_to_gdrive.rst howto/operator/google/transfer/gcs_to_gdrive.rst
-howto/operator/gcp/gcs_to_local.rst howto/operator/google/transfer/gcs_to_local.rst
-howto/operator/gcp/gcs_to_sftp.rst howto/operator/google/transfer/gcs_to_sftp.rst
-howto/operator/gcp/gcs_to_sheets.rst howto/operator/google/transfer/gcs_to_sheets.rst
-howto/operator/gcp/index.rst howto/operator/google/cloud/index.rst
-howto/operator/gcp/kubernetes_engine.rst howto/operator/google/cloud/kubernetes_engine.rst
-howto/operator/gcp/life_sciences.rst howto/operator/google/cloud/life_sciences.rst
-howto/operator/gcp/local_to_gcs.rst howto/operator/google/transfer/local_to_gcs.rst
-howto/operator/gcp/natural_language.rst howto/operator/google/cloud/natural_language.rst
-howto/operator/gcp/presto_to_gcs.rst howto/operator/google/transfer/presto_to_gcs.rst
-howto/operator/gcp/pubsub.rst howto/operator/google/cloud/pubsub.rst
-howto/operator/gcp/search_ads.rst howto/operator/google/marketing_platform/search_ads.rst
-howto/operator/gcp/sftp_to_gcs.rst howto/operator/google/transfer/sftp_to_gcs.rst
-howto/operator/gcp/sheets.rst howto/operator/google/suite/sheets.rst
-howto/operator/gcp/sheets_to_gcs.rst howto/operator/google/transfer/sheets_to_gcs.rst
-howto/operator/gcp/spanner.rst howto/operator/google/cloud/spanner.rst
-howto/operator/gcp/speech_to_text.rst howto/operator/google/cloud/speech_to_text.rst
-howto/operator/gcp/stackdriver.rst howto/operator/google/cloud/stackdriver.rst
-howto/operator/gcp/text_to_speech.rst howto/operator/google/cloud/text_to_speech.rst
-howto/operator/gcp/translate.rst howto/operator/google/cloud/translate.rst
-howto/operator/gcp/translate_speech.rst howto/operator/google/cloud/translate_speech.rst
-howto/operator/gcp/video_intelligence.rst howto/operator/google/cloud/video_intelligence.rst
-howto/operator/gcp/vision.rst howto/operator/google/cloud/vision.rst
-
-# New URLs for CLI references
-cli-ref.rst cli-and-env-variables-ref.rst
-
-# Departments without a separate index yet
-howto/operator/google/suite/index.rst howto/operator/google/index.rst
-howto/operator/google/firebase/index.rst howto/operator/google/index.rst
-
-# Other operators guide redirects
-howto/operator/http/http.rst howto/operator/http.rst
-howto/operator/http/index.rst howto/operator/http.rst
-
 # Security
 howto/use-alternative-secrets-backend.rst security/secrets/secrets-backend/index.rst
 security.rst security/index.rst
+
+# Operators guides
+howto/operator/external.html howto/operator/external_task_sensor.rst

Review comment:
       Good point. Fixed.

##########
File path: docs/apache-airflow/redirects.txt
##########
@@ -15,68 +15,15 @@
 # specific language governing permissions and limitations
 # under the License.
 
-# New URL for Google Guide index
-howto/operator/gcp/index.rst howto/operator/google/index.rst
-# New URLs for Google Guides
-howto/operator/gcp/ads.rst howto/operator/google/ads.rst

Review comment:
       PR: https://github.com/apache/airflow-site/pull/341




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ashb commented on pull request #12948: Clean up redirects.txt

Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #12948:
URL: https://github.com/apache/airflow/pull/12948#issuecomment-741840330


   @mik-laj Merge this PR when you are happy with it. CI is slow, so don't wait for it.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj commented on pull request #12948: Clean up redirects.txt

Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #12948:
URL: https://github.com/apache/airflow/pull/12948#issuecomment-741827633


   @ashb That would be helpful, but we can also do it in "post production".


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj merged pull request #12948: Clean up redirects.txt

Posted by GitBox <gi...@apache.org>.
mik-laj merged pull request #12948:
URL: https://github.com/apache/airflow/pull/12948


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] kaxil commented on a change in pull request #12948: Clean up redirects.txt

Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #12948:
URL: https://github.com/apache/airflow/pull/12948#discussion_r539341010



##########
File path: docs/apache-airflow/redirects.txt
##########
@@ -15,68 +15,16 @@
 # specific language governing permissions and limitations
 # under the License.
 
-# New URL for Google Guide index
-howto/operator/gcp/index.rst howto/operator/google/index.rst
-# New URLs for Google Guides
-howto/operator/gcp/ads.rst howto/operator/google/ads.rst
-howto/operator/gcp/analytics.rst howto/operator/google/marketing_platform/analytics.rst
-howto/operator/gcp/automl.rst howto/operator/google/cloud/automl.rst
-howto/operator/gcp/bigquery.rst howto/operator/google/cloud/bigquery.rst
-howto/operator/gcp/bigquery_dts.rst howto/operator/google/cloud/bigquery_dts.rst
-howto/operator/gcp/bigtable.rst howto/operator/google/cloud/bigtable.rst
-howto/operator/gcp/campaign_manager.rst howto/operator/google/marketing_platform/campaign_manager.rst
-howto/operator/gcp/cloud_build.rst howto/operator/google/cloud/cloud_build.rst
-howto/operator/gcp/cloud_memorystore.rst howto/operator/google/cloud/cloud_memorystore.rst
-howto/operator/gcp/cloud_sql.rst howto/operator/google/cloud/cloud_sql.rst
-howto/operator/gcp/cloud_storage_transfer_service.rst howto/operator/google/cloud/cloud_storage_transfer_service.rst
-howto/operator/gcp/compute.rst howto/operator/google/cloud/compute.rst
-howto/operator/gcp/datacatalog.rst howto/operator/google/cloud/datacatalog.rst
-howto/operator/gcp/datafusion.rst howto/operator/google/cloud/datafusion.rst
-howto/operator/gcp/dataproc.rst howto/operator/google/cloud/dataproc.rst
-howto/operator/gcp/display_video.rst howto/operator/google/marketing_platform/display_video.rst
-howto/operator/gcp/facebook_ads_to_gcs.rst howto/operator/google/transfer/facebook_ads_to_gcs.rst
-howto/operator/gcp/firestore.rst howto/operator/google/firebase/firestore.rst
-howto/operator/gcp/functions.rst howto/operator/google/cloud/functions.rst
-howto/operator/gcp/gcs.rst howto/operator/google/cloud/gcs.rst
-howto/operator/gcp/gcs_to_gcs.rst howto/operator/google/transfer/gcs_to_gcs.rst
-howto/operator/gcp/gcs_to_gdrive.rst howto/operator/google/transfer/gcs_to_gdrive.rst
-howto/operator/gcp/gcs_to_local.rst howto/operator/google/transfer/gcs_to_local.rst
-howto/operator/gcp/gcs_to_sftp.rst howto/operator/google/transfer/gcs_to_sftp.rst
-howto/operator/gcp/gcs_to_sheets.rst howto/operator/google/transfer/gcs_to_sheets.rst
-howto/operator/gcp/index.rst howto/operator/google/cloud/index.rst
-howto/operator/gcp/kubernetes_engine.rst howto/operator/google/cloud/kubernetes_engine.rst
-howto/operator/gcp/life_sciences.rst howto/operator/google/cloud/life_sciences.rst
-howto/operator/gcp/local_to_gcs.rst howto/operator/google/transfer/local_to_gcs.rst
-howto/operator/gcp/natural_language.rst howto/operator/google/cloud/natural_language.rst
-howto/operator/gcp/presto_to_gcs.rst howto/operator/google/transfer/presto_to_gcs.rst
-howto/operator/gcp/pubsub.rst howto/operator/google/cloud/pubsub.rst
-howto/operator/gcp/search_ads.rst howto/operator/google/marketing_platform/search_ads.rst
-howto/operator/gcp/sftp_to_gcs.rst howto/operator/google/transfer/sftp_to_gcs.rst
-howto/operator/gcp/sheets.rst howto/operator/google/suite/sheets.rst
-howto/operator/gcp/sheets_to_gcs.rst howto/operator/google/transfer/sheets_to_gcs.rst
-howto/operator/gcp/spanner.rst howto/operator/google/cloud/spanner.rst
-howto/operator/gcp/speech_to_text.rst howto/operator/google/cloud/speech_to_text.rst
-howto/operator/gcp/stackdriver.rst howto/operator/google/cloud/stackdriver.rst
-howto/operator/gcp/text_to_speech.rst howto/operator/google/cloud/text_to_speech.rst
-howto/operator/gcp/translate.rst howto/operator/google/cloud/translate.rst
-howto/operator/gcp/translate_speech.rst howto/operator/google/cloud/translate_speech.rst
-howto/operator/gcp/video_intelligence.rst howto/operator/google/cloud/video_intelligence.rst
-howto/operator/gcp/vision.rst howto/operator/google/cloud/vision.rst
-
-# New URLs for CLI references
-cli-ref.rst cli-and-env-variables-ref.rst
-
-# Departments without a separate index yet
-howto/operator/google/suite/index.rst howto/operator/google/index.rst
-howto/operator/google/firebase/index.rst howto/operator/google/index.rst
-
-# Other operators guide redirects
-howto/operator/http/http.rst howto/operator/http.rst
-howto/operator/http/index.rst howto/operator/http.rst
-
 # Security
 howto/use-alternative-secrets-backend.rst security/secrets/secrets-backend/index.rst
 security.rst security/index.rst
+
+# Operators guides
+howto/operator/external.html howto/operator/external_task_sensor.rst

Review comment:
       did you mean it to be `.rst` ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org